From: Rob Herring <robh@kernel.org>
To: Harsh Agarwal <quic_harshq@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
quic_ppratap@quicinc.com
Subject: Re: [RFC 1/2] dt-bindings: usb: dwc3: Add support for multiport related properties
Date: Mon, 23 May 2022 07:25:54 -0500 [thread overview]
Message-ID: <20220523122554.GA416176-robh@kernel.org> (raw)
In-Reply-To: <1652963695-10109-2-git-send-email-quic_harshq@quicinc.com>
On Thu, May 19, 2022 at 06:04:54PM +0530, Harsh Agarwal wrote:
> Added support for multiport, mport, num-ssphy and num-hsphy
> properties. These properties are used to support devices having
> a multiport controller.
>
> Signed-off-by: Harsh Agarwal <quic_harshq@quicinc.com>
> ---
> .../devicetree/bindings/usb/snps,dwc3.yaml | 55 ++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index f4471f8..39c61483 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -341,6 +341,35 @@ properties:
> This port is used with the 'usb-role-switch' property to connect the
> dwc3 to type C connector.
>
> + multiport:
> + description:
> + If a single USB controller supports multiple ports, then it's referred to as
> + a multiport controller. Each port of the multiport controller can support
> + either High Speed or Super Speed or both and have their own PHY phandles. Each
> + port is represented by "mport" node and all the "mport" nodes are grouped
> + together inside the "multiport" node where individual "mport" node defines the
> + PHYs supported by that port.
> + required:
> + - mport
> +
> + num-hsphy:
> + description: Total number of HS-PHYs defined by the multiport controller.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + num-ssphy:
> + description: Total number of SS-PHYs defined by the multiport controller.
> + $ref: /schemas/types.yaml#/definitions/uint32
These seem redundant. Can't you count ports/phys?
> +
> + mport:
> + description: Each mport node represents one port of the multiport controller.
> + patternProperties: "^mport@[0-9a-f]+$"
Think about how the USB device binding fits into this. A hub vs.
multiple root ports doesn't seem much different.
Rob
next prev parent reply other threads:[~2022-05-23 12:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 12:34 [RFC 0/2] Add support for multiport controller Harsh Agarwal
2022-05-19 12:34 ` [RFC 1/2] dt-bindings: usb: dwc3: Add support for multiport related properties Harsh Agarwal
2022-05-19 19:23 ` Rob Herring
2022-05-21 3:05 ` Bjorn Andersson
2022-05-23 11:54 ` Harsh Agarwal
2022-05-21 3:28 ` Pavan Kondeti
2022-05-23 12:25 ` Rob Herring [this message]
2022-05-27 11:09 ` Harsh Agarwal
2022-05-19 12:34 ` [RFC 2/2] usb: dwc3: Refactor PHY logic to support Multiport Controller Harsh Agarwal
2022-05-21 3:17 ` Bjorn Andersson
2022-05-23 11:53 ` Harsh Agarwal
2022-05-23 2:59 ` Pavan Kondeti
2022-05-23 7:08 ` Pavan Kondeti
2022-05-23 16:10 ` Brian Masney
2022-05-27 10:56 ` Harsh Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523122554.GA416176-robh@kernel.org \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_harshq@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).