From: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To: Ming Qian <ming.qian@nxp.com>
Cc: mchehab@kernel.org, mirela.rabulea@oss.nxp.com,
hverkuil-cisco@xs4all.nl, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] media: imx-jpeg: Leave a blank space before the configuration data
Date: Fri, 27 May 2022 11:38:24 +0200 [thread overview]
Message-ID: <20220527093824.GF11217@tom-ThinkPad-T14s-Gen-2i> (raw)
In-Reply-To: <20220527075437.16882-3-ming.qian@nxp.com>
Hi Ming,
I think have some comments on the code for this would be nice for the
future
On Fri, May 27, 2022 at 03:54:35PM +0800, Ming Qian wrote:
> There is a hardware bug that it will load
> the first 128 bytes of configuration data twice,
> it will led to some configure error.
> so shift the configuration data 128 bytes,
> and make the first 128 bytes all zero,
> then hardware will load the 128 zero twice,
From what I've understood you initialize cfg_stm with zeros then
you start to write the configuration from 0x80 (128 bytes), avoiding the hw issue right?
> and ignore them as garbage.
> then the configuration data can be loaded correctly
>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
> ---
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index 734e1b65fbc7..ad4213e020f3 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -519,6 +519,7 @@ static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg,
> GFP_ATOMIC);
> if (!cfg_stm)
> goto err;
> + memset(cfg_stm, 0, MXC_JPEG_MAX_CFG_STREAM);
> jpeg->slot_data[slot].cfg_stream_vaddr = cfg_stm;
>
> skip_alloc:
> @@ -755,7 +756,7 @@ static unsigned int mxc_jpeg_setup_cfg_stream(void *cfg_stream_vaddr,
> u32 fourcc,
> u16 w, u16 h)
> {
> - unsigned int offset = 0;
> + unsigned int offset = 0x80;
> u8 *cfg = (u8 *)cfg_stream_vaddr;
> struct mxc_jpeg_sof *sof;
> struct mxc_jpeg_sos *sos;
> --
> 2.36.1
>
Thanks,
Tommaso
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
next prev parent reply other threads:[~2022-05-27 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 7:54 [PATCH] media: imx-jpeg: Correct some definition according specification Ming Qian
2022-05-27 7:54 ` [PATCH] media: imx-jpeg: Disable some unused interrupt Ming Qian
2022-05-27 7:54 ` [PATCH] media: imx-jpeg: Leave a blank space before the configuration data Ming Qian
2022-05-27 9:38 ` Tommaso Merciai [this message]
2022-05-27 9:52 ` [EXT] " Ming Qian
2022-05-27 10:05 ` Tommaso Merciai
2022-05-27 10:15 ` Ming Qian
2022-05-27 7:54 ` [PATCH] media: imx-jpeg: Align upwards buffer size Ming Qian
2022-05-27 7:54 ` [PATCH] media: imx-jpeg: Implement drain using v4l2-mem2mem helpers Ming Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527093824.GF11217@tom-ThinkPad-T14s-Gen-2i \
--to=tommaso.merciai@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=mirela.rabulea@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).