From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E071C43334 for ; Thu, 2 Jun 2022 13:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235235AbiFBNJT (ORCPT ); Thu, 2 Jun 2022 09:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232339AbiFBNJR (ORCPT ); Thu, 2 Jun 2022 09:09:17 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A706D13C4DA; Thu, 2 Jun 2022 06:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1654175356; x=1685711356; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5USZXaGXafMmZRCNGTL/y9r+1CJyT2qx7/K0xHXdLyA=; b=sH3M7xElzEvdFx6VIMC4SIDjdXACVcz0j9VNOu0WAP+QaGpOIhWecA+U c0g/y8XTBq7OlgZijSEbRv4CFd6xnrPTz1vQInQsXnPmBBNY8NG+S4GBO MYFicK2eG0jTkU/Cip+eLKSi6OS2nYPRC4wdzfKFKrWEQ+44/r6OM9IyN 0=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-01.qualcomm.com with ESMTP; 02 Jun 2022 06:09:16 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 06:09:16 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 2 Jun 2022 06:09:15 -0700 Received: from hu-pkondeti-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 2 Jun 2022 06:09:09 -0700 Date: Thu, 2 Jun 2022 18:39:05 +0530 From: Pavan Kondeti To: Krishna Kurapati CC: Krzysztof Kozlowski , Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , "Matthias Kaehlcke" , Mathias Nyman , , , , , , , , Subject: Re: [PATCH v20 0/5] USB DWC3 host wake up support from system suspend Message-ID: <20220602130905.GC2521@hu-pkondeti-hyd.qualcomm.com> References: <1654158277-12921-1-git-send-email-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1654158277-12921-1-git-send-email-quic_kriskura@quicinc.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 02, 2022 at 01:54:32PM +0530, Krishna Kurapati wrote: > Avoiding phy powerdown in host mode when dwc3 is wakeup capable, so that > it can be wake up by devices. Keep usb30_prim gdsc active to retain > controller status during suspend/resume. > > Changes in v20: > Fixed nitpicks in dwc3 qcom driver. > Fixed code changes in dwc3 core driver. > > Changes in v19: > Fixed dwc3 driver code changes. > > Changes in v18: > Fixed minor nit picks in v17 reported by Matthias. > > Changes in v17: > Moved the speed check to glue driver. > Powering down phy's solely based on dwc3 wakeup capability. > Configuring the interrupt functions appropriately. > > Changes in v16: > Added changes to power down the phy's during suspend only if dwc3 > is not wakeup capable. > > Changes in v15: > Added patch to enable wakeup for xhci-plat based on children wakeup status. > Used device_wakeup_path instead of device_children_wakeup_capable > > Changes in v14: > Added patch for device_children_wakeup_capable. > Used device_children_wakeup_capable instead of usb_wakeup_enabled_descendants. > Fixed minor nit picks in v13 reported by Matthias. > > Changes in v13: > Moved the dt bindings patch to start. > Changed dwc3_set_phy_speed_mode to dwc3_check_phy_speed_mode. > Check wakep-source property for dwc3 core node to set the > wakeup capability. Drop the device_init_wakeup call from > runtime suspend and resume. > Added GENPD_FLAG_RPM_ALWAYS_ON and set GENPD_FLAG_ALWAYS_ON if > wakeup is supported. > > Changes in v12: > Squashed PATCH 1/5 and 2/5 of v11. > Added dt bindings and device tree entry for wakeup-source property > for dwc3 core node. > Dropped redundant phy_set_mode call. > > > Changes in v11: > Moving back to v8 version > https://patchwork.kernel.org/project/linux-arm-msm/cover/1624882097-23265-1-git-send-email-sanm@codeaurora.org > as we are getting interrupts during suspend > when enabling both DP hs phy irq and DM hs phy irq. > Moved the set phy mode function to dwc3/core.c from xhci-plat.c > We didn't find any other option other than accessing xhci from dwc. > > Changes in v10: > PATCH 1/6: Change device_set_wakeup_capable to device_set_wakeup_enable > PATCH 2/6: Remove redundant else part in dwc3_resume_common > PATCH 4/6: Change the irg flags > PATCH 5/6: Set flag GENPD_FLAG_ALWAYS_ON > PATCH 6/6: Remove disable interrupts function and enable > interrupts in probe. > > > Changes in v9: > Checking with device_may_makeup property instead of phy_power_off flag. > Changed the IRQ flags and removed hs_phy_mode variable. > > Changes in v8: > Moved the dwc3 suspend quirk code in dwc3/host.c to xhci-plat.c > Checking phy_power_off flag instead of usb_wakeup_enabled_descendants > to keep gdsc active. > > Changes in v7: > Change in commit text and message in PATCH 1/5 and PATCH 5/5 > as per Matthias suggestion. > Added curly braces for if and else if sections in PATCH 4/5. > > Changes in v6: > Addressed comments in host.c and core.c > Separated the patches in dwc3-qcom.c to make it simple. > Dropped wakeup-source change as it is not related to this series. > > Changes in v5: > Added phy_power_off flag to check presence of wakeup capable devices. > Dropped patch[v4,4/5] as it is present linux-next. > Addressed comments in host.c and dwc3-qcom.c. > > Changes in v4: > Addressed Matthias comments raised in v3. > > Changes in v3: > Removed need_phy_for_wakeup flag and by default avoiding phy powerdown. > Addressed Matthias comments and added entry for DEV_SUPERSPEED. > Added suspend_quirk in dwc3 host and moved the dwc3_set_phy_speed_flags. > Added wakeup-source dt entry and reading in dwc-qcom.c glue driver. > > Changes in v2: > Dropped the patch in clock to set GENPD_FLAG_ACTIVE_WAKEUP flag and > setting in usb dwc3 driver. > Separated the core patch and glue driver patch. > Made need_phy_for_wakeup flag part of dwc structure and > hs_phy_flags as unsgined int. > Adrressed the comment on device_init_wakeup call. > Corrected offset for reading portsc register. > Added pacth to support wakeup in xo shutdown case. > > Sandeep Maheswaram (5): > dt-bindings: usb: dwc3: Add wakeup-source property support > usb: dwc3: core: Host wake up support from system suspend > usb: dwc3: qcom: Add helper functions to enable,disable wake irqs > usb: dwc3: qcom: Configure wakeup interrupts during suspend > usb: dwc3: qcom: Keep power domain on to retain controller status > > .../devicetree/bindings/usb/snps,dwc3.yaml | 5 + > drivers/usb/dwc3/core.c | 9 +- > drivers/usb/dwc3/dwc3-qcom.c | 140 +++++++++++++++------ > 3 files changed, 108 insertions(+), 46 deletions(-) > This series looks good to me. I think it is ready for merge unless Felipe has any concerns. Thanks, Pavan