From: Prashant Malani <pmalani@chromium.org>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: bleung@chromium.org, swboyd@chromium.org,
heikki.krogerus@linux.intel.com,
"Pin-Yen Lin" <treapking@chromium.org>,
"Prashant Malani" <pmalani@chromium.org>,
"Allen Chen" <allen.chen@ite.com.tw>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"José Expósito" <jose.exposito89@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Maxime Ripard" <maxime@cerno.tech>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Xin Ji" <xji@analogixsemi.com>
Subject: [PATCH v5 7/9] drm/bridge: it6505: Register number of Type C switches
Date: Wed, 22 Jun 2022 17:34:36 +0000 [thread overview]
Message-ID: <20220622173605.1168416-8-pmalani@chromium.org> (raw)
In-Reply-To: <20220622173605.1168416-1-pmalani@chromium.org>
From: Pin-Yen Lin <treapking@chromium.org>
Parse the "switches" node, if available, and count and store the number
of Type-C switches within it. The extcon registration is still
supported, but we don't expect both extcon and typec-switch be
registered at the same time.
This patch sets a foundation for the actual registering of Type-C
switches with the Type-C connector class framework.
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
v5 is the first version for this patch.
drivers/gpu/drm/bridge/ite-it6505.c | 34 +++++++++++++++++++++++++----
1 file changed, 30 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..b259f9f367f6 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -452,6 +452,7 @@ struct it6505 {
struct delayed_work delayed_audio;
struct it6505_audio_data audio;
struct dentry *debugfs;
+ int num_typec_switches;
/* it6505 driver hold option */
bool enable_drv_hold;
@@ -3229,13 +3230,28 @@ static void it6505_shutdown(struct i2c_client *client)
it6505_lane_off(it6505);
}
+static int it6505_register_typec_switches(struct device *device, struct it6505 *it6505)
+{
+ struct device_node *of;
+
+ of = of_get_child_by_name(device->of_node, "switches");
+ if (!of)
+ return -ENODEV;
+
+ it6505->num_typec_switches = of_get_child_count(of);
+ if (it6505->num_typec_switches <= 0)
+ return -ENODEV;
+
+ return 0;
+}
+
static int it6505_i2c_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct it6505 *it6505;
struct device *dev = &client->dev;
struct extcon_dev *extcon;
- int err, intp_irq;
+ int err, intp_irq, ret;
it6505 = devm_kzalloc(&client->dev, sizeof(*it6505), GFP_KERNEL);
if (!it6505)
@@ -3255,11 +3271,21 @@ static int it6505_i2c_probe(struct i2c_client *client,
if (PTR_ERR(extcon) == -EPROBE_DEFER)
return -EPROBE_DEFER;
if (IS_ERR(extcon)) {
- dev_err(dev, "can not get extcon device!");
- return PTR_ERR(extcon);
+ if (PTR_ERR(extcon) != -ENODEV)
+ dev_warn(dev, "Cannot get extcon device: %ld", PTR_ERR(extcon));
+ it6505->extcon = NULL;
+ } else {
+ it6505->extcon = extcon;
}
- it6505->extcon = extcon;
+ ret = it6505_register_typec_switches(dev, it6505);
+ if (ret) {
+ dev_dbg(dev, "Didn't register Type C switches, err: %d", ret);
+ if (!it6505->extcon) {
+ dev_err(dev, "Both extcon and typec-switch are not registered.");
+ return -EINVAL;
+ }
+ }
it6505->regmap = devm_regmap_init_i2c(client, &it6505_regmap_config);
if (IS_ERR(it6505->regmap)) {
--
2.37.0.rc0.104.g0611611a94-goog
next prev parent reply other threads:[~2022-06-22 17:45 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 17:34 [PATCH v5 0/9] usb: typec: Introduce typec-switch binding Prashant Malani
2022-06-22 17:34 ` [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding Prashant Malani
2022-06-23 18:30 ` Stephen Boyd
2022-06-23 19:08 ` Prashant Malani
2022-06-23 23:14 ` Stephen Boyd
2022-06-24 0:35 ` Prashant Malani
2022-06-24 1:24 ` Prashant Malani
2022-06-24 2:13 ` Stephen Boyd
2022-06-24 2:48 ` Prashant Malani
2022-06-24 19:50 ` Stephen Boyd
2022-06-24 21:41 ` Prashant Malani
2022-06-25 1:21 ` Stephen Boyd
2022-06-25 20:13 ` Krzysztof Kozlowski
2022-06-27 21:04 ` Rob Herring
2022-06-27 21:43 ` Prashant Malani
2022-06-28 18:23 ` Rob Herring
2022-06-29 14:33 ` Pin-yen Lin
2022-06-29 15:00 ` Pin-yen Lin
2022-06-29 17:58 ` Rob Herring
2022-06-29 21:58 ` Stephen Boyd
2022-06-29 22:55 ` Prashant Malani
2022-06-29 23:55 ` Stephen Boyd
2022-06-30 17:10 ` Prashant Malani
2022-07-12 17:45 ` Rob Herring
2022-07-13 21:58 ` Prashant Malani
2022-09-02 7:41 ` Prashant Malani
2022-09-16 18:21 ` Prashant Malani
2022-10-03 3:42 ` Pin-yen Lin
2022-06-22 17:34 ` [PATCH v5 2/9] dt-bindings: drm/bridge: anx7625: Add mode-switch support Prashant Malani
2022-06-22 17:34 ` [PATCH v5 3/9] drm/bridge: anx7625: Register number of Type C switches Prashant Malani
2022-06-22 17:34 ` [PATCH v5 4/9] drm/bridge: anx7625: Register Type-C mode switches Prashant Malani
2022-06-22 17:34 ` [PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function Prashant Malani
2022-06-28 19:25 ` Stephen Boyd
2022-06-28 19:48 ` Prashant Malani
2022-06-28 20:40 ` Stephen Boyd
2022-06-28 20:56 ` Prashant Malani
2022-06-30 23:21 ` Stephen Boyd
2022-06-30 23:38 ` Prashant Malani
2022-07-06 18:26 ` Prashant Malani
2022-07-07 0:17 ` Stephen Boyd
2022-07-12 10:22 ` Pin-yen Lin
2022-06-22 17:34 ` [PATCH v5 6/9] dt/bindings: drm/bridge: it6505: Add mode-switch support Prashant Malani
2022-06-23 18:24 ` Stephen Boyd
2022-06-23 18:37 ` Prashant Malani
2022-06-23 19:08 ` Stephen Boyd
2022-06-23 19:15 ` Prashant Malani
2022-06-22 17:34 ` Prashant Malani [this message]
2022-06-27 21:05 ` [PATCH v5 7/9] drm/bridge: it6505: Register number of Type C switches Rob Herring
2022-06-22 17:34 ` [PATCH v5 8/9] drm/bridge: it6505: Register Type-C mode switches Prashant Malani
2022-06-22 17:34 ` [PATCH v5 9/9] drm/bridge: it6505: Add typec_mux_set callback function Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622173605.1168416-8-pmalani@chromium.org \
--to=pmalani@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jose.exposito89@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).