From: Rob Herring <robh@kernel.org>
To: Hakan Jansson <hakan.jansson@infineon.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: net: broadcom-bluetooth: Add CYW55572 DT binding
Date: Mon, 27 Jun 2022 11:34:36 -0600 [thread overview]
Message-ID: <20220627173436.GA2616639-robh@kernel.org> (raw)
In-Reply-To: <cb973352-36f9-8d70-95ac-5b63a566422c@infineon.com>
On Mon, Jun 20, 2022 at 04:06:25PM +0200, Hakan Jansson wrote:
> Hi Krzysztof,
>
> Thanks for replying.
>
> On 6/20/2022 2:32 PM, Krzysztof Kozlowski wrote:
> > > CYW55572 is a Wi-Fi + Bluetooth combo device from Infineon.
> > > Extend the binding with its DT compatible.
> > >
> > > Signed-off-by: Hakan Jansson <hakan.jansson@infineon.com>
> > > ---
> > > Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> > > index df59575840fe..71fe9b17f8f1 100644
> > > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> > > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> > > @@ -24,6 +24,7 @@ properties:
> > > - brcm,bcm43540-bt
> > > - brcm,bcm4335a0
> > > - brcm,bcm4349-bt
> > > + - infineon,cyw55572-bt
> > Patch is okay, but just to be sure - is it entirely different device
> > from Infineon or some variant of Broadcom block?
>
> CYW55572 is a new device from Infineon. It is not the same as any Broadcom
> device.
>
> > Are all existing
> > properties applicable to it as well?
>
> Yes, all existing properties are applicable.
Including 'brcm,bt-pcm-int-params'? I don't see a BT reset signal
either, but maybe that's not pinned out in the AzureWave module which
was the only documentation details I could find[1].
I think a separate doc will be better as it can be more precise as to
what's allowed or not. It's fine to reuse the same property names
though.
Rob
[1] https://www.azurewave.com/img/infineon/AW-XH316_DS_DF_A_STD.pdf
next prev parent reply other threads:[~2022-06-27 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:01 [PATCH 0/4] Bluetooth: hci_bcm: Improve FW load time on CYW55572 Hakan Jansson
2022-06-20 12:01 ` [PATCH 1/4] dt-bindings: net: broadcom-bluetooth: Add CYW55572 DT binding Hakan Jansson
2022-06-20 12:32 ` Krzysztof Kozlowski
2022-06-20 14:06 ` Hakan Jansson
2022-06-27 17:34 ` Rob Herring [this message]
2022-06-28 14:03 ` Hakan Jansson
2022-06-28 22:41 ` Rob Herring
2022-06-29 10:29 ` Hakan Jansson
2022-06-20 15:57 ` Krzysztof Kozlowski
2022-06-20 12:01 ` [PATCH 2/4] Bluetooth: hci_bcm: Add DT compatible for CYW55572 Hakan Jansson
2022-06-20 12:01 ` [PATCH 3/4] Bluetooth: hci_bcm: Prevent early baudrate setting in autobaud mode Hakan Jansson
2022-06-28 12:32 ` Linus Walleij
2022-06-20 12:01 ` [PATCH 4/4] Bluetooth: hci_bcm: Increase host baudrate for CYW55572 " Hakan Jansson
2022-06-20 12:21 ` Paul Menzel
2022-06-21 17:15 ` Hakan Jansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627173436.GA2616639-robh@kernel.org \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hakan.jansson@infineon.com \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).