From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC3AECCA47E for ; Thu, 30 Jun 2022 10:10:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232411AbiF3KKG (ORCPT ); Thu, 30 Jun 2022 06:10:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234775AbiF3KKD (ORCPT ); Thu, 30 Jun 2022 06:10:03 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81D2C44757 for ; Thu, 30 Jun 2022 03:10:01 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id c65so25870959edf.4 for ; Thu, 30 Jun 2022 03:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=x6R57O4urDU2YjNPka2DlENCvQCcdTvXSj/0KHICFvk=; b=eKHSxJefHg0CoOL2feCoVC5QCjWK9UF6S0HKL9jJOuBW37cd3oXCW3nTgIzOVHssPj 8PBatKJJnBYHF7qSohjVIoypeRZdXwDJXQxqxfrs2Gr10gGecbM7ok/vl+Qxfse/g72Q 0BRoQZU1FJK6I/e0+N5/Lqi9TbcE3DjSuijZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=x6R57O4urDU2YjNPka2DlENCvQCcdTvXSj/0KHICFvk=; b=AZ5yfVkeijXS3AjuWyoGBHLYR7wlHfm7/4SgmFDXPQmaFqbGb+Ydj79guwoAQ97wMC GCDP6EySPjkOJpoMTpDc1YPwhv8uWx4uSbzJ66JT1N8ci9TO/pJJa110XSyZjDOt7G9d wHvN4rRV7EwYKkzVzMIJjlax+LgHn9z46XZC8Mw6eiMB0Y7qdXLc76cceOQZy0sO0shV c36WNdmXP8gdqaMk15UW135yMCDQldSjLymJLMK2lMC6/aD+N+TUUh1XAm7yfqyJ46T+ h9rZbMC63qm6CGM9tar4QJp8hStLQPT6HV1Yq5DMWrIMsqdpRxjnclNabTJiToXXWss0 7Yrg== X-Gm-Message-State: AJIora/6+P30xq9xYRo47dnybZwLxEOXxECXp+LlJXjCJhJ/IO3/xy/m jhwCnzWmvjYOBGAQqKy9CKNmpA== X-Google-Smtp-Source: AGRyM1s57Tso0VPPeTN/5BjZ19cWWdP1rE0VdmfYtKSB4A4yhMw+PDOMywZW8+5MiwdKuvAraxT43w== X-Received: by 2002:a05:6402:2743:b0:437:d467:4a57 with SMTP id z3-20020a056402274300b00437d4674a57mr10586294edd.235.1656583800074; Thu, 30 Jun 2022 03:10:00 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id q4-20020a1709064cc400b006fec4ee28d0sm8824131ejt.189.2022.06.30.03.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 03:09:59 -0700 (PDT) Date: Thu, 30 Jun 2022 12:09:57 +0200 From: Tommaso Merciai To: Sakari Ailus Cc: Krzysztof Kozlowski , linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/6] media: dt-bindings: ov5693: document YAML binding Message-ID: <20220630100957.GE482517@tom-ThinkPad-T14s-Gen-2i> References: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> <20220630074525.481790-6-tommaso.merciai@amarulasolutions.com> <167f09c1-795d-1471-20f7-9f4df29355ed@linaro.org> <20220630090232.GC482517@tom-ThinkPad-T14s-Gen-2i> <20220630091613.GD482517@tom-ThinkPad-T14s-Gen-2i> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sakari, On Thu, Jun 30, 2022 at 12:50:05PM +0300, Sakari Ailus wrote: > Hi Tommaso, > > On Thu, Jun 30, 2022 at 11:16:13AM +0200, Tommaso Merciai wrote: > > Hi Sakari, > > > > On Thu, Jun 30, 2022 at 12:12:47PM +0300, Sakari Ailus wrote: > > > On Thu, Jun 30, 2022 at 11:02:32AM +0200, Tommaso Merciai wrote: > > > > On Thu, Jun 30, 2022 at 10:07:19AM +0200, Krzysztof Kozlowski wrote: > > > > > On 30/06/2022 09:45, Tommaso Merciai wrote: > > > > > > Add documentation of device tree in YAML schema for the OV5693 > > > > > > CMOS image sensor from Omnivision > > > > > > > > > > > > Signed-off-by: Tommaso Merciai > > > > > > Reviewed-by: Krzysztof Kozlowski > > > > > > Reviewed-by: Sakari Ailus > > > > > > > > > > How Sakari's tag appeared here? There was no email from him. > > > > > > > > Sakari made me some review on v2, but I think he forgot to add the mailing > > > > list in cc. ( I suppose :) ) > > > > > > > > Let me know if I need to remove this. > > > > > > You're only supposed to put these tags into patches if you get them in > > > written form as part of the review, signalling acceptance of the patch in > > > various forms. Just commenting a patch does not imply this. > > > > > > Please also see Documentation/process/submitting-patches.rst for more > > > information on how to use the tags. > > > > Thanks for sharing this. My bad. > > I remove your tags. > > The patches themselves seem fine. I'd just drop the 4th patch or at least > come up with a better name for ov5693_hwcfg() --- you're acquiring > resources there, and that generally fits well for probe. The code is fine > already. Then we don't need v5 with your reviewed tags removed? I think the patch4 is needed to add dts support properly. Also this contains devm_clk_get_optional fix suggested by Jacopo and support for ACPI-based platforms that specify the clock frequency by using the "clock-frequency" property instead of specifying a clock provider reference. Some suggestion on the function name? Thanks, Tommaso > > -- > Sakari Ailus -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com