From: Serge Semin <fancer.lancer@gmail.com>
To: Conor Dooley <mail@conchuod.ie>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Niklas Cassel <niklas.cassel@wdc.com>,
Dillon Min <dillon.minfei@gmail.com>,
Jose Abreu <joabreu@synopsys.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
alsa-devel@alsa-project.org, linux-spi@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 05/15] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts
Date: Fri, 1 Jul 2022 00:55:40 +0300 [thread overview]
Message-ID: <20220630215540.cifnzovya57bgbsw@mobilestation> (raw)
In-Reply-To: <20220629184343.3438856-6-mail@conchuod.ie>
On Wed, Jun 29, 2022 at 07:43:34PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> The Canaan k210 apparently has a Sysnopsys Designware AXI DMA
> controller, but according to the documentation & devicetree it has 6
> interrupts rather than the standard one. Support the 6 interrupt
> configuration by unconditionally extending the binding to a maximum of
> 8 per-channel interrupts thereby matching the number of possible
> channels.
>
> Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 4324a94b26b2..e33ef22aec9c 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -34,7 +34,9 @@ properties:
> - const: axidma_apb_regs
>
> interrupts:
> - maxItems: 1
> + description: per channel interrupts
Description is inaccurate. It's either combined or per-channel IRQs.
Other than that:
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
> + minItems: 1
> + maxItems: 8
>
> clocks:
> items:
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-06-30 21:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 18:43 [PATCH v3 00/15] Canaan devicetree fixes Conor Dooley
2022-06-29 18:43 ` [PATCH v3 01/15] dt-bindings: display: convert ilitek,ili9341.txt to dt-schema Conor Dooley
2022-06-29 18:43 ` [PATCH v3 02/15] dt-bindings: display: ili9341: document canaan kd233's lcd Conor Dooley
2022-07-01 19:38 ` Rob Herring
2022-06-29 18:43 ` [PATCH v3 03/15] ASoC: dt-bindings: convert designware-i2s to dt-schema Conor Dooley
2022-07-01 19:39 ` Rob Herring
2022-06-29 18:43 ` [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width Conor Dooley
2022-06-30 16:57 ` Rob Herring
2022-06-30 21:43 ` Serge Semin
2022-06-29 18:43 ` [PATCH v3 05/15] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts Conor Dooley
2022-06-30 21:55 ` Serge Semin [this message]
2022-06-30 23:12 ` Conor.Dooley
2022-07-01 19:41 ` Rob Herring
2022-06-29 18:43 ` [PATCH v3 06/15] dt-bindings: memory-controllers: add canaan k210 sram controller Conor Dooley
2022-06-29 18:43 ` [PATCH v3 07/15] riscv: dts: canaan: fix the k210's memory node Conor Dooley
2022-06-29 18:43 ` [PATCH v3 08/15] riscv: dts: canaan: fix the k210's timer nodes Conor Dooley
2022-06-30 21:51 ` Serge Semin
2022-06-29 18:43 ` [PATCH v3 09/15] riscv: dts: canaan: fix mmc node names Conor Dooley
2022-06-29 18:43 ` [PATCH v3 10/15] riscv: dts: canaan: fix kd233 display spi frequency Conor Dooley
2022-06-29 18:43 ` [PATCH v3 11/15] riscv: dts: canaan: use custom compatible for k210 i2s Conor Dooley
2022-06-29 18:43 ` [PATCH v3 12/15] riscv: dts: canaan: remove spi-max-frequency from controllers Conor Dooley
2022-06-29 18:43 ` [PATCH v3 13/15] riscv: dts: canaan: fix bus {ranges,reg} warnings Conor Dooley
2022-06-30 16:49 ` Niklas Cassel
2022-06-30 17:02 ` Conor.Dooley
2022-06-30 19:31 ` Conor.Dooley
2022-06-29 18:43 ` [PATCH v3 14/15] riscv: dts: canaan: add specific compatible for kd233's LCD Conor Dooley
2022-06-29 18:43 ` [PATCH v3 15/15] riscv: dts: canaan: build all devicetress if SOC_CANAAN Conor Dooley
2022-06-30 16:28 ` [PATCH v3 00/15] Canaan devicetree fixes Niklas Cassel
2022-06-30 16:38 ` Conor.Dooley
2022-06-30 17:53 ` Sudeep Holla
2022-06-30 18:01 ` Conor.Dooley
2022-06-30 18:21 ` Sudeep Holla
2022-06-30 18:30 ` Conor.Dooley
2022-06-30 21:16 ` Damien Le Moal
2022-07-01 11:14 ` Sudeep Holla
2022-07-01 10:31 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630215540.cifnzovya57bgbsw@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mail@conchuod.ie \
--cc=masahiroy@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).