From: Robert Hancock <robert.hancock@calian.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"mounika.grace.akula@xilinx.com" <mounika.grace.akula@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Thinh.Nguyen@synopsys.com" <Thinh.Nguyen@synopsys.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"manish.narani@xilinx.com" <manish.narani@xilinx.com>,
"balbi@kernel.org" <balbi@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 3/5] dt-bindings: usb: dwc3: add reference clock period fractional adjustment
Date: Thu, 13 Jan 2022 17:58:37 +0000 [thread overview]
Message-ID: <2273126d255bd126e4ec97e90316027308b41c15.camel@calian.com> (raw)
In-Reply-To: <CAL_JsqKn16rZxRCaQQnxW+BRjxzQdn9DqUmj-XiyJuxBegg0dw@mail.gmail.com>
On Wed, 2022-01-12 at 13:46 -0600, Rob Herring wrote:
> On Wed, Jan 12, 2022 at 10:54 AM Robert Hancock
> <robert.hancock@calian.com> wrote:
> > On Tue, 2022-01-11 at 09:14 -0600, Rob Herring wrote:
> > > On Mon, 10 Jan 2022 14:19:34 -0600, Robert Hancock wrote:
> > > > Document the new snps,ref-clock-fladj property which can be used to set
> > > > the fractional portion of the reference clock period.
> > > >
> > > > Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> > > > ---
> > > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 ++++++++++++
> > > > 1 file changed, 12 insertions(+)
> > > >
> > >
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > schemas/usb/snps,dwc3.yaml: ignoring, error in schema: properties:
> > > snps,ref-
> > > clock-fladj
> >
> > I'm assuming this schema file needs to be updated, but I'm not sure where
> > it
> > lives? I don't see such a file in the devicetree-org/dt-schema repo?
>
> Try Documentation/devicetree/bindings/usb/snps,dwc3.yaml
That's the one I'm patching, but it seems like it is comparing that to another
schema file that I can't find, and is unhappy because the new property I'm
adding isn't there? The way it's defined in the bindings file itself seems no
different from the others:
dtschema/dtc warnings/errors:
schemas/usb/snps,dwc3.yaml: ignoring, error in schema: properties: snps,ref-
clock-fladj
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml:
properties:snps,ref-clock-fladj: 'oneOf' conditional failed, one must be fixed:
--
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com
next prev parent reply other threads:[~2022-01-13 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 20:19 [PATCH v3 0/5] Xilinx ZynqMP USB fixes Robert Hancock
2022-01-10 20:19 ` [PATCH v3 1/5] usb: dwc3: xilinx: Fix PIPE clock selection for USB2.0 mode Robert Hancock
2022-01-10 20:19 ` [PATCH v3 2/5] usb: dwc3: xilinx: Fix error handling when getting USB3 PHY Robert Hancock
2022-01-10 20:19 ` [PATCH v3 3/5] dt-bindings: usb: dwc3: add reference clock period fractional adjustment Robert Hancock
2022-01-11 15:14 ` Rob Herring
2022-01-12 16:53 ` Robert Hancock
2022-01-12 19:46 ` Rob Herring
2022-01-13 17:58 ` Robert Hancock [this message]
2022-01-14 2:18 ` Rob Herring
2022-01-14 4:30 ` Robert Hancock
2022-01-10 20:19 ` [PATCH v3 4/5] usb: dwc3: add reference clock FLADJ configuration Robert Hancock
2022-01-10 20:19 ` [PATCH v3 5/5] arm64: dts: zynqmp: Add DWC3 USB reference clock period configuration Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2273126d255bd126e4ec97e90316027308b41c15.camel@calian.com \
--to=robert.hancock@calian.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=mounika.grace.akula@xilinx.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).