devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Change RK809 PMIC interrupt polarity
Date: Fri, 06 Dec 2019 18:09:03 +0100	[thread overview]
Message-ID: <22838931.IDdASOIBor@phil> (raw)
In-Reply-To: <20191206173453.1b2f7844@xps13>

Hi Miquel,

Am Freitag, 6. Dezember 2019, 17:34:53 CET schrieb Miquel Raynal:
> Heiko Stuebner <heiko@sntech.de> wrote on Fri, 06 Dec 2019 17:01:58
> +0100:
> > Am Freitag, 6. Dezember 2019, 16:52:50 CET schrieb Miquel Raynal:
> > > Heiko Stuebner <heiko@sntech.de> wrote on Fri, 06 Dec 2019 16:48:00
> > > +0100:
> > > > Am Freitag, 6. Dezember 2019, 16:42:47 CET schrieb Miquel Raynal:  
> > > > > PMIC interrupt can be active high or active low depending on BIT(1) of
> > > > > the GPIO_INT_CFG pin. The default is 0x1, which means active
> > > > > high. Change the polarity in the device tree to reflect the default
> > > > > state.
> > > > > 
> > > > > Without this and with the current code base, the interrupt never stops
> > > > > triggering while the MFD driver does not see anything to
> > > > > check/clear/mask so after 100000 spurious IRQs, the kernel simply
> > > > > desactivates the interrupt:
> > > > > 
> > > > >         irq 36: nobody cared (try booting with the "irqpoll" option)
> > > > >         [...]
> > > > >         handlers:
> > > > >         [<(____ptrval____)>] irq_default_primary_handler threaded
> > > > > 	[<(____ptrval____)>] regmap_irq_thread
> > > > >         Disabling IRQ #36
> > > > > 
> > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>    
> > > > 
> > > > *coughs slightly*
> > > > 
> > > > mfd: rk808: Set RK817 interrupt polarity to low
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/drivers/mfd/rk808.c?h=for-mfd-next&id=dbd16ef53487084816a20f662423ab543a75fc83
> > > > 
> > > > Should be in the current merge window already I guess ;-)  
> > > 
> > > This time I swear I checked your tree. But this time we did not ended
> > > with the same fix so I missed this one *again* :)  
> > 
> > No worries ... I guess I should check where I hid additional patches ;-)
> > 
> > So right now px30 stuff is in the trees:
> > - mine
> > - mfd
> > - phy (first round of dsi phy, refinement pending on the list)
> > - nvmem (for the otp controller)
> > - drm (drm/rockchip: vop: add the definition of dclk_pol)
> > - clk
> > 
> > and pending on lists:
> > - drm (dsi support + timings)
> > - phy (refinement as mentioned above)
> > 
> > not submitted yet but planning to get this done this weekend:
> > - panel driver for px30-evb
> > - dsi devicetree stuff
> 
> Thank you very much for the detailed list! I will soon work on the
> PMIC audio support and on secure boot, do not hesitate to ping me if
> you see this kind of work coming on the mailing list!

I think it's only us (you, Paul and me) working on px30 mainline stuff,
right now so it's only us that should probably coordinate :-)

Secureboot also is of interest to my project, so a Cc would be appreciated ;-)


Heiko



  reply	other threads:[~2019-12-06 17:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 15:42 [PATCH] arm64: dts: rockchip: Change RK809 PMIC interrupt polarity Miquel Raynal
2019-12-06 15:48 ` Heiko Stuebner
2019-12-06 15:52   ` Miquel Raynal
2019-12-06 16:01     ` Heiko Stuebner
2019-12-06 16:34       ` Miquel Raynal
2019-12-06 17:09         ` Heiko Stuebner [this message]
2019-12-06 17:16           ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22838931.IDdASOIBor@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).