From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68C8CCA481 for ; Fri, 24 Jun 2022 10:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231605AbiFXKpS (ORCPT ); Fri, 24 Jun 2022 06:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231642AbiFXKpN (ORCPT ); Fri, 24 Jun 2022 06:45:13 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 675707C86F for ; Fri, 24 Jun 2022 03:45:11 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id q6so3788650eji.13 for ; Fri, 24 Jun 2022 03:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=2t+7HTFw4Am9k5wfnt+zpTYwsim5TZ2i9yEsItPpeso=; b=xcoXh7yCPrSwwOXsVEte8S9NR0zXlkpvvmSX4mcTWFeTdYGxCOjXXMGpaIaqsIAE1K bp0d/k4GmQ8d8KFLm3LHJNOZx0WMiu4WZUX7HLNDAsZEJN1sptGsrLYyPxjY9ktKrSY+ anicQhYWBm83eN/+nf24xt/88s2e96BqLLMqqV5kNG1Cun51WNovucO46nd97ihvrKZF dnLW7i1sNcOp3Mp4GU7oElU9RGuLLHZTaYOd/EiSoahcaoQ1ovR0ARSV/9WojV7BCFK1 Svcita+pSItq8jdZ6ZzrgytfqP0wj21BQU9Nqu6VjwpUbWuvEYZFpH+8A2yDStdJm384 PEnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=2t+7HTFw4Am9k5wfnt+zpTYwsim5TZ2i9yEsItPpeso=; b=juwXGDXJhKxDPGjJNSAosFHIbIezEFeAoGNmrsLzTapwWDv8OBqa5bH59B4/Pxhll3 awuBBBJKuSrwSWj3yuQkSy1pkW5gRUkHfD5YYplystiuboVYrselig/hWRUEjJQW4SQc LZ9tOI9pY01yGH6uvy9WwBiVud9aJWN5cmV61WyZGjNGiNISoVNstTMMcWpaXEy5SGBw QAa5kriCTdr+Nbt/qYtJUi/BN02+ZjVSJ3O2x2A9SZjGBjkIIgZQUuIdhFU0ICydzRjp 7DvXSvzgLGxDAWQsXW06tegaP/cqV8DA8GluHV+bCUQowpWw42J5ezI85mwvSXyN6m1V sQIw== X-Gm-Message-State: AJIora/dHYv2PMiCW4I+vzzK11vz+J38BZx8vxZM352JRDS9uyxcS6rS 2VxybVwkW8csyzm/Sd7eD4+aTQ== X-Google-Smtp-Source: AGRyM1tk6j4mNtQk9qRRyVUy6ecFx8pKAt3xM74yrIfZScw1NM4v+j/hr8GYVIcM+2p5oRpQfs7mBA== X-Received: by 2002:a17:906:2dd:b0:712:1293:3dd8 with SMTP id 29-20020a17090602dd00b0071212933dd8mr12766549ejk.448.1656067509878; Fri, 24 Jun 2022 03:45:09 -0700 (PDT) Received: from [192.168.0.234] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id ci25-20020a170906c35900b006fe921fcb2dsm906732ejb.49.2022.06.24.03.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 03:45:09 -0700 (PDT) Message-ID: <237b1ecc-9a87-b37f-46fd-4612a7ae56f6@linaro.org> Date: Fri, 24 Jun 2022 12:45:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator Content-Language: en-US From: Krzysztof Kozlowski To: ChiaEn Wu , lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de Cc: chiaen_wu@richtek.com, alice_chen@richtek.com, cy_huang@richtek.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-4-peterwu.pub@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/06/2022 12:35, Krzysztof Kozlowski wrote: > On 23/06/2022 13:56, ChiaEn Wu wrote: >> From: ChiYuan Huang >> >> Add Mediatek mt6370 current sink type LED indicator binding documentation. >> >> Signed-off-by: ChiYuan Huang >> --- >> >> v3 >> - Use leds-class-multicolor.yaml instead of common.yaml. >> - Split multi-led and led node. >> - Add subdevice "led" in "multi-led". >> --- >> .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >> >> diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >> new file mode 100644 >> index 0000000..45030f3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >> @@ -0,0 +1,77 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: LED driver for MT6370 PMIC from MediaTek Integrated. >> + >> +maintainers: >> + - Alice Chen >> + >> +description: | >> + This module is part of the MT6370 MFD device. >> + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode >> + >> +allOf: >> + - $ref: leds-class-multicolor.yaml# >> + >> +properties: >> + compatible: >> + const: mediatek,mt6370-indicator >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> +patternProperties: >> + "^multi-led@[0-3]$": >> + type: object > > Here as well unevaluatedProperties:false (on the type level) Ah, no, it does not work currently. Your code looks good. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof