devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: lee.jones@linaro.org, robh+dt@kernel.org, heiko@sntech.de,
	sre@kernel.org, maccraft123mc@gmail.com,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
	Chris Morgan <macromorgan@hotmail.com>,
	Chris Morgan <macroalpha82@gmail.com>
Subject: Re: [PATCH v4 RESEND 0/4] power: supply: Add Support for RK817 Charger
Date: Tue, 30 Nov 2021 03:03:03 +0100	[thread overview]
Message-ID: <2759402.V8G6Gt6Xmj@archbook> (raw)
In-Reply-To: <20210916194208.10387-1-macroalpha82@gmail.com>

On Donnerstag, 16. September 2021 21:42:04 CET Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> This series is to add support for the Rockchip rk817 battery charger
> which is present in all Rockchip RK817 PMICs. The driver was written
> as a joint effort by Maya Matuszczyk <maccraft123mc@gmail.com> and
> myself Chris Morgan <macromorgan@hotmail.com>.

Hi Chris and Maya,

Gave this a whirl on my Quartz64 Model A. I noticed that this will
happily let me discharge past voltage_min_design:

 $ cat /sys/class/power_supply/rk817-battery/voltage_min_design 
 3625000
 $ cat /sys/class/power_supply/rk817-battery/voltage_avg 
 3381360

Is this normal? It went all the way to under 3V before the
board finally locked up.

Does the minimum voltage not affect some sort of cutout on
the RK817? Does it even have one? Is it the driver's job to
do something here or not?

Regards,
Nicolas Frattaroli



  parent reply	other threads:[~2021-11-30  2:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 19:42 [PATCH v4 RESEND 0/4] power: supply: Add Support for RK817 Charger Chris Morgan
2021-09-16 19:42 ` [PATCH v4 RESEND 1/4] dt-bindings: Add Rockchip rk817 battery charger support Chris Morgan
2021-09-22 19:19   ` Rob Herring
2021-09-16 19:42 ` [PATCH v4 RESEND 2/4] mfd: " Chris Morgan
2021-09-16 19:42 ` [PATCH v4 RESEND 3/4] power: supply: Add charger driver for Rockchip RK817 Chris Morgan
2021-10-13 17:40   ` Sebastian Reichel
2022-01-27 23:27     ` Peter Geis
2021-09-16 19:42 ` [PATCH v4 RESEND 4/4] arm64: dts: rockchip: add rk817 charger to Odroid Go Advance Chris Morgan
2021-11-30  2:03 ` Nicolas Frattaroli [this message]
     [not found]   ` <SN6PR06MB534222D7CA5732E689F5BA21A5679@SN6PR06MB5342.namprd06.prod.outlook.com>
2021-11-30 18:12     ` [PATCH v4 RESEND 0/4] power: supply: Add Support for RK817 Charger Nicolas Frattaroli
     [not found]       ` <SN6PR06MB5342DF2234B8F9599E1AF125A5679@SN6PR06MB5342.namprd06.prod.outlook.com>
2021-11-30 19:16         ` Nicolas Frattaroli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2759402.V8G6Gt6Xmj@archbook \
    --to=frattaroli.nicolas@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maccraft123mc@gmail.com \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).