From: <Tudor.Ambarus@microchip.com>
To: <Kavyasree.Kotagiri@microchip.com>, <arnd@arndb.de>,
<olof@lixom.net>, <robh+dt@kernel.org>,
<Nicolas.Ferre@microchip.com>
Cc: <soc@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Manohar.Puri@microchip.com>
Subject: Re: [PATCH] ARM: dts: add DT for lan966x SoC and 2-port board pcb8291
Date: Tue, 4 Jan 2022 07:07:12 +0000 [thread overview]
Message-ID: <29f7e062-5669-ef1c-a80c-5e5b7b01af79@microchip.com> (raw)
In-Reply-To: <CO1PR11MB48651B354ABAF04ABB53FB04924A9@CO1PR11MB4865.namprd11.prod.outlook.com>
On 1/4/22 7:20 AM, Kavyasree Kotagiri - I30978 wrote:
>> On 1/3/22 2:48 PM, Kavyasree Kotagiri wrote:
>>> diff --git a/arch/arm/boot/dts/lan966x_pcb8291.dts
>> b/arch/arm/boot/dts/lan966x_pcb8291.dts
>>> new file mode 100644
>>> index 000000000000..cd0454a795e7
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/lan966x_pcb8291.dts
>>> @@ -0,0 +1,55 @@
>>
>>> +&flx3 {
>>> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
>>> + status = "okay";
>>> +
>>> + usart0: serial@200 {
>>> + compatible = "atmel,at91sam9260-usart";
>>
>> The flexcom usart mode should be defined in the dtsi file, so that you
>> won't duplicate the definition in each dts that includes the dtsi file.
>>
> defining flexcom mode in dts as flx3 can be used as USART/I2C/SPI on different boards.
Right, you should define the mode in dtsi and enable it in the dts file.
> And it is not the same mode for all boards.
>
>> Cheers,
>> ta
next prev parent reply other threads:[~2022-01-04 7:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 12:48 [PATCH] ARM: dts: add DT for lan966x SoC and 2-port board pcb8291 Kavyasree Kotagiri
2022-01-03 13:42 ` Tudor.Ambarus
2022-01-04 5:20 ` Kavyasree.Kotagiri
2022-01-04 7:07 ` Tudor.Ambarus [this message]
2022-01-04 8:02 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29f7e062-5669-ef1c-a80c-5e5b7b01af79@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=Manohar.Puri@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).