From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E48C433EF for ; Mon, 15 Nov 2021 10:26:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E53EE61B04 for ; Mon, 15 Nov 2021 10:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237233AbhKOK3O (ORCPT ); Mon, 15 Nov 2021 05:29:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbhKOK3L (ORCPT ); Mon, 15 Nov 2021 05:29:11 -0500 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [IPv6:2001:4b7a:2000:18::163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9997FC061767 for ; Mon, 15 Nov 2021 02:26:08 -0800 (PST) Received: from [10.1.250.9] (riviera.nat.ds.pw.edu.pl [194.29.137.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 568011F625; Mon, 15 Nov 2021 11:26:04 +0100 (CET) Message-ID: <2af9b75a-b8f9-4ee8-efbe-53dd04365a18@somainline.org> Date: Mon, 15 Nov 2021 11:26:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 13/16] arm64: dts: qcom: Add support for Xperia 1 III / 5 III To: Trilok Soni , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Bjorn Andersson , Rob Herring , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211114012755.112226-1-konrad.dybcio@somainline.org> <20211114012755.112226-13-konrad.dybcio@somainline.org> <51341a10-c0a5-079e-b7f1-159d42211bf3@quicinc.com> From: Konrad Dybcio In-Reply-To: <51341a10-c0a5-079e-b7f1-159d42211bf3@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/11/2021 20:47, Trilok Soni wrote: > Hi Konrad, > > On 11/13/2021 5:27 PM, Konrad Dybcio wrote: >> >> Then, you need to flash it on the device and get rid of all the >> vendor_boot/dtbo mess: >> >> fastboot flash boot boot.img-sony-xperia-pdx215 >> fastboot erase vendor_boot >> fastboot flash dtbo emptydtbo.img >> fastboot reboot >> >> Where emptydtbo.img is a tiny file that consists of 2 bytes (all >> zeroes), doing >> a "fastboot erase" won't cut it, the bootloader will go crazy and >> things will >> fall apart when it tries to overlay random bytes from an empty >> partition onto a >> perfectly good appended DTB. > > > I will check on this part and see if we can make simpler support > fastboot erase dtbo without the extra emptydtbo. > > ---Trilok Soni Hi Trilok, that sounds great, thanks for looking into it! Could you also check why using a boot.img header version 2 (with a dtb embedded into the boot image using the --dtb option in mkbootimg) seems to be broken on 8350, too? I get a "your device is corrupted and will not boot" error, even though I disabled vbmeta/vbmeta_system and performed the same steps described in this commit message to dtbo/vendor_boot. It worked fine on 4.19-release SoCs without vendor_boot (8250, 6350), but it seems it doesn't anymore. Konrad