From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v5 2/2] spi: Add generic SPI multiplexer
Date: Fri, 20 Nov 2020 17:18:50 +0100 [thread overview]
Message-ID: <2b7f555bee663a033e2e8fc50f019c9b580a7c66.camel@suse.de> (raw)
In-Reply-To: <104152dd-a51e-1893-cc6b-022aecd89250@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
On Tue, 2020-11-17 at 00:08 +0000, Chris Packham wrote:
> On 14/11/20 4:46 am, Nicolas Saenz Julienne wrote:
> > Upon registering spi-mux's devices through spi_add_device() the kernel gets
> > stuck waiting for the 'spi_add_lock' mutex to be released. The mutex happens to
> > be held by spi-mux's parent SPI bus, which unluckily, is waiting for spi-mux's
> > probe to finish before releasing it.
>
> I just re-tested my system with v5.10.0-rc4 and didn't see any problem.
> My dts is pretty similar to yours the only obvious thing missing is
> `mux-control-names = "spi";` and I also set `#size-cells = <1>;` (let me
> know if you want me to post the whole thing).
>
> It might be dependent on the host spi controller. The re-test I just did
> was on a board using the spi-orion.c driver and I tested my original
> change on a board using spi-bcm-qspi.c (I haven't got the board handy
> right now but I could go and find one if necessary).
Found the issue, something silly on my side. Sorry for the noise.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-11-20 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 3:28 [PATCH v5 0/2] SPI bus multiplexing Chris Packham
2020-02-04 3:28 ` [PATCH v5 1/2] dt-bindings: spi: Document binding for generic SPI multiplexer Chris Packham
2020-02-12 23:58 ` Applied "dt-bindings: spi: Document binding for generic SPI multiplexer" to the spi tree Mark Brown
2020-02-04 3:28 ` [PATCH v5 2/2] spi: Add generic SPI multiplexer Chris Packham
2020-02-04 11:10 ` Andy Shevchenko
2020-02-12 23:58 ` Applied "spi: Add generic SPI multiplexer" to the spi tree Mark Brown
2020-11-13 15:46 ` [PATCH v5 2/2] spi: Add generic SPI multiplexer Nicolas Saenz Julienne
2020-11-17 0:08 ` Chris Packham
2020-11-20 16:18 ` Nicolas Saenz Julienne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b7f555bee663a033e2e8fc50f019c9b580a7c66.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).