From: Georgi Djakov <georgi.djakov@linaro.org>
To: Saravana Kannan <saravanak@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: vincent.guittot@linaro.org, seansw@qti.qualcomm.com,
daidavid1@codeaurora.org, Rajendra Nayak <rnayak@codeaurora.org>,
sibis@codeaurora.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, kernel-team@android.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: opp: Introduce opp-peak-KBps and opp-avg-KBps bindings
Date: Fri, 26 Jul 2019 19:24:50 +0300 [thread overview]
Message-ID: <2befbd75-e0f4-dbcc-e9b1-9a9f99c084d3@linaro.org> (raw)
In-Reply-To: <20190703011020.151615-2-saravanak@google.com>
Hi Saravana,
On 7/3/19 04:10, Saravana Kannan wrote:
> Interconnects often quantify their performance points in terms of
> bandwidth. So, add opp-peak-KBps (required) and opp-avg-KBps (optional) to
> allow specifying Bandwidth OPP tables in DT.
>
> opp-peak-KBps is a required property that replace opp-hz for Bandwidth OPP
> tables.
>
> opp-avg-KBps is an optional property that can be used in Bandwidth OPP
> tables.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> Documentation/devicetree/bindings/opp/opp.txt | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> index 76b6c79604a5..c869e87caa2a 100644
> --- a/Documentation/devicetree/bindings/opp/opp.txt
> +++ b/Documentation/devicetree/bindings/opp/opp.txt
> @@ -83,9 +83,14 @@ properties.
>
> Required properties:
> - opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a
> - required property for all device nodes but devices like power domains. The
> - power domain nodes must have another (implementation dependent) property which
> - uniquely identifies the OPP nodes.
> + required property for all device nodes but for devices like power domains or
> + bandwidth opp tables. The power domain nodes must have another (implementation
> + dependent) property which uniquely identifies the OPP nodes. The interconnect
> + opps are required to have the opp-peak-bw property.
> +
> +- opp-peak-KBps: Peak bandwidth in kilobytes per second, expressed as a 32-bit
As Rob already mentioned, KBps should be documented. See [1].
Thanks,
Georgi
[1] https://lore.kernel.org/lkml/20190423132823.7915-2-georgi.djakov@linaro.org/
next prev parent reply other threads:[~2019-07-26 16:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 1:10 [PATCH v3 0/6] Introduce Bandwidth OPPs for interconnect paths Saravana Kannan
2019-07-03 1:10 ` [PATCH v3 1/6] dt-bindings: opp: Introduce opp-peak-KBps and opp-avg-KBps bindings Saravana Kannan
2019-07-16 17:25 ` Sibi Sankar
2019-07-16 18:58 ` Saravana Kannan
2019-07-22 23:35 ` Rob Herring
2019-07-22 23:40 ` Saravana Kannan
2019-07-23 14:26 ` Rob Herring
2019-07-24 0:18 ` Saravana Kannan
2019-07-17 7:54 ` Viresh Kumar
2019-07-17 20:29 ` Saravana Kannan
2019-07-18 4:35 ` Viresh Kumar
2019-07-18 17:26 ` Saravana Kannan
2019-07-26 16:24 ` Georgi Djakov [this message]
2019-07-26 19:08 ` Saravana Kannan
2019-07-03 1:10 ` [PATCH v3 2/6] OPP: Add support for bandwidth OPP tables Saravana Kannan
2019-07-16 17:33 ` Sibi Sankar
2019-07-16 19:10 ` Saravana Kannan
2019-07-30 10:57 ` Amit Kucheria
2019-07-30 23:20 ` Saravana Kannan
2019-07-03 1:10 ` [PATCH v3 3/6] OPP: Add helper function " Saravana Kannan
2019-07-03 1:10 ` [PATCH v3 4/6] OPP: Add API to find an OPP table from its DT node Saravana Kannan
2019-07-03 1:10 ` [PATCH v3 5/6] dt-bindings: interconnect: Add interconnect-opp-table property Saravana Kannan
2019-07-22 23:39 ` Rob Herring
2019-07-22 23:43 ` Saravana Kannan
2019-07-23 2:21 ` Viresh Kumar
2019-07-03 1:10 ` [PATCH v3 6/6] interconnect: Add OPP table support for interconnects Saravana Kannan
2019-07-03 6:45 ` Vincent Guittot
2019-07-03 21:33 ` Saravana Kannan
2019-07-04 7:12 ` Vincent Guittot
2019-07-07 21:48 ` Saravana Kannan
2019-07-09 7:25 ` Vincent Guittot
2019-07-09 19:02 ` Saravana Kannan
2019-07-15 8:16 ` Vincent Guittot
2019-07-16 0:55 ` Saravana Kannan
2019-07-24 7:16 ` Vincent Guittot
2019-07-26 16:25 ` Georgi Djakov
2019-07-26 19:08 ` Saravana Kannan
2019-07-03 6:36 ` [PATCH v3 0/6] Introduce Bandwidth OPPs for interconnect paths Viresh Kumar
2019-07-03 20:35 ` Saravana Kannan
2019-07-17 10:32 ` Viresh Kumar
2019-07-17 20:34 ` Saravana Kannan
2019-07-18 5:37 ` Viresh Kumar
2019-07-19 4:12 ` Saravana Kannan
2019-07-29 9:24 ` Viresh Kumar
2019-07-29 20:12 ` Saravana Kannan
2019-07-30 3:01 ` Viresh Kumar
2019-08-03 1:20 ` Saravana Kannan
2019-08-03 7:36 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2befbd75-e0f4-dbcc-e9b1-9a9f99c084d3@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=seansw@qti.qualcomm.com \
--cc=sibis@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).