From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v5 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY Date: Tue, 14 Jun 2016 15:28:52 +0200 Message-ID: <3008400.RaKLTh6Yt6@diego> References: <1465783810-18756-1-git-send-email-frank.wang@rock-chips.com> <1465783810-18756-2-git-send-email-frank.wang@rock-chips.com> <22577234.U1lnbZuDkj@diego> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <22577234.U1lnbZuDkj@diego> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Frank Wang Cc: dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, kishon-l0cyMroinI0@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xzy.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: devicetree@vger.kernel.org Am Montag, 13. Juni 2016, 10:38:39 schrieb Heiko St=FCbner: > Am Montag, 13. Juni 2016, 10:10:09 schrieb Frank Wang: > > Signed-off-by: Frank Wang >=20 > looks really cool now, thanks for addressing all the review comments >=20 > Reviewed-by: Heiko Stuebner You've only added the very common "reg" property, so I guess it should = be just=20 fine to keep Rob's Ack on the binding in that case. I noticed one thing below though. As you'll probably need to do another version (see comments to patch2),= you=20 could change that as well in both here and in the second patch - see be= low: > > --- > >=20 > > Changes in v5: > > - Added 'reg' property to identify the different phy-blocks. > >=20 > > Changes in v4: > > - Used 'phy-supply' instead of 'vbus_*-supply'. > >=20 > > Changes in v3: > > - Added 'clocks' and 'clock-names' optional properties. > > - Specified 'otg-port' and 'host-port' as the sub-node name. > >=20 > > Changes in v2: > > - Changed vbus_host optional property from gpio to regulator. > > - Specified vbus_otg-supply optional property. > > - Specified otg_id and otg_bvalid property. > > =20 > > .../bindings/phy/phy-rockchip-inno-usb2.txt | 64 > >=20 > > ++++++++++++++++++++ 1 file changed, 64 insertions(+) > >=20 > > create mode 100644 > >=20 > > Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > >=20 > > diff --git > > a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt = new > > file > > mode 100644 > > index 0000000..48bb5de > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.= txt > > @@ -0,0 +1,64 @@ > > +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK > > + > > +Required properties (phy (parent) node): > > + - compatible : should be one of the listed compatibles: > > + * "rockchip,rk3366-usb2phy" > > + * "rockchip,rk3399-usb2phy" > > + - reg : the address offset of grf for usb-phy configuration. > > + - #clock-cells : should be 0. > > + - clock-output-names : specify the 480m output clock name. > > + > > +Optional properties: > > + - clocks : phandle + phy specifier pair, for the input clock of p= hy. > > + - clock-names : input clock name of phy, must be "phyclk". > > + > > +Required nodes : a sub-node is required for each port the phy prov= ides. > > + The sub-node name is used to identify host or otg port, > > + and shall be the following entries: > > + * "otg-port" : the name of otg port. > > + * "host-port" : the name of host port. > > + > > +Required properties (port (child) node): > > + - #phy-cells : must be 0. See ./phy-bindings.txt for details. > > + - interrupts : specify an interrupt for each entry in interrupt-n= ames. > > + - interrupt-names : a list which shall be the following entries: > > + * "otg_id" : for the otg id interrupt. > > + * "otg_bvalid" : for the otg vbus interrupt. please use "-" not underscores in dt-bindings, so "otg-id", "otg-bvalid= ". > > + * "linestate" : for the host/otg linestate interrupt. > > + > > +Optional properties: > > + - phy-supply : phandle to a regulator that provides power to VBUS= =2E > > + See ./phy-bindings.txt for details. > > + > > +Example: > > + > > +grf: syscon@ff770000 { > > + compatible =3D "rockchip,rk3366-grf", "syscon", "simple-mfd"; > > + #address-cells =3D <1>; > > + #size-cells =3D <1>; > > + > > +... > > + > > + u2phy: usb2-phy@700 { > > + compatible =3D "rockchip,rk3366-usb2phy"; > > + reg =3D <0x700 0x2c>; > > + #clock-cells =3D <0>; > > + clock-output-names =3D "sclk_otgphy0_480m"; > > + > > + u2phy_otg: otg-port { > > + #phy-cells =3D <0>; > > + interrupts =3D , > > + , > > + ; > > + interrupt-names =3D "otg_id", "otg_bvalid", "linestate"; again "-" not "_". > > + status =3D "okay"; > > + }; > > + > > + u2phy_host: host-port { > > + #phy-cells =3D <0>; > > + interrupts =3D ; > > + interrupt-names =3D "linestate"; > > + status =3D "okay"; > > + }; > > + }; > > +}; -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html