From: "Heiko Stübner" <heiko@sntech.de>
To: Jonathan Cameron <jic23@kernel.org>, Simon Xue <xxm@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, Johan Jonker <jbx6244@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH v1 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc
Date: Sun, 11 Jul 2021 15:38:44 +0200 [thread overview]
Message-ID: <3140115.MfA8il8Al2@diego> (raw)
In-Reply-To: <20210705012552.3781-1-xxm@rock-chips.com>
Am Montag, 5. Juli 2021, 03:25:52 CEST schrieb Simon Xue:
> It is similar to other devices, but with 8 channels.
>
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/iio/adc/rockchip_saradc.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 12584f1631d8..f3eb8d2e50dc 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -35,7 +35,7 @@
> #define SARADC_DLY_PU_SOC_MASK 0x3f
>
> #define SARADC_TIMEOUT msecs_to_jiffies(100)
> -#define SARADC_MAX_CHANNELS 6
> +#define SARADC_MAX_CHANNELS 8
>
> struct rockchip_saradc_data {
> const struct iio_chan_spec *channels;
> @@ -192,6 +192,23 @@ static const struct rockchip_saradc_data rk3399_saradc_data = {
> .clk_rate = 1000000,
> };
>
> +static const struct iio_chan_spec rockchip_rk3568_saradc_iio_channels[] = {
> + SARADC_CHANNEL(0, "adc0", 10),
> + SARADC_CHANNEL(1, "adc1", 10),
> + SARADC_CHANNEL(2, "adc2", 10),
> + SARADC_CHANNEL(3, "adc3", 10),
> + SARADC_CHANNEL(4, "adc4", 10),
> + SARADC_CHANNEL(5, "adc5", 10),
> + SARADC_CHANNEL(6, "adc6", 10),
> + SARADC_CHANNEL(7, "adc7", 10),
> +};
> +
> +static const struct rockchip_saradc_data rk3568_saradc_data = {
> + .channels = rockchip_rk3568_saradc_iio_channels,
> + .num_channels = ARRAY_SIZE(rockchip_rk3568_saradc_iio_channels),
> + .clk_rate = 1000000,
> +};
> +
> static const struct of_device_id rockchip_saradc_match[] = {
> {
> .compatible = "rockchip,saradc",
> @@ -202,6 +219,9 @@ static const struct of_device_id rockchip_saradc_match[] = {
> }, {
> .compatible = "rockchip,rk3399-saradc",
> .data = &rk3399_saradc_data,
> + }, {
> + .compatible = "rockchip,rk3568-saradc",
> + .data = &rk3568_saradc_data,
> },
> {},
> };
>
next prev parent reply other threads:[~2021-07-11 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 1:25 [PATCH v1 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
2021-07-05 1:25 ` [PATCH v1 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
2021-07-11 13:38 ` Heiko Stübner [this message]
2021-07-11 13:36 ` [PATCH v1 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3140115.MfA8il8Al2@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).