From: "Rafał Miłecki" <rafal@milecki.pl>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] dt-bindings: spi: brcm,spi-bcm-qspi: convert to the json-schema
Date: Fri, 16 Apr 2021 08:21:23 +0200 [thread overview]
Message-ID: <31b1f1659e2c356923cef9519a9116f4@milecki.pl> (raw)
In-Reply-To: <6e5a2693-fc19-efce-5aaa-4712b0dcb802@gmail.com>
On 2021-04-16 02:32, Florian Fainelli wrote:
> On 4/15/2021 3:02 PM, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This helps validating DTS files.
>>
>> Changes that require mentioning:
>> 1. reg-names
>> "mspi_regs" and "bspi_regs" were renamed to "mspi" and "bspi" as
>> that
>> is what's used in DTS files and in Linux driver
>> 2. interrupt-names
>> Names were reordered. "mspi_done" has to go first as it's always
>> required.
>> 3. spi-rx-bus-width
>> Property description was dropped as it's part of the
>> spi-controller.yaml
>> 4. Examples:
>> * flash0@0 was a duplicated node and got dropped
>> * regs and interrupts were formatted and reordered to match yaml
>> * <0x1c> was replaced with <&gic>
>>
>> This rewritten binding validates cleanly using the
>> "dt_binding_check".
>> Some Linux stored DTS files will require reordering regs and
>> interrupts
>> to make dtbs_check happy.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Thanks a lot for doing that, do you mind adding Kamal as a maintainer
> for that binding if you have to send a v2?
I wasn't sure if I can just add someone else like that. He's already
maintainer according to the MAINTAINERS though, so I guess I'm safe to
do that. Sending V2.
next prev parent reply other threads:[~2021-04-16 6:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 22:02 [PATCH] dt-bindings: spi: brcm,spi-bcm-qspi: convert to the json-schema Rafał Miłecki
2021-04-16 0:32 ` Florian Fainelli
2021-04-16 6:21 ` Rafał Miłecki [this message]
2021-04-16 6:23 ` [PATCH V2] " Rafał Miłecki
2021-04-16 19:27 ` Rob Herring
2021-04-16 19:47 ` [PATCH V3] " Rafał Miłecki
2021-04-20 16:21 ` Rob Herring
2021-04-20 18:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31b1f1659e2c356923cef9519a9116f4@milecki.pl \
--to=rafal@milecki.pl \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).