* [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support
@ 2012-09-17 7:23 AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 1/4] lis3: lis3lv02d: remove lis3lv02d driver DT init AnilKumar Ch
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: AnilKumar Ch @ 2012-09-17 7:23 UTC (permalink / raw)
To: arnd
Cc: gregkh, eric.piel, jic23, greg, akpm, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely, AnilKumar Ch
Adds device tree support to lis3lv02d_i2c driver. Along with this
DT init is moved from core driver to individual drivers, with the
current implementation some pdata is missing in lis3lv02d_i2c driver.
Also adds platform data for lis331dlh driver to am335x-EVM. These
patches were tested on AM335x-EVM.
Changes from v2:
- Added documentation details specific to lis3lv02d_i2c
driver with example node
- Modified DTS node representation in .dts file
- Removed "-i2c" string from compatible name
Changes from v1:
- Moved lis3lv02d_init_dt to individual drivers with
some code clean-up.
- Added lis331dlh compatible entry for lis331dlh parts
AnilKumar Ch (4):
lis3: lis3lv02d: remove lis3lv02d driver DT init
lis3: lis3lv02d_spi: Add lis3lv02d device tree init
lis3: lis3lv02d_i2c: Add lis3lv02d device tree init
ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm
Documentation/devicetree/bindings/misc/lis302.txt | 36 +++++++++++++++++++
arch/arm/boot/dts/am335x-evm.dts | 39 +++++++++++++++++++++
drivers/misc/lis3lv02d/lis3lv02d.c | 8 ++---
drivers/misc/lis3lv02d/lis3lv02d.h | 1 +
drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 18 ++++++++++
drivers/misc/lis3lv02d/lis3lv02d_spi.c | 8 +++--
6 files changed, 101 insertions(+), 9 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3 1/4] lis3: lis3lv02d: remove lis3lv02d driver DT init
2012-09-17 7:23 [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
@ 2012-09-17 7:23 ` AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 2/4] lis3: lis3lv02d_spi: Add lis3lv02d device tree init AnilKumar Ch
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: AnilKumar Ch @ 2012-09-17 7:23 UTC (permalink / raw)
To: arnd
Cc: gregkh, eric.piel, jic23, greg, akpm, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely, AnilKumar Ch
Remove lis3lv02d driver device tree initialization from core driver
and move it to individual drivers. With the current implementation
some pdata parameters are missing if we use lis3lv02d_init_device()
in lis3lv02d_i2c driver.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
drivers/misc/lis3lv02d/lis3lv02d.c | 8 ++------
drivers/misc/lis3lv02d/lis3lv02d.h | 1 +
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c
index 79349ec..026021e 100644
--- a/drivers/misc/lis3lv02d/lis3lv02d.c
+++ b/drivers/misc/lis3lv02d/lis3lv02d.c
@@ -944,7 +944,7 @@ static void lis3lv02d_8b_configure(struct lis3lv02d *lis3,
}
#ifdef CONFIG_OF
-static int lis3lv02d_init_dt(struct lis3lv02d *lis3)
+int lis3lv02d_init_dt(struct lis3lv02d *lis3)
{
struct lis3lv02d_platform_data *pdata;
struct device_node *np = lis3->of_node;
@@ -1084,7 +1084,7 @@ static int lis3lv02d_init_dt(struct lis3lv02d *lis3)
}
#else
-static int lis3lv02d_init_dt(struct lis3lv02d *lis3)
+int lis3lv02d_init_dt(struct lis3lv02d *lis3)
{
return 0;
}
@@ -1100,10 +1100,6 @@ int lis3lv02d_init_device(struct lis3lv02d *lis3)
irq_handler_t thread_fn;
int irq_flags = 0;
- err = lis3lv02d_init_dt(lis3);
- if (err < 0)
- return err;
-
lis3->whoami = lis3lv02d_read_8(lis3, WHO_AM_I);
switch (lis3->whoami) {
diff --git a/drivers/misc/lis3lv02d/lis3lv02d.h b/drivers/misc/lis3lv02d/lis3lv02d.h
index 4cf0779..b5505fa 100644
--- a/drivers/misc/lis3lv02d/lis3lv02d.h
+++ b/drivers/misc/lis3lv02d/lis3lv02d.h
@@ -326,5 +326,6 @@ void lis3lv02d_joystick_disable(struct lis3lv02d *lis3);
void lis3lv02d_poweroff(struct lis3lv02d *lis3);
int lis3lv02d_poweron(struct lis3lv02d *lis3);
int lis3lv02d_remove_fs(struct lis3lv02d *lis3);
+int lis3lv02d_init_dt(struct lis3lv02d *lis3);
extern struct lis3lv02d lis3_dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 2/4] lis3: lis3lv02d_spi: Add lis3lv02d device tree init
2012-09-17 7:23 [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 1/4] lis3: lis3lv02d: remove lis3lv02d driver DT init AnilKumar Ch
@ 2012-09-17 7:23 ` AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 3/4] lis3: lis3lv02d_i2c: " AnilKumar Ch
` (3 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: AnilKumar Ch @ 2012-09-17 7:23 UTC (permalink / raw)
To: arnd
Cc: gregkh, eric.piel, jic23, greg, akpm, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely, AnilKumar Ch
Add lis3lv02d device tree initialization code/API to take pdata
from device node. Also remove CONFIG_OF ifdef from the driver,
if CONFIG_OF is not defined then OF APIs returns 0.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
drivers/misc/lis3lv02d/lis3lv02d_spi.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/lis3lv02d/lis3lv02d_spi.c b/drivers/misc/lis3lv02d/lis3lv02d_spi.c
index 23f3986..e1db6f4 100644
--- a/drivers/misc/lis3lv02d/lis3lv02d_spi.c
+++ b/drivers/misc/lis3lv02d/lis3lv02d_spi.c
@@ -84,10 +84,12 @@ static int __devinit lis302dl_spi_probe(struct spi_device *spi)
lis3_dev.ac = lis3lv02d_axis_normal;
lis3_dev.pdata = spi->dev.platform_data;
-#ifdef CONFIG_OF
- if (of_match_device(lis302dl_spi_dt_ids, &spi->dev))
+ if (of_match_device(lis302dl_spi_dt_ids, &spi->dev)) {
lis3_dev.of_node = spi->dev.of_node;
-#endif
+ ret = lis3lv02d_init_dt(&lis3_dev);
+ if (ret)
+ return ret;
+ }
spi_set_drvdata(spi, &lis3_dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 3/4] lis3: lis3lv02d_i2c: Add lis3lv02d device tree init
2012-09-17 7:23 [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 1/4] lis3: lis3lv02d: remove lis3lv02d driver DT init AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 2/4] lis3: lis3lv02d_spi: Add lis3lv02d device tree init AnilKumar Ch
@ 2012-09-17 7:23 ` AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm AnilKumar Ch
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: AnilKumar Ch @ 2012-09-17 7:23 UTC (permalink / raw)
To: arnd
Cc: gregkh, eric.piel, jic23, greg, akpm, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely, AnilKumar Ch
Add lis3lv02d device tree initialization code/API to take pdata
from device node. Also adds device tree init matching table
support to lis3lv02d_i2c driver. If the driver data is passed
from device tree, then this driver picks up platform data
from device node through common/generic lis3lv02d.c driver.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
Documentation/devicetree/bindings/misc/lis302.txt | 36 +++++++++++++++++++++
drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 18 +++++++++++
2 files changed, 54 insertions(+)
diff --git a/Documentation/devicetree/bindings/misc/lis302.txt b/Documentation/devicetree/bindings/misc/lis302.txt
index e18af9d..6def86f 100644
--- a/Documentation/devicetree/bindings/misc/lis302.txt
+++ b/Documentation/devicetree/bindings/misc/lis302.txt
@@ -11,6 +11,12 @@ Required properties for the SPI bindings:
constrained by external circuitry
- interrupts: the interrupt generated by the device
+Required properties for the I2C bindings:
+ - compatible: should be set to "st,lis3lv02d"
+ - reg: i2c slave address
+ - Vdd-supply: The input supply for Vdd
+ - Vdd_IO-supply: The input supply for Vdd_IO
+
Optional properties for all bus drivers:
@@ -74,3 +80,33 @@ Example for a SPI device node:
st,wakeup-z-hi;
};
+Example for a I2C device node:
+
+ lis331dlh: lis331dlh@18 {
+ compatible = "st,lis331dlh", "st,lis3lv02d";
+ reg = <0x18>;
+ Vdd-supply = <&lis3_reg>;
+ Vdd_IO-supply = <&lis3_reg>;
+
+ st,click-single-x;
+ st,click-single-y;
+ st,click-single-z;
+ st,click-thresh-x = <10>;
+ st,click-thresh-y = <10>;
+ st,click-thresh-z = <10>;
+ st,irq1-click;
+ st,irq2-click;
+ st,wakeup-x-lo;
+ st,wakeup-x-hi;
+ st,wakeup-y-lo;
+ st,wakeup-y-hi;
+ st,wakeup-z-lo;
+ st,wakeup-z-hi;
+ st,min-limit-x = <120>;
+ st,min-limit-y = <120>;
+ st,min-limit-z = <140>;
+ st,max-limit-x = <550>;
+ st,max-limit-y = <550>;
+ st,max-limit-z = <750>;
+ };
+
diff --git a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
index 15255eb..43e3f29 100644
--- a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
+++ b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
@@ -31,6 +31,9 @@
#include <linux/i2c.h>
#include <linux/pm_runtime.h>
#include <linux/delay.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+
#include "lis3lv02d.h"
#define DRV_NAME "lis3lv02d_i2c"
@@ -102,12 +105,26 @@ static int lis3_i2c_init(struct lis3lv02d *lis3)
static union axis_conversion lis3lv02d_axis_map =
{ .as_array = { LIS3_DEV_X, LIS3_DEV_Y, LIS3_DEV_Z } };
+static struct of_device_id lis3lv02d_i2c_dt_ids[] = {
+ { .compatible = "st,lis3lv02d" },
+ {}
+};
+MODULE_DEVICE_TABLE(of, lis3lv02d_i2c_dt_ids);
+
static int __devinit lis3lv02d_i2c_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
int ret = 0;
struct lis3lv02d_platform_data *pdata = client->dev.platform_data;
+ if (of_match_device(lis3lv02d_i2c_dt_ids, &client->dev)) {
+ lis3_dev.of_node = client->dev.of_node;
+ ret = lis3lv02d_init_dt(&lis3_dev);
+ if (ret)
+ return ret;
+ pdata = lis3_dev.pdata;
+ }
+
if (pdata) {
if ((pdata->driver_features & LIS3_USE_BLOCK_READ) &&
(i2c_check_functionality(client->adapter,
@@ -255,6 +272,7 @@ static struct i2c_driver lis3lv02d_i2c_driver = {
.name = DRV_NAME,
.owner = THIS_MODULE,
.pm = &lis3_pm_ops,
+ .of_match_table = of_match_ptr(lis3lv02d_i2c_dt_ids),
},
.probe = lis3lv02d_i2c_probe,
.remove = __devexit_p(lis3lv02d_i2c_remove),
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm
2012-09-17 7:23 [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
` (2 preceding siblings ...)
2012-09-17 7:23 ` [PATCH v3 3/4] lis3: lis3lv02d_i2c: " AnilKumar Ch
@ 2012-09-17 7:23 ` AnilKumar Ch
2012-09-17 22:35 ` Andrew Morton
2012-09-17 11:51 ` [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support Arnd Bergmann
2012-09-26 20:24 ` Greg KH
5 siblings, 1 reply; 13+ messages in thread
From: AnilKumar Ch @ 2012-09-17 7:23 UTC (permalink / raw)
To: arnd
Cc: gregkh, eric.piel, jic23, greg, akpm, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely, AnilKumar Ch
Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM
lis331dlh accelerometer is connected to I2C2 bus. So this patch
change the status of I2C2 node to "okay" to use I2C2 bus. Also
added all the required platform data to am335x-evm.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
arch/arm/boot/dts/am335x-evm.dts | 39 ++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 9fb59c5..be309df 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -47,6 +47,39 @@
};
};
+ i2c2: i2c@4802a000 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ lis331dlh: lis331dlh@18 {
+ compatible = "st,lis331dlh", "st,lis3lv02d";
+ reg = <0x18>;
+ Vdd-supply = <&lis3_reg>;
+ Vdd_IO-supply = <&lis3_reg>;
+
+ st,click-single-x;
+ st,click-single-y;
+ st,click-single-z;
+ st,click-thresh-x = <10>;
+ st,click-thresh-y = <10>;
+ st,click-thresh-z = <10>;
+ st,irq1-click;
+ st,irq2-click;
+ st,wakeup-x-lo;
+ st,wakeup-x-hi;
+ st,wakeup-y-lo;
+ st,wakeup-y-hi;
+ st,wakeup-z-lo;
+ st,wakeup-z-hi;
+ st,min-limit-x = <120>;
+ st,min-limit-y = <120>;
+ st,min-limit-z = <140>;
+ st,max-limit-x = <550>;
+ st,max-limit-y = <550>;
+ st,max-limit-z = <750>;
+ };
+ };
+
dcan1: d_can@481d0000 {
status = "okay";
pinctrl-names = "default";
@@ -61,6 +94,12 @@
regulator-max-microvolt = <5000000>;
regulator-boot-on;
};
+
+ lis3_reg: fixedregulator@1 {
+ compatible = "regulator-fixed";
+ regulator-name = "lis3_reg";
+ regulator-boot-on;
+ };
};
/include/ "tps65910.dtsi"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support
2012-09-17 7:23 [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
` (3 preceding siblings ...)
2012-09-17 7:23 ` [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm AnilKumar Ch
@ 2012-09-17 11:51 ` Arnd Bergmann
2012-09-26 20:24 ` Greg KH
5 siblings, 0 replies; 13+ messages in thread
From: Arnd Bergmann @ 2012-09-17 11:51 UTC (permalink / raw)
To: AnilKumar Ch
Cc: gregkh, eric.piel, jic23, greg, akpm, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely
On Monday 17 September 2012, AnilKumar Ch wrote:
> Adds device tree support to lis3lv02d_i2c driver. Along with this
> DT init is moved from core driver to individual drivers, with the
> current implementation some pdata is missing in lis3lv02d_i2c driver.
>
> Also adds platform data for lis331dlh driver to am335x-EVM. These
> patches were tested on AM335x-EVM.
Looks good to me.
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm
2012-09-17 7:23 ` [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm AnilKumar Ch
@ 2012-09-17 22:35 ` Andrew Morton
[not found] ` <20120917153559.e07ca263.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
0 siblings, 1 reply; 13+ messages in thread
From: Andrew Morton @ 2012-09-17 22:35 UTC (permalink / raw)
To: AnilKumar Ch
Cc: arnd, gregkh, eric.piel, jic23, greg, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely
On Mon, 17 Sep 2012 12:53:22 +0530
AnilKumar Ch <anilkumar@ti.com> wrote:
> Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM
> lis331dlh accelerometer is connected to I2C2 bus. So this patch
> change the status of I2C2 node to "okay" to use I2C2 bus. Also
> added all the required platform data to am335x-evm.
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
> arch/arm/boot/dts/am335x-evm.dts | 39 ++++++++++++++++++++++++++++++++++++++
Your arch/arm/boot/dts/am335x-evm.dts differs significantly from the
one in linux-next (it should not do so), so I didn't do anything with
this patch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm
[not found] ` <20120917153559.e07ca263.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
@ 2012-09-18 7:35 ` AnilKumar, Chimata
0 siblings, 0 replies; 13+ messages in thread
From: AnilKumar, Chimata @ 2012-09-18 7:35 UTC (permalink / raw)
To: Andrew Morton
Cc: dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w,
eric.piel-VkQ1JFuSMpfAbQlEx87xDw,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E,
jic23-KWPb1pKIrIJaa/9Udqfwiw, greg-U8xfFu+wG4EAvxtiuMwx3w,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Andrew,
On Tue, Sep 18, 2012 at 04:05:59, Andrew Morton wrote:
> On Mon, 17 Sep 2012 12:53:22 +0530
> AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org> wrote:
>
> > Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM
> > lis331dlh accelerometer is connected to I2C2 bus. So this patch
> > change the status of I2C2 node to "okay" to use I2C2 bus. Also
> > added all the required platform data to am335x-evm.
> >
> > Signed-off-by: AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org>
> > ---
> > arch/arm/boot/dts/am335x-evm.dts | 39 ++++++++++++++++++++++++++++++++++++++
>
> Your arch/arm/boot/dts/am335x-evm.dts differs significantly from the
> one in linux-next (it should not do so), so I didn't do anything with
> this patch.
>
Thanks for pushing remaining patches.
ACK from the reviewers(Arnd) will help to include in linux-omap branch.
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support
2012-09-17 7:23 [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
` (4 preceding siblings ...)
2012-09-17 11:51 ` [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support Arnd Bergmann
@ 2012-09-26 20:24 ` Greg KH
2012-09-26 20:34 ` Andrew Morton
5 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2012-09-26 20:24 UTC (permalink / raw)
To: AnilKumar Ch
Cc: arnd, eric.piel, jic23, akpm, broonie, dmitry.torokhov, tony,
linux-omap, linux-arm-kernel, devicetree-discuss, grant.likely
On Mon, Sep 17, 2012 at 12:53:18PM +0530, AnilKumar Ch wrote:
> Adds device tree support to lis3lv02d_i2c driver. Along with this
> DT init is moved from core driver to individual drivers, with the
> current implementation some pdata is missing in lis3lv02d_i2c driver.
>
> Also adds platform data for lis331dlh driver to am335x-EVM. These
> patches were tested on AM335x-EVM.
None of these patches apply to any tree that I know of, what did you do
them against? Please redo them against the char-next branch of
linux-next and resend them if you wish to see them applied.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support
2012-09-26 20:24 ` Greg KH
@ 2012-09-26 20:34 ` Andrew Morton
2012-09-26 20:44 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Andrew Morton @ 2012-09-26 20:34 UTC (permalink / raw)
To: Greg KH
Cc: AnilKumar Ch, arnd, eric.piel, jic23, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely
On Wed, 26 Sep 2012 13:24:00 -0700
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Sep 17, 2012 at 12:53:18PM +0530, AnilKumar Ch wrote:
> > Adds device tree support to lis3lv02d_i2c driver. Along with this
> > DT init is moved from core driver to individual drivers, with the
> > current implementation some pdata is missing in lis3lv02d_i2c driver.
> >
> > Also adds platform data for lis331dlh driver to am335x-EVM. These
> > patches were tested on AM335x-EVM.
>
> None of these patches apply to any tree that I know of, what did you do
> them against? Please redo them against the char-next branch of
> linux-next and resend them if you wish to see them applied.
Presumably they're against eariler patches whcih you don't have. I'm
presently sitting on
drivers-misc-lis3lv02d-add-generic-dt-matching-code.patch
drivers-misc-lis3lv02d-add-generic-dt-matching-code-fix.patch
drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code.patch
drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix.patch
drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix-fix.patch
drivers-misc-lis3lv02d-remove-lis3lv02d-driver-dt-init.patch
drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init.patch
drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init-fix.patch
drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init.patch
drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init-fix.patch
drivers-misc-lis3lv02d-fix-some-comments-specific-to-lis331dlh-driver.patch
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support
2012-09-26 20:34 ` Andrew Morton
@ 2012-09-26 20:44 ` Greg KH
2012-09-26 20:54 ` Andrew Morton
0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2012-09-26 20:44 UTC (permalink / raw)
To: Andrew Morton
Cc: AnilKumar Ch, arnd, eric.piel, jic23, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely
On Wed, Sep 26, 2012 at 01:34:50PM -0700, Andrew Morton wrote:
> On Wed, 26 Sep 2012 13:24:00 -0700
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Mon, Sep 17, 2012 at 12:53:18PM +0530, AnilKumar Ch wrote:
> > > Adds device tree support to lis3lv02d_i2c driver. Along with this
> > > DT init is moved from core driver to individual drivers, with the
> > > current implementation some pdata is missing in lis3lv02d_i2c driver.
> > >
> > > Also adds platform data for lis331dlh driver to am335x-EVM. These
> > > patches were tested on AM335x-EVM.
> >
> > None of these patches apply to any tree that I know of, what did you do
> > them against? Please redo them against the char-next branch of
> > linux-next and resend them if you wish to see them applied.
>
> Presumably they're against eariler patches whcih you don't have. I'm
> presently sitting on
>
> drivers-misc-lis3lv02d-add-generic-dt-matching-code.patch
> drivers-misc-lis3lv02d-add-generic-dt-matching-code-fix.patch
> drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code.patch
> drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix.patch
> drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix-fix.patch
> drivers-misc-lis3lv02d-remove-lis3lv02d-driver-dt-init.patch
> drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init.patch
> drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init-fix.patch
> drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init.patch
> drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init-fix.patch
> drivers-misc-lis3lv02d-fix-some-comments-specific-to-lis331dlh-driver.patch
Care to send them to me so that I can get them to Linus for the 3.7
merge window? I do keep the char-misc tree for these types of things :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support
2012-09-26 20:44 ` Greg KH
@ 2012-09-26 20:54 ` Andrew Morton
2012-09-26 20:57 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Andrew Morton @ 2012-09-26 20:54 UTC (permalink / raw)
To: Greg KH
Cc: AnilKumar Ch, arnd, eric.piel, jic23, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely
On Wed, 26 Sep 2012 13:44:03 -0700
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Sep 26, 2012 at 01:34:50PM -0700, Andrew Morton wrote:
> > On Wed, 26 Sep 2012 13:24:00 -0700
> > Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > > On Mon, Sep 17, 2012 at 12:53:18PM +0530, AnilKumar Ch wrote:
> > > > Adds device tree support to lis3lv02d_i2c driver. Along with this
> > > > DT init is moved from core driver to individual drivers, with the
> > > > current implementation some pdata is missing in lis3lv02d_i2c driver.
> > > >
> > > > Also adds platform data for lis331dlh driver to am335x-EVM. These
> > > > patches were tested on AM335x-EVM.
> > >
> > > None of these patches apply to any tree that I know of, what did you do
> > > them against? Please redo them against the char-next branch of
> > > linux-next and resend them if you wish to see them applied.
> >
> > Presumably they're against eariler patches whcih you don't have. I'm
> > presently sitting on
> >
> > drivers-misc-lis3lv02d-add-generic-dt-matching-code.patch
> > drivers-misc-lis3lv02d-add-generic-dt-matching-code-fix.patch
> > drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code.patch
> > drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix.patch
> > drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix-fix.patch
> > drivers-misc-lis3lv02d-remove-lis3lv02d-driver-dt-init.patch
> > drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init.patch
> > drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init-fix.patch
> > drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init.patch
> > drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init-fix.patch
> > drivers-misc-lis3lv02d-fix-some-comments-specific-to-lis331dlh-driver.patch
>
> Care to send them to me so that I can get them to Linus for the 3.7
> merge window?
OK.
> I do keep the char-misc tree for these types of things :)
I've actually been doing this miscdev driver since day one. I'm happy
to hand over the keys but please review the patches carefully and try not to
miss stuff!
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support
2012-09-26 20:54 ` Andrew Morton
@ 2012-09-26 20:57 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2012-09-26 20:57 UTC (permalink / raw)
To: Andrew Morton
Cc: AnilKumar Ch, arnd, eric.piel, jic23, broonie, dmitry.torokhov,
tony, linux-omap, linux-arm-kernel, devicetree-discuss,
grant.likely
On Wed, Sep 26, 2012 at 01:54:12PM -0700, Andrew Morton wrote:
> On Wed, 26 Sep 2012 13:44:03 -0700
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Wed, Sep 26, 2012 at 01:34:50PM -0700, Andrew Morton wrote:
> > > On Wed, 26 Sep 2012 13:24:00 -0700
> > > Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > > On Mon, Sep 17, 2012 at 12:53:18PM +0530, AnilKumar Ch wrote:
> > > > > Adds device tree support to lis3lv02d_i2c driver. Along with this
> > > > > DT init is moved from core driver to individual drivers, with the
> > > > > current implementation some pdata is missing in lis3lv02d_i2c driver.
> > > > >
> > > > > Also adds platform data for lis331dlh driver to am335x-EVM. These
> > > > > patches were tested on AM335x-EVM.
> > > >
> > > > None of these patches apply to any tree that I know of, what did you do
> > > > them against? Please redo them against the char-next branch of
> > > > linux-next and resend them if you wish to see them applied.
> > >
> > > Presumably they're against eariler patches whcih you don't have. I'm
> > > presently sitting on
> > >
> > > drivers-misc-lis3lv02d-add-generic-dt-matching-code.patch
> > > drivers-misc-lis3lv02d-add-generic-dt-matching-code-fix.patch
> > > drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code.patch
> > > drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix.patch
> > > drivers-misc-lis3lv02d-lis3lv02d_spic-add-dt-matching-table-passthru-code-fix-fix.patch
> > > drivers-misc-lis3lv02d-remove-lis3lv02d-driver-dt-init.patch
> > > drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init.patch
> > > drivers-misc-lis3lv02d-lis3lv02d_spic-add-lis3lv02d-device-tree-init-fix.patch
> > > drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init.patch
> > > drivers-misc-lis3lv02d-lis3lv02d_i2cc-add-lis3lv02d-device-tree-init-fix.patch
> > > drivers-misc-lis3lv02d-fix-some-comments-specific-to-lis331dlh-driver.patch
> >
> > Care to send them to me so that I can get them to Linus for the 3.7
> > merge window?
>
> OK.
>
> > I do keep the char-misc tree for these types of things :)
>
> I've actually been doing this miscdev driver since day one. I'm happy
> to hand over the keys but please review the patches carefully and try not to
> miss stuff!
Will do, thanks.
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-09-26 20:57 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-17 7:23 [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 1/4] lis3: lis3lv02d: remove lis3lv02d driver DT init AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 2/4] lis3: lis3lv02d_spi: Add lis3lv02d device tree init AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 3/4] lis3: lis3lv02d_i2c: " AnilKumar Ch
2012-09-17 7:23 ` [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm AnilKumar Ch
2012-09-17 22:35 ` Andrew Morton
[not found] ` <20120917153559.e07ca263.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-09-18 7:35 ` AnilKumar, Chimata
2012-09-17 11:51 ` [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support Arnd Bergmann
2012-09-26 20:24 ` Greg KH
2012-09-26 20:34 ` Andrew Morton
2012-09-26 20:44 ` Greg KH
2012-09-26 20:54 ` Andrew Morton
2012-09-26 20:57 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).