devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Lee Jones <lee@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [RFC PATCH v3 2/2] mfd: syscon: allow reset control for syscon devices
Date: Thu, 05 Jan 2023 01:35:26 +0800	[thread overview]
Message-ID: <33f6f9e66c8143515d36d17bf33d95362830f83f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <Y7WvXTPxyIGw5y9R@google.com>

Hi Lee,

> > @@ -124,7 +127,17 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk)
> >                 } else {
> >                         ret = regmap_mmio_attach_clk(regmap, clk);
> >                         if (ret)
> > -                               goto err_attach;
> > +                               goto err_attach_clk;
> > +               }
> > +
> > +               reset = of_reset_control_get_optional_exclusive(np, NULL);
> > +               if (IS_ERR(reset)) {
> > +                       ret = PTR_ERR(reset);
> > +                       goto err_attach_clk;
> > +               } else {
> > +                       ret = reset_control_deassert(reset);
> > +                       if (ret)
> > +                               goto err_reset;
> >                 }
> 
> The else is superfluous, right?

Yep, we could move that reset_control_deassert() out of the else block.
If there are no other changes, I'll send a v4 with that.

Cheers,


Jeremy

  reply	other threads:[~2023-01-04 17:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  2:56 [RFC PATCH v3 0/2] Add reset control for mfd syscon devices Jeremy Kerr
2022-12-11  2:56 ` [RFC PATCH v3 1/2] dt-bindings: mfd/syscon: Add resets property Jeremy Kerr
2022-12-11  2:57 ` [RFC PATCH v3 2/2] mfd: syscon: allow reset control for syscon devices Jeremy Kerr
2023-01-04 16:54   ` Lee Jones
2023-01-04 17:35     ` Jeremy Kerr [this message]
2023-01-04 17:57       ` Lee Jones
2023-01-04 22:34         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33f6f9e66c8143515d36d17bf33d95362830f83f.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).