* [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568
@ 2021-07-12 1:44 Simon Xue
2021-07-12 1:45 ` [PATCH v2 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Simon Xue @ 2021-07-12 1:44 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Heiko Stuebner, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, Simon Xue
Add description for rk3568 saradc.
Signed-off-by: Simon Xue <xxm@rock-chips.com>
---
Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
index 1bb76197787b..e512a14e41b4 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
@@ -20,6 +20,7 @@ properties:
- rockchip,px30-saradc
- rockchip,rk3308-saradc
- rockchip,rk3328-saradc
+ - rockchip,rk3568-saradc
- rockchip,rv1108-saradc
- const: rockchip,rk3399-saradc
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc
2021-07-12 1:44 [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
@ 2021-07-12 1:45 ` Simon Xue
2021-07-12 7:02 ` Heiko Stübner
2021-07-12 7:01 ` [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Heiko Stübner
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Simon Xue @ 2021-07-12 1:45 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Heiko Stuebner, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, Simon Xue
It is similar to other devices, but with 8 channels.
Signed-off-by: Simon Xue <xxm@rock-chips.com>
---
drivers/iio/adc/rockchip_saradc.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index 12584f1631d8..f3eb8d2e50dc 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -35,7 +35,7 @@
#define SARADC_DLY_PU_SOC_MASK 0x3f
#define SARADC_TIMEOUT msecs_to_jiffies(100)
-#define SARADC_MAX_CHANNELS 6
+#define SARADC_MAX_CHANNELS 8
struct rockchip_saradc_data {
const struct iio_chan_spec *channels;
@@ -192,6 +192,23 @@ static const struct rockchip_saradc_data rk3399_saradc_data = {
.clk_rate = 1000000,
};
+static const struct iio_chan_spec rockchip_rk3568_saradc_iio_channels[] = {
+ SARADC_CHANNEL(0, "adc0", 10),
+ SARADC_CHANNEL(1, "adc1", 10),
+ SARADC_CHANNEL(2, "adc2", 10),
+ SARADC_CHANNEL(3, "adc3", 10),
+ SARADC_CHANNEL(4, "adc4", 10),
+ SARADC_CHANNEL(5, "adc5", 10),
+ SARADC_CHANNEL(6, "adc6", 10),
+ SARADC_CHANNEL(7, "adc7", 10),
+};
+
+static const struct rockchip_saradc_data rk3568_saradc_data = {
+ .channels = rockchip_rk3568_saradc_iio_channels,
+ .num_channels = ARRAY_SIZE(rockchip_rk3568_saradc_iio_channels),
+ .clk_rate = 1000000,
+};
+
static const struct of_device_id rockchip_saradc_match[] = {
{
.compatible = "rockchip,saradc",
@@ -202,6 +219,9 @@ static const struct of_device_id rockchip_saradc_match[] = {
}, {
.compatible = "rockchip,rk3399-saradc",
.data = &rk3399_saradc_data,
+ }, {
+ .compatible = "rockchip,rk3568-saradc",
+ .data = &rk3568_saradc_data,
},
{},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568
2021-07-12 1:44 [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
2021-07-12 1:45 ` [PATCH v2 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
@ 2021-07-12 7:01 ` Heiko Stübner
2021-07-15 16:23 ` Rob Herring
2021-07-17 17:04 ` Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2021-07-12 7:01 UTC (permalink / raw)
To: Jonathan Cameron, Simon Xue
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio, Simon Xue
Am Montag, 12. Juli 2021, 03:44:37 CEST schrieb Simon Xue:
> Add description for rk3568 saradc.
>
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> index 1bb76197787b..e512a14e41b4 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> @@ -20,6 +20,7 @@ properties:
> - rockchip,px30-saradc
> - rockchip,rk3308-saradc
> - rockchip,rk3328-saradc
> + - rockchip,rk3568-saradc
> - rockchip,rv1108-saradc
> - const: rockchip,rk3399-saradc
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc
2021-07-12 1:45 ` [PATCH v2 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
@ 2021-07-12 7:02 ` Heiko Stübner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2021-07-12 7:02 UTC (permalink / raw)
To: Jonathan Cameron, Simon Xue
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio, Simon Xue
Am Montag, 12. Juli 2021, 03:45:07 CEST schrieb Simon Xue:
> It is similar to other devices, but with 8 channels.
>
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
If a previous version received such a Reviewed-by or similar
please add them to subsequent new versions that you send.
[Not needed here as I sent them again, but to keep in mind :-) ]
Thanks
Heiko
> ---
> drivers/iio/adc/rockchip_saradc.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 12584f1631d8..f3eb8d2e50dc 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -35,7 +35,7 @@
> #define SARADC_DLY_PU_SOC_MASK 0x3f
>
> #define SARADC_TIMEOUT msecs_to_jiffies(100)
> -#define SARADC_MAX_CHANNELS 6
> +#define SARADC_MAX_CHANNELS 8
>
> struct rockchip_saradc_data {
> const struct iio_chan_spec *channels;
> @@ -192,6 +192,23 @@ static const struct rockchip_saradc_data rk3399_saradc_data = {
> .clk_rate = 1000000,
> };
>
> +static const struct iio_chan_spec rockchip_rk3568_saradc_iio_channels[] = {
> + SARADC_CHANNEL(0, "adc0", 10),
> + SARADC_CHANNEL(1, "adc1", 10),
> + SARADC_CHANNEL(2, "adc2", 10),
> + SARADC_CHANNEL(3, "adc3", 10),
> + SARADC_CHANNEL(4, "adc4", 10),
> + SARADC_CHANNEL(5, "adc5", 10),
> + SARADC_CHANNEL(6, "adc6", 10),
> + SARADC_CHANNEL(7, "adc7", 10),
> +};
> +
> +static const struct rockchip_saradc_data rk3568_saradc_data = {
> + .channels = rockchip_rk3568_saradc_iio_channels,
> + .num_channels = ARRAY_SIZE(rockchip_rk3568_saradc_iio_channels),
> + .clk_rate = 1000000,
> +};
> +
> static const struct of_device_id rockchip_saradc_match[] = {
> {
> .compatible = "rockchip,saradc",
> @@ -202,6 +219,9 @@ static const struct of_device_id rockchip_saradc_match[] = {
> }, {
> .compatible = "rockchip,rk3399-saradc",
> .data = &rk3399_saradc_data,
> + }, {
> + .compatible = "rockchip,rk3568-saradc",
> + .data = &rk3568_saradc_data,
> },
> {},
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568
2021-07-12 1:44 [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
2021-07-12 1:45 ` [PATCH v2 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
2021-07-12 7:01 ` [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Heiko Stübner
@ 2021-07-15 16:23 ` Rob Herring
2021-07-17 17:04 ` Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-07-15 16:23 UTC (permalink / raw)
To: Simon Xue
Cc: Peter Meerwald-Stadler, Jonathan Cameron, robh+dt,
Heiko Stuebner, linux-rockchip, Lars-Peter Clausen, Johan Jonker,
linux-iio, devicetree
On Mon, 12 Jul 2021 09:44:37 +0800, Simon Xue wrote:
> Add description for rk3568 saradc.
>
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
> ---
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568
2021-07-12 1:44 [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
` (2 preceding siblings ...)
2021-07-15 16:23 ` Rob Herring
@ 2021-07-17 17:04 ` Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2021-07-17 17:04 UTC (permalink / raw)
To: Simon Xue
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Heiko Stuebner, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio
On Mon, 12 Jul 2021 09:44:37 +0800
Simon Xue <xxm@rock-chips.com> wrote:
> Add description for rk3568 saradc.
>
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
Series applied to the togreg branch of iio.git and pushed out as testing
to see if 0-day can find anything we missed.
Thanks,
Jonathan
> ---
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> index 1bb76197787b..e512a14e41b4 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> @@ -20,6 +20,7 @@ properties:
> - rockchip,px30-saradc
> - rockchip,rk3308-saradc
> - rockchip,rk3328-saradc
> + - rockchip,rk3568-saradc
> - rockchip,rv1108-saradc
> - const: rockchip,rk3399-saradc
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-17 17:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 1:44 [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
2021-07-12 1:45 ` [PATCH v2 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
2021-07-12 7:02 ` Heiko Stübner
2021-07-12 7:01 ` [PATCH v2 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Heiko Stübner
2021-07-15 16:23 ` Rob Herring
2021-07-17 17:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).