From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957E1CCA47E for ; Tue, 7 Jun 2022 02:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236040AbiFGCpe (ORCPT ); Mon, 6 Jun 2022 22:45:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236045AbiFGCpd (ORCPT ); Mon, 6 Jun 2022 22:45:33 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21A2BC9678; Mon, 6 Jun 2022 19:45:31 -0700 (PDT) X-UUID: 332566c499904591a6940ae38d748514-20220607 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:af18d0f9-58c2-4863-9f39-8e73b2d988a3,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:2575dce4-2ba2-4dc1-b6c5-11feb6c769e0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:0,BEC:nil X-UUID: 332566c499904591a6940ae38d748514-20220607 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2041919683; Tue, 07 Jun 2022 10:45:29 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 7 Jun 2022 10:45:27 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 7 Jun 2022 10:45:27 +0800 Message-ID: <3475079bf7917d5b522f8d0ceec7cb56b130a406.camel@mediatek.com> Subject: Re: [PATCH v10 03/21] drm/edid: Convert cea_sad helper struct to kernelDoc From: Rex-BC Chen To: AngeloGioacchino Del Regno , Guillaume Ranquet , Chun-Kuang Hu , Philipp Zabel , "David Airlie" , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun , "Kishon Vijay Abraham I" , Vinod Koul , "Helge Deller" , CK Hu , Jitao shi CC: , , , , , , Date: Tue, 7 Jun 2022 10:45:27 +0800 In-Reply-To: <4c19d5fb-1e45-9149-4208-5d848eeb7565@collabora.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-4-granquet@baylibre.com> <4c19d5fb-1e45-9149-4208-5d848eeb7565@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2022-05-25 at 14:01 +0200, AngeloGioacchino Del Regno wrote: > Il 23/05/22 12:47, Guillaume Ranquet ha scritto: > > Signed-off-by: Guillaume Ranquet > > --- > > include/drm/drm_edid.h | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > > index 144c495b99c4..37c420423625 100644 > > --- a/include/drm/drm_edid.h > > +++ b/include/drm/drm_edid.h > > @@ -359,12 +359,18 @@ struct edid { > > > > #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)- > > >prod_code[1] << 8)) > > > > -/* Short Audio Descriptor */ > > +/** > > + * struct cea_sad - Short Audio Descriptor. > > Perhaps.... > > * struct cea_sad - CEA Short Audio Descriptor > > ...but that's relative to personal liking and nothing else, it's also > fine as > it is, if you like it more as it is. The ball is yours :-P > > Regardless of any choice about changing the description or not: > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Cheers, > Angelo > Hello Angelo, ok, I will do this in next version. BRs, Bo-Chen > > + * @format: See HDMI_AUDIO_CODING_TYPE_*. > > + * @channels: max number of channels - 1. > > + * @freq: See CEA_SAD_FREQ_*. > > + * @byte2: meaning depends on format. > > + */ > > struct cea_sad { > > u8 format; > > - u8 channels; /* max number of channels - 1 */ > > + u8 channels; > > u8 freq; > > - u8 byte2; /* meaning depends on format */ > > + u8 byte2; > > }; > > > > struct drm_encoder; > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek