* [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example
@ 2019-12-13 18:00 Miquel Raynal
2019-12-13 18:00 ` [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example Miquel Raynal
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Miquel Raynal @ 2019-12-13 18:00 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Rob Herring, Mark Rutland, devicetree,
Heiko Stuebner, linux-rockchip
Cc: linux-arm-kernel, Paul Kocialkowski, Maxime Chevallier,
Thomas Petazzoni, Miquel Raynal
Use the upstream compatible instead of the BSP one in the example
section of the DT bindings for this IP.
Fixes: 3200df7fa1d6 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
.../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
index 476c56a1dc8c..72aca81e8959 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
@@ -58,7 +58,7 @@ additionalProperties: false
examples:
- |
dsi_dphy: phy@ff2e0000 {
- compatible = "rockchip,px30-video-phy";
+ compatible = "rockchip,px30-dsi-dphy";
reg = <0x0 0xff2e0000 0x0 0x10000>;
clocks = <&pmucru 13>, <&cru 12>;
clock-names = "ref", "pclk";
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example
2019-12-13 18:00 [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example Miquel Raynal
@ 2019-12-13 18:00 ` Miquel Raynal
2019-12-13 18:02 ` Heiko Stübner
2019-12-19 23:45 ` Rob Herring
2019-12-13 18:01 ` [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example Heiko Stübner
2019-12-19 23:47 ` Rob Herring
2 siblings, 2 replies; 6+ messages in thread
From: Miquel Raynal @ 2019-12-13 18:00 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Rob Herring, Mark Rutland, devicetree,
Heiko Stuebner, linux-rockchip
Cc: linux-arm-kernel, Paul Kocialkowski, Maxime Chevallier,
Thomas Petazzoni, Miquel Raynal
Update the example phandles to reference actual nodes and give a
working starting point.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
.../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
index 72aca81e8959..2e35bfdf47a1 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
@@ -60,9 +60,9 @@ examples:
dsi_dphy: phy@ff2e0000 {
compatible = "rockchip,px30-dsi-dphy";
reg = <0x0 0xff2e0000 0x0 0x10000>;
- clocks = <&pmucru 13>, <&cru 12>;
+ clocks = <&pmucru SCLK_MIPIDSIPHY_REF>, <&cru PCLK_MIPIDSIPHY>;
clock-names = "ref", "pclk";
- resets = <&cru 12>;
+ resets = <&cru SRST_MIPIDSIPHY_P>;
reset-names = "apb";
#phy-cells = <0>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example
2019-12-13 18:00 [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example Miquel Raynal
2019-12-13 18:00 ` [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example Miquel Raynal
@ 2019-12-13 18:01 ` Heiko Stübner
2019-12-19 23:47 ` Rob Herring
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2019-12-13 18:01 UTC (permalink / raw)
To: Miquel Raynal
Cc: Kishon Vijay Abraham I, Rob Herring, Mark Rutland, devicetree,
linux-rockchip, linux-arm-kernel, Paul Kocialkowski,
Maxime Chevallier, Thomas Petazzoni
Am Freitag, 13. Dezember 2019, 19:00:18 CET schrieb Miquel Raynal:
> Use the upstream compatible instead of the BSP one in the example
> section of the DT bindings for this IP.
>
> Fixes: 3200df7fa1d6 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks for catching that :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> index 476c56a1dc8c..72aca81e8959 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> @@ -58,7 +58,7 @@ additionalProperties: false
> examples:
> - |
> dsi_dphy: phy@ff2e0000 {
> - compatible = "rockchip,px30-video-phy";
> + compatible = "rockchip,px30-dsi-dphy";
> reg = <0x0 0xff2e0000 0x0 0x10000>;
> clocks = <&pmucru 13>, <&cru 12>;
> clock-names = "ref", "pclk";
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example
2019-12-13 18:00 ` [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example Miquel Raynal
@ 2019-12-13 18:02 ` Heiko Stübner
2019-12-19 23:45 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2019-12-13 18:02 UTC (permalink / raw)
To: Miquel Raynal
Cc: Kishon Vijay Abraham I, Rob Herring, Mark Rutland, devicetree,
linux-rockchip, linux-arm-kernel, Paul Kocialkowski,
Maxime Chevallier, Thomas Petazzoni
Am Freitag, 13. Dezember 2019, 19:00:19 CET schrieb Miquel Raynal:
> Update the example phandles to reference actual nodes and give a
> working starting point.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example
2019-12-13 18:00 ` [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example Miquel Raynal
2019-12-13 18:02 ` Heiko Stübner
@ 2019-12-19 23:45 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-12-19 23:45 UTC (permalink / raw)
To: Miquel Raynal
Cc: Kishon Vijay Abraham I, Mark Rutland, devicetree, Heiko Stuebner,
linux-rockchip, linux-arm-kernel, Paul Kocialkowski,
Maxime Chevallier, Thomas Petazzoni
On Fri, Dec 13, 2019 at 07:00:19PM +0100, Miquel Raynal wrote:
> Update the example phandles to reference actual nodes and give a
> working starting point.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> index 72aca81e8959..2e35bfdf47a1 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> @@ -60,9 +60,9 @@ examples:
> dsi_dphy: phy@ff2e0000 {
> compatible = "rockchip,px30-dsi-dphy";
> reg = <0x0 0xff2e0000 0x0 0x10000>;
> - clocks = <&pmucru 13>, <&cru 12>;
> + clocks = <&pmucru SCLK_MIPIDSIPHY_REF>, <&cru PCLK_MIPIDSIPHY>;
> clock-names = "ref", "pclk";
> - resets = <&cru 12>;
> + resets = <&cru SRST_MIPIDSIPHY_P>;
Without the appropriate include files, this will break building the
example.
> reset-names = "apb";
> #phy-cells = <0>;
> };
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example
2019-12-13 18:00 [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example Miquel Raynal
2019-12-13 18:00 ` [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example Miquel Raynal
2019-12-13 18:01 ` [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example Heiko Stübner
@ 2019-12-19 23:47 ` Rob Herring
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-12-19 23:47 UTC (permalink / raw)
To: Miquel Raynal
Cc: Kishon Vijay Abraham I, Mark Rutland, devicetree, Heiko Stuebner,
linux-rockchip, linux-arm-kernel, Paul Kocialkowski,
Maxime Chevallier, Thomas Petazzoni, Miquel Raynal
On Fri, 13 Dec 2019 19:00:18 +0100, Miquel Raynal wrote:
> Use the upstream compatible instead of the BSP one in the example
> section of the DT bindings for this IP.
>
> Fixes: 3200df7fa1d6 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-19 23:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 18:00 [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example Miquel Raynal
2019-12-13 18:00 ` [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example Miquel Raynal
2019-12-13 18:02 ` Heiko Stübner
2019-12-19 23:45 ` Rob Herring
2019-12-13 18:01 ` [PATCH 1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example Heiko Stübner
2019-12-19 23:47 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).