From: "Heiko Stübner" <heiko@sntech.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 8/8] arm64: dts: rockchip: Add Landingship config
Date: Tue, 29 Mar 2016 22:18:59 +0200 [thread overview]
Message-ID: <3754303.PKl0CGdnnX@diego> (raw)
In-Reply-To: <1458136727-32075-9-git-send-email-afaerber@suse.de>
Am Mittwoch, 16. März 2016, 14:58:46 schrieb Andreas Färber:
This needs a commit message explaining the i2c1/i2c2 voodoo below - especially
as this is the only difference to the core geekbox board.
And I'm still not fully convinced about having the landing ship separate.
I guess I'll just go to the talk about "Portable Device Tree Connector:
Painless Expansion Board Support" [0] on monday to help make up my mind ;-) .
Heiko
[0] http://openiotelc2016.sched.org/event/6DA4/portable-device-tree-connector-painless-expansion-board-support-pantelis-antoniou-konsulko-group
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v3 -> v4: Unchanged
>
> v2 -> v3:
> * Changed compatible string to include geekbox- (Heiko)
> * Rebroke compatible strings line
> * Disabled i2c1 to avoid hang (next-20160304)
>
> v2: New - showcases inclusion of GeekBox module config
>
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3368-geekbox-landingship.dts | 57
> ++++++++++++++++++++++ 2 files changed, 58 insertions(+)
> create mode 100644
> arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile
> b/arch/arm64/boot/dts/rockchip/Makefile index df37865e8ced..201bcd9863ce
> 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -1,5 +1,6 @@
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-evb-act8846.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-geekbox.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-geekbox-landingship.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
>
> always := $(dtb-y)
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts
> b/arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts new file mode
> 100644
> index 000000000000..a28ace9512bb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox-landingship.dts
> @@ -0,0 +1,57 @@
> +/*
> + * Copyright (c) 2016 Andreas Färber
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "rk3368-geekbox.dts"
> +
> +/ {
> + model = "GeekBox on Landingship";
> + compatible = "geekbuying,geekbox-landingship",
> + "geekbuying,geekbox", "rockchip,rk3368";
> +};
> +
> +&i2c1 {
> + status = "disabled";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
next prev parent reply other threads:[~2016-03-29 20:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 13:58 [PATCH v4 0/8] arm64: rockchip: Initial GeekBox enablement Andreas Färber
2016-03-16 13:58 ` [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes Andreas Färber
[not found] ` <1458136727-32075-2-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-19 8:04 ` Heiko Stuebner
2016-03-31 17:15 ` Heiko Stuebner
2016-03-31 20:45 ` Heiko Stuebner
2016-04-12 5:24 ` Heiko Stuebner
[not found] ` <1458136727-32075-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-16 13:58 ` [PATCH v4 2/8] Documentation: devicetree: Add vendor prefix for GeekBuying.com Andreas Färber
[not found] ` <1458136727-32075-3-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-28 20:24 ` Heiko Stübner
2016-03-16 13:58 ` [PATCH v4 3/8] Documentation: devicetree: rockchip: Document GeekBox Andreas Färber
2016-03-29 20:13 ` Heiko Stübner
2016-03-29 20:45 ` Andreas Färber
2016-03-29 21:21 ` Heiko Stübner
2016-03-31 17:02 ` Heiko Stuebner
2016-03-16 13:58 ` [PATCH v4 7/8] Documentation: devicetree: rockchip: Document Landingship Andreas Färber
[not found] ` <1458136727-32075-8-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-18 21:30 ` Rob Herring
2016-03-18 21:37 ` Andreas Färber
2016-03-16 13:58 ` [PATCH v4 8/8] arm64: dts: rockchip: Add Landingship config Andreas Färber
2016-03-29 20:18 ` Heiko Stübner [this message]
2016-03-29 22:18 ` Andreas Färber
2016-03-16 13:58 ` [PATCH v4 4/8] arm64: dts: rockchip: Add GeekBox config Andreas Färber
[not found] ` <1458136727-32075-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-29 19:50 ` Heiko Stübner
2016-03-16 13:58 ` [PATCH v4 5/8] arm64: dts: rockchip: Clean up gpio-keys nodes Andreas Färber
[not found] ` <1458136727-32075-6-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-16 21:55 ` Julien Chauveau
2016-03-28 20:24 ` Heiko Stübner
2016-03-28 20:25 ` Heiko Stübner
2016-03-16 13:58 ` [PATCH v4 6/8] arm64: dts: rockchip: Add power key to GeekBox Andreas Färber
2016-03-16 21:55 ` Julien Chauveau
[not found] ` <1458136727-32075-7-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-29 20:14 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3754303.PKl0CGdnnX@diego \
--to=heiko@sntech.de \
--cc=afaerber@suse.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).