* [PATCH] arm: dts: sun7i: include correct ccu clock header
@ 2018-01-31 19:31 Giulio Benetti
2018-02-01 15:19 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2018-01-31 19:31 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, Giulio Benetti
Include correct clock header sun7i-a20-ccu.h
instead of sun4i-a20-ccu.h.
Including sun4i header instead of sun7i
prevents using sun7i specific defines.
Substitute header inclusion in sun7i-a20.dtsi
using right one.
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 1aa05a0..d0865d2 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -47,7 +47,7 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/thermal/thermal.h>
#include <dt-bindings/dma/sun4i-a10.h>
-#include <dt-bindings/clock/sun4i-a10-ccu.h>
+#include <dt-bindings/clock/sun7i-a20-ccu.h>
#include <dt-bindings/reset/sun4i-a10-ccu.h>
/ {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: dts: sun7i: include correct ccu clock header
2018-01-31 19:31 [PATCH] arm: dts: sun7i: include correct ccu clock header Giulio Benetti
@ 2018-02-01 15:19 ` Maxime Ripard
2018-02-01 15:37 ` Giulio Benetti
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2018-02-01 15:19 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
Hi,
On Wed, Jan 31, 2018 at 08:31:26PM +0100, Giulio Benetti wrote:
> Include correct clock header sun7i-a20-ccu.h
> instead of sun4i-a20-ccu.h.
You should wrap at 72 characters.
> Including sun4i header instead of sun7i
> prevents using sun7i specific defines.
>
> Substitute header inclusion in sun7i-a20.dtsi
> using right one.
This sentence is redundant with the first one.
Dropped the first one, corrected the wrapping and applied, thanks
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: dts: sun7i: include correct ccu clock header
2018-02-01 15:19 ` Maxime Ripard
@ 2018-02-01 15:37 ` Giulio Benetti
0 siblings, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2018-02-01 15:37 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel
Il 01/02/2018 16:19, Maxime Ripard ha scritto:
> Hi,
>
> On Wed, Jan 31, 2018 at 08:31:26PM +0100, Giulio Benetti wrote:
>> Include correct clock header sun7i-a20-ccu.h
>> instead of sun4i-a20-ccu.h.
>
> You should wrap at 72 characters.
Ok, keep in mind for next patches. Thanks
>
>> Including sun4i header instead of sun7i
>> prevents using sun7i specific defines.
>>
>> Substitute header inclusion in sun7i-a20.dtsi
>> using right one.
>
> This sentence is redundant with the first one.
Yes, you're right. Thanks
>
> Dropped the first one, corrected the wrapping and applied, thanks
>
> Maxime
>
--
Giulio Benetti
R&D Manager &
Advanced Research
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-01 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 19:31 [PATCH] arm: dts: sun7i: include correct ccu clock header Giulio Benetti
2018-02-01 15:19 ` Maxime Ripard
2018-02-01 15:37 ` Giulio Benetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).