From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Nishanth Menon <nm@ti.com>, Roger Quadros <rogerq@ti.com>,
Keerthy <j-keerthy@ti.com>, Jyri Sarha <jsarha@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>, Tero Kristo <t-kristo@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level
Date: Thu, 5 Nov 2020 09:25:01 +0200 [thread overview]
Message-ID: <3cc234ac-ea7a-fe3e-e485-ee3123048fec@ti.com> (raw)
In-Reply-To: <20201104224356.18040-2-nm@ti.com>
On 05/11/2020 00:43, Nishanth Menon wrote:
> The device tree standard sets the default node behavior when status
> property as enabled. There are many reasons for doing the same, number
> of strings in device tree, default power management functionality etc
> are few of the reasons.
>
> In general, after a few rounds of discussions [1] there are few
> options one could take when dealing with SoC dtsi and board dts
>
> a. SoC dtsi provide nodes as a super-set default (aka enabled) state and
> to prevent messy board files, when more boards are added per SoC, we
> optimize and disable commonly un-used nodes in board-common.dtsi
> b. SoC dtsi disables all hardware dependent nodes by default and board
> dts files enable nodes based on a need basis.
> c. Subjectively pick and choose which nodes we will disable by default
> in SoC dtsi and over the years we can optimize things and change
> default state depending on the need.
>
> While there are pros and cons on each of these approaches, the right
> thing to do will be to stick with device tree default standards and
> work within those established rules. So, we choose to go with option
> (a).
>
> Lets cleanup defaults of am654 SoC dtsi before this gets more harder
> to cleanup later on and new SoCs are added.
>
> The dtb generated is identical with the patch and it is just cleanup to
> ensure we have a clean usage model
>
> [1] https://lore.kernel.org/linux-arm-kernel/20201027130701.GE5639@atomide.com/
>
> Fixes: 9bcb631e9953 ("arm64: dts: ti: k3-am654-main: Add McASP nodes")
> Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node")
> Cc: Jyri Sarha <jsarha@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 --------
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 16 ++++++++++++++++
> 2 files changed, 16 insertions(+), 8 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-11-05 7:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 22:43 [PATCH 0/4] arm64: dts: ti: Cleanup mix of "okay" and "disabled" usage Nishanth Menon
2020-11-04 22:43 ` [PATCH 1/4] arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level Nishanth Menon
2020-11-05 7:25 ` Tomi Valkeinen [this message]
2020-11-04 22:43 ` [PATCH 2/4] arm64: dts: ti: k3-j721e*: " Nishanth Menon
2020-11-05 7:25 ` Tomi Valkeinen
2020-11-05 7:32 ` Peter Ujfalusi
2020-11-05 14:08 ` Nishanth Menon
2020-11-06 11:32 ` Peter Ujfalusi
2020-11-06 21:46 ` Nishanth Menon
2020-11-09 7:49 ` Peter Ujfalusi
2020-11-04 22:43 ` [PATCH 3/4] arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay" for crypto Nishanth Menon
2020-11-04 22:43 ` [PATCH 4/4] arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USB Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cc234ac-ea7a-fe3e-e485-ee3123048fec@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=jsarha@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).