From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [RFT PATCH] ARM: dts: exynos: Enable Mixer node for Exynos5800 Peach Pi machine Date: Tue, 12 Dec 2017 08:01:27 +0100 Message-ID: <3e6e4b15-9f8a-bea1-3c8e-2d85fc4c512d@samsung.com> References: <20171211224856.29264-1-javierm@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20171211224856.29264-1-javierm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Guillaume Tucker , Daniel Vetter , Shuah Khan , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kukjin Kim , Russell King , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , Krzysztof Kozlowski , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi On 2017-12-11 23:48, Javier Martinez Canillas wrote: > Commit 1cb686c08d12 ("ARM: dts: exynos: Add status property to Exynos 542x > Mixer nodes") disabled the Mixer node by default in the DTSI and enabled > for each Exynos 542x DTS. But unfortunately it missed to enable it for the > Exynos5800 Peach Pi machine, since the 5800 is also an 542x SoC variant. > > Signed-off-by: Javier Martinez Canillas Acked-by: Marek Szyprowski > --- > > I believe this may cause the boot issues reported on Exynos5800 Peach Pi > from v4.15-rc3, the mentioned commit made to v4.15-rc1 but it seems that > didn't cause any harm until commit ("510353a63796 drm/bridge: analogix > dp: Fix runtime PM state in get_modes() callback") fixed the runtime PM > management in the DP driver. Thanks for analyzing this. Lack of this change was probably responsible for Exynos DRM initialization failure ("exynos-drm exynos-drm: failed to bind 14530000.hdmi (ops hdmi_component_ops): -1" message and probably further error "unbalanced disables for lcd_vdd", which shows that failure path of analogix dp and simple panel causes unbalanced regulator disable. This patch should go to v4.15-rcX (fixes) if possible. > I can't test right now, but I'm posting anyways as a RFT in case others > that have access to a Peach Pi can test it. > > Best regards, > Javier > > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index b2b95ff205e8..0029ec27819c 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -664,6 +664,10 @@ > status = "okay"; > }; > > +&mixer { > + status = "okay"; > +}; > + > /* eMMC flash */ > &mmc_0 { > status = "okay"; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html