From: Merlijn Wajer <merlijn@wizzup.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Mattias Jacobsson" <2pi@mok.nu>,
"Darren Hart (VMware)" <dvhart@infradead.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] Input: add `SW_MACHINE_COVER`
Date: Sat, 15 Feb 2020 10:09:22 +0100 [thread overview]
Message-ID: <40ab03bb-4746-4414-f4e2-60740d539f3e@wizzup.org> (raw)
In-Reply-To: <20200214143857.msrkzzsss5hbb43l@earth.universe>
[-- Attachment #1.1: Type: text/plain, Size: 1085 bytes --]
Hi Sebastian,
On 14/02/2020 15:38, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Feb 14, 2020 at 02:02:47PM +0100, Merlijn Wajer wrote:
>> This event code represents the state of a removable cover of a device.
>> Value 1 means that the cover is open or removed, value 0 means that the
>> cover is closed.
>
> This is the opposit of what is being stated everywhere else. It does
> not really matter, but it must be used consistently :)
Oh, my bad. Indeed, value 1 means that the cover is closed, will fix.
>> This can be used to preempt users removing a removable mmc card or even
>> the battery, allowing userspace to attempt to safely unmount a card.
>
> I would drop this sentence, since its very specific to the N900. The
> name is generic enough to e.g. also apply for desktop machines, which
> sometimes have a cover switch for doing a shutdown (because of poor
> airflow when open).
Fair enough.
>> ---
>
> Missing Signed-off-by.
Will add - thanks.
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Cheers,
Merlijn
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-02-15 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:02 [RFC PATCH 0/2] Add SW_MACHINE_COVER key Merlijn Wajer
2020-02-14 13:02 ` [RFC PATCH 1/2] Input: add `SW_MACHINE_COVER` Merlijn Wajer
2020-02-14 14:38 ` Sebastian Reichel
2020-02-15 9:09 ` Merlijn Wajer [this message]
2020-02-14 19:16 ` Ladislav Michl
2020-02-15 9:03 ` Merlijn Wajer
2020-02-14 13:02 ` [RFC PATCH 2/2] ARM: dts: n900: remove mmc1 card detect gpio Merlijn Wajer
2020-02-14 14:49 ` Sebastian Reichel
2020-02-15 9:13 ` Merlijn Wajer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ab03bb-4746-4414-f4e2-60740d539f3e@wizzup.org \
--to=merlijn@wizzup.org \
--cc=2pi@mok.nu \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).