From: Sricharan R <sricharan@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: mark.rutland@arm.com, robh@kernel.org,
devicetree@vger.kernel.org, marc.zyngier@arm.com,
catalin.marinas@arm.com, richardcochran@gmail.com,
will.deacon@arm.com, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, david.brown@linaro.org,
absahu@codeaurora.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, andy.gross@linaro.org,
linux-soc@vger.kernel.org, sboyd@codeaurora.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi
Date: Mon, 2 Apr 2018 10:58:30 +0530 [thread overview]
Message-ID: <41dbb135-f392-3450-029f-bab5a8e2f9d8@codeaurora.org> (raw)
In-Reply-To: <20180327170450.GH1403@tuxbook-pro>
On 3/27/2018 10:34 PM, Bjorn Andersson wrote:
> On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote:
>> + soc {
>> + pinctrl@1000000 {
>> + serial_0_pins: serial0_pinmux {
>
> Please, no underscores in the node name.
ok.
>
>> + mux {
>
> Fyi, you can put the pinctrl properties directly into the state node,
> omitting the "mux" level.
>
ok, will change.
>> + pins = "gpio16", "gpio17";
>> + function = "blsp_uart0";
>> + bias-disable;
>> + };
>> + };
>> +
>
> Apart from this the patch looks good.
Thanks.
Regards,
Sricharan
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-04-02 5:28 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 10:18 [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals Sricharan R
2018-03-23 10:18 ` [PATCH v5 01/13] firmware: qcom: scm: Add ipq4019 soc compatible Sricharan R
2018-03-27 16:56 ` Bjorn Andersson
2018-03-23 10:18 ` [PATCH v5 02/13] ARM: dts: ipq4019: Add a default chosen node Sricharan R
2018-03-27 16:56 ` Bjorn Andersson
2018-03-23 10:18 ` [PATCH v5 03/13] ARM: dts: ipq4019: Add a few peripheral nodes Sricharan R
2018-03-27 16:50 ` Bjorn Andersson
2018-04-02 5:27 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 04/13] ARM: dts: ipq4019: Change the max opp frequency Sricharan R
2018-03-23 10:18 ` [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi Sricharan R
2018-03-27 17:04 ` Bjorn Andersson
2018-04-02 5:28 ` Sricharan R [this message]
2018-04-18 6:59 ` [v5,05/13] " Sven Eckelmann
2018-04-18 7:07 ` Sven Eckelmann
2018-04-18 7:15 ` Sricharan R
2018-04-18 7:38 ` Sven Eckelmann
2018-04-18 8:39 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 06/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file Sricharan R
2018-03-27 17:12 ` Bjorn Andersson
2018-04-02 5:34 ` Sricharan R
2018-04-02 6:30 ` Varadarajan Narayanan
2018-03-23 10:18 ` [PATCH v5 07/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c3 " Sricharan R
2018-03-27 17:14 ` Bjorn Andersson
2018-04-02 6:07 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data Sricharan R
2018-03-27 17:20 ` Bjorn Andersson
2018-04-02 6:09 ` Sricharan R
2018-04-18 6:59 ` [v5,08/13] " Sven Eckelmann
2018-04-18 7:12 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 09/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c1 board file Sricharan R
2018-03-27 17:22 ` Bjorn Andersson
2018-04-02 6:10 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 10/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c2 " Sricharan R
2018-03-27 17:29 ` Bjorn Andersson
2018-04-02 6:12 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 11/13] ARM: dts: ipq8074: Add peripheral nodes Sricharan R
2018-03-27 17:45 ` Bjorn Andersson
2018-04-02 6:34 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 12/13] ARM: dts: ipq8074: Add pcie nodes Sricharan R
2018-03-27 17:46 ` Bjorn Andersson
2018-04-02 6:35 ` Sricharan R
2018-03-23 10:18 ` [PATCH v5 13/13] ARM: dts: ipq8074: Enable few peripherals for hk01 board Sricharan R
2018-03-27 17:49 ` Bjorn Andersson
2018-04-02 6:36 ` Sricharan R
2018-03-24 2:17 ` [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals Richard Cochran
2018-03-24 6:12 ` sricharan
2018-03-24 17:16 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41dbb135-f392-3450-029f-bab5a8e2f9d8@codeaurora.org \
--to=sricharan@codeaurora.org \
--cc=absahu@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).