From: Aswath Govindraju <a-govindraju@ti.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH 3/6] arm64: dts: ti: k3-j721e: Add support for MCAN nodes
Date: Wed, 21 Jul 2021 13:18:06 +0530 [thread overview]
Message-ID: <41ff222b-e751-1586-b774-4e55bfe5e017@ti.com> (raw)
In-Reply-To: <20210720145451.6eby7pbfocyyfi4e@pengutronix.de>
Hi Marc,
On 20/07/21 8:24 pm, Marc Kleine-Budde wrote:
> On 20.07.2021 19:46:39, Aswath Govindraju wrote:
>> From: Faiz Abbas <faiz_abbas@ti.com>
>>
>> Add support for 14 MCAN controllers in main domain and 2 MCAN controllers
>> present in mcu domain. All the MCAN controllers support classic CAN
>> messages as well as CAN_FD messages.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 196 ++++++++++++++++++
>> .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 28 +++
>> 2 files changed, 224 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> index cf3482376c1e..4215b8e6785a 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> @@ -1940,4 +1940,200 @@
>> bus_freq = <1000000>;
>> };
>> };
>> +
>> + main_mcan0: can@2701000 {
>> + compatible = "bosch,m_can";
>> + reg = <0x00 0x02701000 0x00 0x200>,
>> + <0x00 0x02708000 0x00 0x8000>;
>> + reg-names = "m_can", "message_ram";
>> + power-domains = <&k3_pds 156 TI_SCI_PD_EXCLUSIVE>;
>> + clocks = <&k3_clks 156 1>, <&k3_clks 156 0>;
>> + clock-names = "cclk", "hclk";
>> + interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "int0", "int1";
>> + bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>;
>
> Are you intentionally only enabling 1 TX buffer?
>
I have used this configuration for testing. It can be increased to 32 if
required. Is it better to set it to the maximum number of buffers ?
Thanks,
Aswath
> Marc
>
next prev parent reply other threads:[~2021-07-21 7:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 14:16 [PATCH 0/6] CAN: Add support for CAN in AM65,J721e and AM64 Aswath Govindraju
2021-07-20 14:16 ` [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN Aswath Govindraju
2021-07-20 14:20 ` Marc Kleine-Budde
2021-07-20 14:30 ` Aswath Govindraju
2021-07-20 14:39 ` Nishanth Menon
2021-07-20 14:49 ` Marc Kleine-Budde
2021-07-20 14:16 ` [PATCH 2/6] arm64: dts: ti: am654-base-board: Disable mcan nodes Aswath Govindraju
2021-07-20 14:16 ` [PATCH 3/6] arm64: dts: ti: k3-j721e: Add support for MCAN nodes Aswath Govindraju
2021-07-20 14:54 ` Marc Kleine-Budde
2021-07-21 7:48 ` Aswath Govindraju [this message]
2021-07-26 7:43 ` Aswath Govindraju
2021-07-20 14:16 ` [PATCH 4/6] arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan nodes Aswath Govindraju
2021-07-20 14:16 ` [PATCH 5/6] arm64: dts: ti: k3-am64-main: Add support for MCAN Aswath Govindraju
2021-07-20 14:16 ` [PATCH 6/6] arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan nodes in EVM and disable them on SK Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ff222b-e751-1586-b774-4e55bfe5e017@ti.com \
--to=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=mkl@pengutronix.de \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).