From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9998BC432C3 for ; Wed, 13 Nov 2019 21:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65DB0206D3 for ; Wed, 13 Nov 2019 21:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbfKMVBv (ORCPT ); Wed, 13 Nov 2019 16:01:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:41284 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726162AbfKMVBu (ORCPT ); Wed, 13 Nov 2019 16:01:50 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 217D8B1B1; Wed, 13 Nov 2019 21:01:49 +0000 (UTC) Subject: Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB To: James Tai Cc: Rob Herring , Mark Rutland , "linux-arm-kernel@lists.infradead.org" , 'DTML' , "linux-kernel@vger.kernel.org" , "linux-realtek-soc@lists.infradead.org" References: From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: <420ad4a0-a583-c3b9-5ce6-ff4d12e71511@suse.de> Date: Wed, 13 Nov 2019 22:01:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am 12.11.19 um 16:45 schrieb James Tai: > Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB. > > Signed-off-by: James Tai > --- This is missing the requested change log here: What changed since v2? If nothing changed, then you should've inserted my Reviewed-by from v2 before your Signed-off-by. Regards, Andreas > Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml > index ab59de17152d..2444eff2c3d5 100644 > --- a/Documentation/devicetree/bindings/arm/realtek.yaml > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml > @@ -33,4 +33,10 @@ properties: > - enum: > - synology,ds418 # Synology DiskStation DS418 > - const: realtek,rtd1296 > + > + # RTD1619 SoC based boards > + - items: > + - enum: > + - realtek,mjolnir # Realtek Mjolnir EVB > + - const: realtek,rtd1619 > ... > -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)