From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 719F1C4320A for ; Thu, 19 Aug 2021 22:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53F4961106 for ; Thu, 19 Aug 2021 22:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236719AbhHSWVO (ORCPT ); Thu, 19 Aug 2021 18:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236194AbhHSWVN (ORCPT ); Thu, 19 Aug 2021 18:21:13 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A57A0C061575; Thu, 19 Aug 2021 15:20:36 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id g13so16062749lfj.12; Thu, 19 Aug 2021 15:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cSioMNug0d6kxUexh1FC9hTGrtcP9xpdjQR0XQQ6CYo=; b=J3VpzNeE7GqDLaNcadrCTNd6cyZfYXW7ces/SuDyrw1d/28XcNn6N+DzEWmGnDD/tQ SoLjonmdEv+K67l7YB0f4xQ305y80qihUAThFt01+KBxrDINvGkhPcmCvtlU5sHPBDbx M71O17tNhqPr+OmAN9VOz+4Q7pIBIEyoj6SH0ySrJLRtzsTWwdbnVhskZKjVbRPHRaWm +GaOVUAE0cvv6+nA+ln7XoB+9psFnKu9U3jrYuDGEC/pYeGQBmT2Xm3y538F/wiQgagE srBA+yPJ+iPcl2RL23Y4diEfalcBHPDOPAb4qZl7q12ixhhyPtL63uHAQVl2E6t4EK21 t4gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cSioMNug0d6kxUexh1FC9hTGrtcP9xpdjQR0XQQ6CYo=; b=lHxzn9lc2vVlM1OZ8wZi5g1psXJxvpAkA3WBosajap4jFbTwjWXmILHuVmpoAp4vPA Sp3dKZ8eaElmuwyMrlkyFlgDMKx7Gh95Gg1DjiDrdh+o5HV1fEhT7S505eAKg2akZtLs x44HIqhT4QgqhMVNBAoMKVnXwPYxen1IZcdSzrT9MU7D6CqMGX8JNWv9x5vgzS0TL1rY MRX746nL8OO2ThvEoodLXOz5nl7+E4VyBVTaP1xLNcevXXK51ACaJSpFTb7JNGZdQQ86 Bx1ZbCKDKRnOvi3Qi0UeAzRd3ir8rUjWizV/dMWUhG2sASEKy7kAzDovv8mdRxEs0Deq FCGQ== X-Gm-Message-State: AOAM533bDFERqpl9zvHycMIedaazLrzIwOFoM6T1LvaIYPBNM/CUcXMx bBYnbc7eUeAfQ6XiVzm/b8MIzDSVGM8= X-Google-Smtp-Source: ABdhPJxJWs7Kxo/s8N+hb+4RWNHipznlH5BHUAb+HUpiZwCTMet2wXRVLZZrxtwaXHrGmtOIkJjuVA== X-Received: by 2002:a05:6512:38a1:: with SMTP id o1mr11689501lft.606.1629411634907; Thu, 19 Aug 2021 15:20:34 -0700 (PDT) Received: from [192.168.2.145] (46-138-120-72.dynamic.spd-mgts.ru. [46.138.120.72]) by smtp.googlemail.com with ESMTPSA id w14sm433095lfk.161.2021.08.19.15.20.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Aug 2021 15:20:34 -0700 (PDT) Subject: Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node To: Thierry Reding Cc: Rob Herring , Jonathan Hunter , Ulf Hansson , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Michael Turquette , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20210817012754.8710-1-digetx@gmail.com> <20210817012754.8710-7-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <43f0c69a-c62d-5d36-ac59-8ce7513e9496@gmail.com> Date: Fri, 20 Aug 2021 01:20:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 19.08.2021 19:31, Thierry Reding пишет: >>>>> Also, I don't think the tegra- prefix is necessary here. The parent node >>>>> is already identified as Tegra via the compatible string. >>>>> >>>>> In the case of CAR, I'd imagine something like: >>>>> >>>>> clocks { >>>>> sclk { >>>>> operating-points-v2 = <&opp_table>; >>>>> power-domains = <&domain>; >>>>> }; >>>>> }; >>>>> >>>>> Now you've only got the bare minimum in here that you actually add. All >>>>> the other data that you used to have is simply derived from the parent. >>>> 'clocks' is already a generic keyword in DT. It's probably not okay to >>>> redefine it. >>> "clocks" is not a generic keyword. It's the name of a property and given >>> that we're talking about the clock provider here, it doesn't need a >>> clocks property of its own, so it should be fine to use that for the >>> node. >> I'm curious what Rob thinks about it. Rob, does this sound okay to you? > Another alternative would be to omit that level altogether and just make > sclk and siblings direct children of the CAR node. That can be done.