From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Oshri Alkobi <oshrialkoby85@gmail.com>,
Alexander Steffen <Alexander.Steffen@infineon.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de,
jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org,
oshri.alkoby@nuvoton.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
gcwilson@us.ibm.com, kgoldman@us.ibm.com,
nayna@linux.vnet.ibm.com, dan.morav@nuvoton.com,
tomer.maimon@nuvoton.com
Subject: Re: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp
Date: Fri, 05 Jul 2019 14:28:07 +0300 [thread overview]
Message-ID: <45603af2fc8374a90ef9e81a67083395cc9c7190.camel@linux.intel.com> (raw)
In-Reply-To: <CAM9mBwJC2QD5-gV1eJUDzC2Fnnugr-oCZCoaH2sT_7ktFDkS-Q@mail.gmail.com>
On Thu, 2019-07-04 at 12:48 -0500, Oshri Alkobi wrote:
> Alex, Jarkko, thank you very much for your feedbacks!
Please configure your email client to use plain text.
> I totally agree, there are some duplications that can be common, indeed it
> will require some work in tpm_tis_core.
> Since I believe it is not going to happen soon, I would suggest to examine
> what duplications can currently be dropped from the new driver, so the kernel
> will support the PTP I2C interface in the meantime.
> I will appreciate getting ideas about any tpm_tis_core logic that currently
> can be used as is by the new drive.
I rather wait for a solution that integrates with our mature stack for
TIS (or these days FIFO) than integrate something half-baked. If you
want something in, please do right things right.
What you are proposing would mean maintaining duplicate stacks forever.
> Since the TIS is an old specification that mostly defines FIFO for TPM1.2 I
> would say the name tpm_tis_i2c does not completely reflect its goal. However
> we really don't have any problem with any name that the group will agree on.
> Does tpm_ptp_i2c sound better than the current name?
Absolutely not going to use that name. The naming convention is what
it is for other drivers that are adapt tpm_tis_core to different HW
interfaces.
/Jarkko
next prev parent reply other threads:[~2019-07-05 11:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 15:13 [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp Oshri Alkoby
2019-06-28 15:13 ` [PATCH v2 1/2] dt-bindings: tpm: add the TPM I2C PTP device tree binding documentation Oshri Alkoby
2019-06-28 15:13 ` [PATCH v2 2/2] char: tpm: add new driver for tpm i2c ptp Oshri Alkoby
2019-07-04 8:43 ` [PATCH v2 0/2] " Jarkko Sakkinen
2019-07-04 11:29 ` Alexander Steffen
2019-07-04 17:48 ` Oshri Alkobi
2019-07-05 11:28 ` Jarkko Sakkinen [this message]
[not found] ` <6e7ff1b958d84f6e8e585fd3273ef295@NTILML02.nuvoton.com>
2019-07-15 8:08 ` Tomer Maimon
2019-07-15 9:45 ` Jarkko Sakkinen
2019-07-18 12:51 ` Eyal.Cohen
2019-07-18 17:10 ` Alexander Steffen
2019-07-30 8:39 ` Benoit HOUYERE
2019-07-30 17:42 ` Alexander Steffen
2019-09-06 12:16 ` Benoit HOUYERE
2019-08-15 17:03 ` Oshri Alkobi
2019-08-16 16:12 ` Alexander Steffen
2019-08-25 11:25 ` Oshri Alkobi
2019-07-17 7:48 ` Alexander Steffen
2019-07-05 11:15 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45603af2fc8374a90ef9e81a67083395cc9c7190.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=arnd@arndb.de \
--cc=dan.morav@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nayna@linux.vnet.ibm.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=tomer.maimon@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).