From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 2/3] iio:adc:ad7476: Handle the different regulators used by various parts.
Date: Fri, 2 Apr 2021 10:35:17 +0200 [thread overview]
Message-ID: <45bfed22-1864-eb3a-f370-c6a38a9de414@metafoo.de> (raw)
In-Reply-To: <20210401171759.318140-3-jic23@kernel.org>
On 4/1/21 7:17 PM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Not all of the parts supported by this driver use single supply.
> Hence we add chip_info fields to say what additional supplies exist
> and in the case of vref, ensure that is used for the reference voltage
> rather than vcc.
>
> Tested using really simple QEMU model and some fixed regulators.
>
> The devm_add_action_or_reset() callback is changed to take the
> regulator as it's parameter so we can use one callback for all the
> different regulators without having to store pointers to them in
> the iio_priv() structure.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
Looks good.
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
There is one special case that is currently not handled. The AD7091R can
either use its internal reference, or an external reference.
At the moment the driver sets neither has_vref nor int_vref_uv.
next prev parent reply other threads:[~2021-04-02 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 17:17 [PATCH 0/3] iio:adc:ad7476: Fix, regulator support and binding doc Jonathan Cameron
2021-04-01 17:17 ` [PATCH 1/3] iio:adc:ad7476: Fix remove handling Jonathan Cameron
2021-04-02 7:34 ` Alexandru Ardelean
2021-04-05 15:01 ` Jonathan Cameron
2021-04-01 17:17 ` [PATCH 2/3] iio:adc:ad7476: Handle the different regulators used by various parts Jonathan Cameron
2021-04-02 8:35 ` Lars-Peter Clausen [this message]
2021-04-05 16:02 ` Jonathan Cameron
2021-04-01 17:17 ` [PATCH 3/3] dt-bindings:iio:adc:adi,ad7474: Add missing binding document Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45bfed22-1864-eb3a-f370-c6a38a9de414@metafoo.de \
--to=lars@metafoo.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).