From: Marcel Holtmann <marcel@holtmann.org>
To: David Lechner <david@lechnology.com>
Cc: devicetree <devicetree@vger.kernel.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Network Development <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Bluetooth: hci_ll: Get BD address from NVMEM
Date: Tue, 12 Dec 2017 23:52:53 +0100 [thread overview]
Message-ID: <4646D298-A5A9-486D-8F7B-27D05BE2572A@holtmann.org> (raw)
In-Reply-To: <1513115958-23761-1-git-send-email-david@lechnology.com>
Hi David,
> This series adds supporting getting the BD address from a NVMEM provider
> for "LL" HCI controllers (Texas Instruments).
>
> v3 changes:
> * Additional comments on why swapping bytes is needed.
> * Fixed comment style and trailing whitespace.
> * Rework error handling for nvmem cell code.
>
> v2 changes:
> * Fixed typos in dt-bindings
> * Use "bd-address" instead of "mac-address"
> * Updated dt-bindings to specify the byte order of "bd-address"
> * New patch "Bluetooth: hci_ll: add support for setting public address"
> * Dropped patch "Bluetooth: hci_ll: add constant for vendor-specific command"
> that is already in bluetooth-next
> * Rework error handling
> * Use bdaddr_t, bacmp and other bluetooth utils
>
> David Lechner (3):
> Bluetooth: hci_ll: add support for setting public address
> dt-bindings: Add optional nvmem BD address bindings to ti,wlink-st
> Bluetooth: hci_ll: Add optional nvmem BD address source
>
> .../devicetree/bindings/net/ti,wilink-st.txt | 5 ++
> drivers/bluetooth/hci_ll.c | 77 ++++++++++++++++++++++
> 2 files changed, 82 insertions(+)
I applied to first 2 patches to bluetooth-next tree, but the 3rd is throwing a warning.
CC drivers/bluetooth/hci_ll.o
drivers/bluetooth/hci_ll.c: In function ‘hci_ti_probe’:
drivers/bluetooth/hci_ll.c:814:41: error: passing argument 2 of ‘nvmem_cell_read’ from incompatible pointer type [-Werror=incompatible-pointer-types]
bdaddr = nvmem_cell_read(bdaddr_cell, &len);
^
In file included from drivers/bluetooth/hci_ll.c:56:0:
./include/linux/nvmem-consumer.h:81:21: note: expected ‘size_t * {aka long unsigned int *}’ but argument is of type ‘int *’
static inline void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
^~~~~~~~~~~~~~~
Regards
Marcel
prev parent reply other threads:[~2017-12-12 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 21:59 [PATCH v3 0/3] Bluetooth: hci_ll: Get BD address from NVMEM David Lechner
2017-12-12 21:59 ` [PATCH v3 1/3] Bluetooth: hci_ll: add support for setting public address David Lechner
[not found] ` <1513115958-23761-1-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-12 21:59 ` [PATCH v3 2/3] dt-bindings: Add optional nvmem BD address bindings to ti,wlink-st David Lechner
2017-12-12 21:59 ` [PATCH] Bluetooth: hci_ll: Add optional nvmem BD address source David Lechner
2017-12-12 22:52 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4646D298-A5A9-486D-8F7B-27D05BE2572A@holtmann.org \
--to=marcel@holtmann.org \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).