Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro

From: Tobias Schramm <t.schramm@manjaro.org>
To: Johan Jonker <jbx6244@gmail.com>,
	Tobias Schramm <t.schramm@manjaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Andy Yan <andy.yan@rock-chips.com>
Cc: Douglas Anderson <dianders@chromium.org>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Alexis Ballier <aballier@gentoo.org>,
	Matthias Kaehlcke <mka@chromium.org>, Nick Xie <nick@khadas.com>,
	Kever Yang <kever.yang@rock-chips.com>,
	Vivek Unune <npcomplete13@gmail.com>,
	Katsuhiro Suzuki <katsuhiro@katsuster.net>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Vasily Khoruzhick <anarsoul@gmail.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Wed, 4 Mar 2020 19:24:41 +0100	[thread overview]
Message-ID: <46a66389-c709-2c16-dd9a-f7fd6371a768@manjaro.org> (raw)
In-Reply-To: <bcc2c8d4-a2cd-58c1-89af-e42439f8f344@gmail.com>

Hi Johan,

thanks for the additional feedback. I'll send a v4 with your fixes included.

>> +		partitions {
>> +			compatible = "fixed-partitions";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			loader@8000 {
>> +				label = "loader";
>> +				reg = <0x0 0x3F8000>;
>> +			};
>> +
>> +			env@3f8000 {
>> +				label = "env";
>> +				reg = <0x3F8000 0x8000>;
>> +			};
>> +
>> +			vendor@7c0000 {
>> +				label = "vendor";
>> +				reg = <0x7C0000 0x40000>;
>> +			};
>> +		};
> 
> Partitions are normaly up to the user and should not be included to dts
> files,
> else could you explain why we need this exception?
> 
Right. I don't see any reason why we would need to keep it either. I'll
remove it.

Tobias