From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>, linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mars Cheng <mars.cheng@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Nicolas Boichat <drinkcat@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana
Date: Thu, 9 Jan 2020 15:26:17 +0100 [thread overview]
Message-ID: <46ccc713-5951-62ee-1909-f572772217c2@collabora.com> (raw)
In-Reply-To: <20200109101042.201500-2-hsinyi@chromium.org>
Hi Hsin-Yi,
Thanks for sending this patch upstream, one comment below ...
On 9/1/20 11:10, Hsin-Yi Wang wrote:
> Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173
> SoC.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 4043c5046441..a27b22f264a2 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -86,6 +86,24 @@ properties:
> - const: mediatek,mt8135
> - items:
> - enum:
> + - google,elm
> + - google,elm-rev1
> + - google,elm-rev2
> + - google,elm-rev3
> + - google,elm-rev4
> + - google,elm-rev5
> + - google,elm-rev6
> + - google,elm-rev7
> + - google,elm-rev8
Did you run dtbs_check [1] after having patch 2 applied? I think that will
trigger some errors. I am not sure if this should be a const instead of an enum
like we have in rockchip.yaml?
[1] make ARCH=arm64
DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/mediatek.yaml dtbs_check
Thanks,
Enric
> + - google,hana
> + - google,hana-rev0
> + - google,hana-rev1
> + - google,hana-rev2
> + - google,hana-rev3
> + - google,hana-rev4
> + - google,hana-rev5
> + - google,hana-rev6
> + - google,hana-rev7
> - mediatek,mt8173-evb
> - const: mediatek,mt8173
> - items:
>
next prev parent reply other threads:[~2020-01-09 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 10:10 [PATCH 0/2] Add mt8173 elm and hana board Hsin-Yi Wang
2020-01-09 10:10 ` [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana Hsin-Yi Wang
2020-01-09 14:26 ` Enric Balletbo i Serra [this message]
2020-01-09 10:10 ` [PATCH 2/2] arm64: dts: mediatek: add mt8173 elm and hana board Hsin-Yi Wang
2020-01-09 15:11 ` Enric Balletbo i Serra
2020-01-10 4:46 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ccc713-5951-62ee-1909-f572772217c2@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=drinkcat@chromium.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mars.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).