From: Matthias Brugger <matthias.bgg@gmail.com>
To: Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: mkorpershoek@baylibre.com, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: mediatek: fix reset GPIO level on pumpkin
Date: Thu, 1 Apr 2021 11:39:51 +0200 [thread overview]
Message-ID: <46f49f9e-20a6-ea3b-a3c2-2249cdd3613b@gmail.com> (raw)
In-Reply-To: <20210223221826.2063911-1-fparent@baylibre.com>
On 23/02/2021 23:18, Fabien Parent wrote:
> The tca6416 chip is active low. Fix the reset-gpios value.
>
> Fixes: e2a8fa1e0faa ("arm64: dts: mediatek: fix tca6416 reset GPIOs in pumpkin")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Applied to v5.12-next/dts64
Thanks!
> ---
> arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index 63fd70086bb8..9f27e7ed5e22 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -56,7 +56,7 @@ &i2c0 {
> tca6416: gpio@20 {
> compatible = "ti,tca6416";
> reg = <0x20>;
> - reset-gpios = <&pio 65 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pio 65 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&tca6416_pins>;
>
>
prev parent reply other threads:[~2021-04-01 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 22:18 [PATCH] arm64: dts: mediatek: fix reset GPIO level on pumpkin Fabien Parent
2021-04-01 9:39 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46f49f9e-20a6-ea3b-a3c2-2249cdd3613b@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mkorpershoek@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).