From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 05/15] memory: tegra: Do not handle spurious interrupts
Date: Tue, 20 Feb 2018 19:25:18 +0300 [thread overview]
Message-ID: <48059f0e134d779e65fd92938e4162b191e400de.1519141896.git.digetx@gmail.com> (raw)
In-Reply-To: <cover.1519141896.git.digetx@gmail.com>
In-Reply-To: <cover.1519141896.git.digetx@gmail.com>
The ISR reads interrupts-enable mask, but doesn't utilize it. Apply the
mask to the interrupt status and don't handle interrupts that MC driver
haven't asked for. Kernel would disable spurious MC IRQ and report the
error. This would happen only in a case of a very severe bug.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/tegra/mc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index a4803ac192bb..d2005b995821 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -252,8 +252,11 @@ static irqreturn_t tegra_mc_irq(int irq, void *data)
unsigned int bit;
/* mask all interrupts to avoid flooding */
- status = mc_readl(mc, MC_INTSTATUS);
mask = mc_readl(mc, MC_INTMASK);
+ status = mc_readl(mc, MC_INTSTATUS) & mask;
+
+ if (!status)
+ return IRQ_NONE;
for_each_set_bit(bit, &status, 32) {
const char *error = status_names[bit] ?: "unknown";
--
2.16.1
next prev parent reply other threads:[~2018-02-20 16:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 16:25 [PATCH v3 00/15] Memory controller hot reset Dmitry Osipenko
2018-02-20 16:25 ` [PATCH v3 01/15] dt-bindings: arm: tegra: Remove duplicated Tegra30+ MC binding Dmitry Osipenko
2018-03-01 21:53 ` Rob Herring
2018-02-20 16:25 ` [PATCH v3 02/15] dt-bindings: memory: tegra: Document #reset-cells property of the Tegra30 MC Dmitry Osipenko
2018-03-01 21:54 ` Rob Herring
2018-02-20 16:25 ` [PATCH v3 03/15] dt-bindings: arm: tegra: Document #reset-cells property of the Tegra20 MC Dmitry Osipenko
2018-03-01 21:55 ` Rob Herring
2018-02-20 16:25 ` [PATCH v3 04/15] dt-bindings: memory: tegra: Add hot resets definitions Dmitry Osipenko
2018-03-01 21:56 ` Rob Herring
2018-02-20 16:25 ` Dmitry Osipenko [this message]
2018-02-20 16:25 ` [PATCH v3 06/15] memory: tegra: Setup interrupts mask before requesting IRQ Dmitry Osipenko
2018-02-20 16:25 ` [PATCH v3 07/15] memory: tegra: Apply interrupts mask per SoC Dmitry Osipenko
2018-02-20 16:25 ` [PATCH v3 08/15] memory: tegra: Remove unused headers inclusions Dmitry Osipenko
2018-02-20 16:25 ` [PATCH v3 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 10/15] memory: tegra: Introduce memory client hot reset Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 11/15] memory: tegra: Add Tegra210 memory controller hot resets Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 12/15] memory: tegra: Add Tegra124 " Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 13/15] memory: tegra: Add Tegra114 " Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 14/15] memory: tegra: Add Tegra30 " Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 15/15] memory: tegra: Add Tegra20 " Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48059f0e134d779e65fd92938e4162b191e400de.1519141896.git.digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).