From: David Mosberger-Tang <davidm@egauge.net>
To: Rob Herring <robh@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
netdev <netdev@vger.kernel.org>,
Adham Abozaeid <adham.abozaeid@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Ajay Singh <ajay.kathat@microchip.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
devicetree@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v4 2/2] wilc1000: Document enable-gpios and reset-gpios properties
Date: Tue, 14 Dec 2021 19:53:42 -0700 [thread overview]
Message-ID: <4a571870f8d95432e53fcce7bcb34e2b41632aef.camel@egauge.net> (raw)
In-Reply-To: <CAL_JsqLFyaAvTGQJc0GjYbXwyhpmfpRm3_rkGopD8cz6-ZX5zw@mail.gmail.com>
On Tue, 2021-12-14 at 17:54 -0600, Rob Herring wrote:
> On Tue, Dec 14, 2021 at 5:30 PM David Mosberger-Tang <davidm@egauge.net> wrote:
> > On Tue, 2021-12-14 at 14:04 -0600, Rob Herring wrote:
> > >
> > > dtschema/dtc warnings/errors:
> > > Error: Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.example.dts:30.37-38 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.example.dt.yaml] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1413: dt_binding_check] Error 2
> >
> > So this error appears due to GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW in these
> > lines:
> >
> > enable-gpios = <&pioA 5 GPIO_ACTIVE_HIGH>;
> > reset-gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> >
> > I can replace those with 0 and 1 respectively, but I doubt a lot of people would
> > recognize what those integers standard for. Is there a better way to get this
> > to pass?
>
> Include the header(s) you use in the example.
Huh, that works, thanks!
--david
prev parent reply other threads:[~2021-12-15 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 16:33 [PATCH v4 0/2] Add reset/enable GPIO support to SPI driver David Mosberger-Tang
2021-12-14 16:33 ` [PATCH v4 1/2] wilc1000: " David Mosberger-Tang
2021-12-14 16:33 ` [PATCH v4 2/2] wilc1000: Document enable-gpios and reset-gpios properties David Mosberger-Tang
2021-12-14 20:04 ` Rob Herring
2021-12-14 23:30 ` David Mosberger-Tang
2021-12-14 23:54 ` Rob Herring
2021-12-15 2:53 ` David Mosberger-Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a571870f8d95432e53fcce7bcb34e2b41632aef.camel@egauge.net \
--to=davidm@egauge.net \
--cc=adham.abozaeid@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).