From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: rafael@kernel.org, Zhang Rui <rui.zhang@intel.com>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Mark Rutland <mark.rutland@arm.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] dt-bindings: thermal: Add the idle cooling device
Date: Sun, 12 Apr 2020 20:08:15 +0200 [thread overview]
Message-ID: <4ca7b16f-c0b0-23c3-08a3-8731c2bf5f35@linaro.org> (raw)
In-Reply-To: <20200410165915.GA12708@bogus>
Hi Rob,
thanks for the review.
On 10/04/2020 18:59, Rob Herring wrote:
> On Mon, Mar 30, 2020 at 12:03:18AM +0200, Daniel Lezcano wrote:
[ ... ]
>> + '#cooling-cells':
>> + const: 2
>> + description: |
>> + Must be 2, in order to specify minimum and maximum cooling state used in
>> + the cooling-maps reference. The first cell is the minimum cooling state
>> + and the second cell is the maximum cooling state requested.
>> +
>> + duration:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + The idle duration in microsecond the device begins to cool down.
>> +
>> + latency:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + The exit latency constraint in microsecond for the injected
>> + idle state for the device.
>
> Both of these should have unit suffix. And then they don't need a type
> def.
Do you mean I should remove the $ref:
/schemas/types.yaml#/definitions/uint32 and change the name to
duration_us and latency_us ?
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2020-04-12 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200329220324.8785-1-daniel.lezcano@linaro.org>
2020-03-29 22:03 ` [PATCH 2/4] dt-bindings: thermal: Add the idle cooling device Daniel Lezcano
2020-04-07 13:36 ` Daniel Lezcano
2020-04-07 14:09 ` Amit Kucheria
2020-04-10 16:59 ` Rob Herring
2020-04-12 18:08 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca7b16f-c0b0-23c3-08a3-8731c2bf5f35@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).