From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A1EC43603 for ; Fri, 13 Dec 2019 04:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B84FC206D8 for ; Fri, 13 Dec 2019 04:22:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="IU3xezhz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731436AbfLMEWg (ORCPT ); Thu, 12 Dec 2019 23:22:36 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:22386 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731357AbfLMEWg (ORCPT ); Thu, 12 Dec 2019 23:22:36 -0500 Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20191213042232epoutp0185382c760fcf388fd21de6a4090d6024~f04KJ9pFb3082930829epoutp01o for ; Fri, 13 Dec 2019 04:22:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20191213042232epoutp0185382c760fcf388fd21de6a4090d6024~f04KJ9pFb3082930829epoutp01o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1576210952; bh=TxyKw3Ul1g+AAGrympx1fMmccHpakDh6s6Hu8YFBF/U=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=IU3xezhzSZFstu175bUEt9eUVC8whaCKN5YWmQh20iqxIyrfsxkngf7a2wOMtGbZk rL7wDwnJsNAa9EK+WdRL7/DFas0T+uifpl7Z7DrAIQUuUFdHjBjc1eExwZtid72cRC ixEsDl2nZqbGK3AzvPudQ5HbOXj7rzpJ2SIz9q1U= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20191213042231epcas1p339e826de73063a8cd62b72ffb5b80efa~f04JJHR-D2676926769epcas1p3J; Fri, 13 Dec 2019 04:22:31 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.40.157]) by epsnrtp2.localdomain (Postfix) with ESMTP id 47YyDz6yJHzMqYkx; Fri, 13 Dec 2019 04:22:27 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 89.68.52419.30213FD5; Fri, 13 Dec 2019 13:22:27 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20191213042227epcas1p4b1e09e0001edc5da8466eb98debb6c98~f04F6-OY42197221972epcas1p4N; Fri, 13 Dec 2019 04:22:27 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20191213042227epsmtrp1026ea16fd654083f10803ae88241378d~f04F5zMOQ2855928559epsmtrp1z; Fri, 13 Dec 2019 04:22:27 +0000 (GMT) X-AuditID: b6c32a37-5b7ff7000001ccc3-cc-5df31203b494 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 40.0C.06569.30213FD5; Fri, 13 Dec 2019 13:22:27 +0900 (KST) Received: from [10.113.221.102] (unknown [10.113.221.102]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20191213042227epsmtip1d445af99ba0f9e76c2a94067e5097fc9~f04FdkB4z1095810958epsmtip1K; Fri, 13 Dec 2019 04:22:27 +0000 (GMT) Subject: Re: [PATCH RFC v6 3/9] PM / devfreq: imx: Register interconnect device To: Leonard Crestez , Georgi Djakov , Rob Herring Cc: =?UTF-8?B?QXJ0dXIgxZp3aWdvxYQ=?= , Alexandre Bailon , "Rafael J. Wysocki" , Jacky Bai , Anson Huang , Abel Vesa , Krzysztof Kozlowski , MyungJoo Ham , Kyungmin Park , Saravana Kannan , Mark Rutland , Viresh Kumar , Shawn Guo , Dong Aisheng , Fabio Estevam , Stephen Boyd , Michael Turquette , Matthias Kaehlcke , Angus Ainslie , Martin Kepplinger , Silvano di Ninno , linux-pm@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Chanwoo Choi Organization: Samsung Electronics Message-ID: <4d45cd39-24df-1714-0a27-5019c1367063@samsung.com> Date: Fri, 13 Dec 2019 13:28:56 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01TbUxTZxTee297e9FV7iod71g28br9sAvQWgsvizjN1N05s7CwD7OE1Ru4 o4R+pbclcyyDMWXS6MQYYvhwuAhLW9mktWLp+LLCCE6LzKx+dEwDxOniymbFdDjZ2t6a8e85 5zzPed5z3hwSl/VJsshKo5WzGFk9TSwT9Z5bm5eDy6KlykV/AQr8cFqC5n88D9A3P40CdL/Z j6OZG2GAzrSUoY6RoBi5T4VF6MiAh0Cu5j4RmpjokaCL9XclyDH1lxh5ZkJiZF9w4ih6YASg riuTGAo5DolRtGcGoMnzW1H4MweBTgTPEujo/WYc7R0YkSB74BGBFkNuEbrtzURdx0M4cs8z m55jmu0OwHR/1Q2Yuat7JUxb3aSIOeaxMR5XI8H8EuonmFOdtYw74sOYs5F+jDn4SMksnJMz X3pdgIl6ni9e8X7VBh3HlnOWbM5YZiqvNFYU0W+UaF/VavKVqhxVISqgs42sgSuit+woztlW qY9vhs6uZvW2eKqY5Xk6b+MGi8lm5bJ1Jt5aRHPmcr250JzLswbeZqzILTMZXlYples0ceKu Kt3D+gXCvJj1UXioCa8Dl+V2kEZCaj288Oe3mB0sI2WUD8DD3r9TwT0AI22dQAgeADg8FcQe S77vu4ALhQEAnR2DKdYcgNEHg6IEayX1FpxoHJUkcAZVA5su1if74tQ1CRweTSjSSIJSwKHb V4kETqdWw59jM8m8lNoIo9PdSbGIehG6Wq8lOXLqXTjeuyfFeQqOt8wmzdKoD2BL254kB6cy 4fXZDkzAq+CZP9qTT4XUMAljjs54UzIebIFB33ZhnJXw9zGvRMBZ8M7BhhSugc7xEULQ7gPQ O3RJLBTUcKjrMJbog1Nr4Ul/npBeDfseHgWC7woYmd8vFqykcF+DTKCsgZdvTqW2+Aw8/kUj 0QTo1iXTtC6ZoHXJBK3/mx0DIhd4mjPzhgqOV5nVS7/bA5JnoyjwgZ7gjgCgSEA/KXWw90pl Yraa320IAEjidIb0lU/iKWk5u/tjzmLSWmx6jg8ATXzZh/AseZkpfoRGq1alWadWq9F6Vb5G paIzpWRsslRGVbBWrorjzJzlsQ4j07LqgKJr7rW3l49j6Xd5eUl+Hq+9Hhv1nZTNdO/0b76R Xrtpzu18VqpRvO76t6H90xps+de/ndg5ffO7hpc+922PbA0re9/5B7OfXmMtvIVzzjdLtvnr CN2dfsr03oEr1b/e2gUvxaYd/vZVHkdzxmDj2Au16v25VZEPHQ7b7Ga1ceyJNlrE61iVArfw 7H+4DKCtTAQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeXfOzo7i8rhpvhopDiJYZhqJLyHWF/WgdP0QZHhZelDRTdlR SyvytsBhpZmZs9Rw1ppCblpqKuJ03kptRsu8EDgpwTRqGjIvpRuB3348/9//eb48JCZQc73J VFkWI5dJ0kWEM/6mX+RzFBNYYwO76vyQYfA1D629GwXo+aQRoNXKtxiyfJ0BqL06EdUNjHOR rnUGR1U9egJpKztxNDHRwkNjhT94SDP3i4v0FjMXKW0vMWS9OwBQ42cTB5k15VxkbbEAZBoN RzMFGgI1jfcR6OlqJYYUPQM8pDRsEWjbrMPRYpsnamwwY0i3Rp8+SFcqNYBurm0G9M8pBY+u yTfhdL0+m9ZrSwh61txN0K3q27RupYND9610c+j7W4G0rd+DvtemBbRV73N+X4xzaBKTnprD yI+FJTinbBTaiMxt7+szvWVYPvjooQROJKROwK7O95gSOJMCqgvAmr9NwBF4wUcm405A7rAQ 9vezDmcZwBezk/iuI6QuwIkSI2+X3akbcPPbkH0RRs3x4OPSIY6jMQ+g0jrO3bUISgx7F6eI XXal/OCndYv9Gp8Kg9b5ZvsmnDoEtaovdseDugQ71RaOw3GDI9UL9stOVBysrim2Oxh1GG7W TmIO9oTTC3UcB/vC9uUnWBkQqvbUVXsqqj0V1Z5KPcC1wIvJZKXJUjYo87iMuRbASqRstiw5 IDFDqgf23xGLO8DwcLwBUCQQufA1kt+xAq4kh82VGgAkMZE7/9TNnRE/SZKbx8gz4uXZ6Qxr AAdIXOTJ980YvCygkiVZTBrDZDLy/ymHdPLOB8JgrkIhTSVsIwF5Yx9G1hUwsurq2bacalRw MUIR/2fCz3TE9UFzVu8VXfFwWqiwNLKr6AzQnKvwCylfEoRHPJNNBxMB/ieji+LEd6LrO5cS XKRZoWn1RUPlQGUxWmL8axKjHl6IuZUTXsHZb1RH2TZWG9x81C4RHtbvr2pDRDibIgkSY3JW 8g9oHmRpNwMAAA== X-CMS-MailID: 20191213042227epcas1p4b1e09e0001edc5da8466eb98debb6c98 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20191114201049epcas5p370853a1d78584bf00d8493ce20320bf9 References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 11/15/19 5:09 AM, Leonard Crestez wrote: > There is no single device which can represent the imx interconnect. > Instead of adding a virtual one just make the main &noc act as the > global interconnect provider. > > The imx interconnect provider driver will scale the NOC and DDRC based > on bandwidth request. More scalable nodes can be added in the future, > for example for audio/display/vpu/gpu NICs. > > Signed-off-by: Leonard Crestez > --- > drivers/devfreq/imx-devfreq.c | 37 +++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/drivers/devfreq/imx-devfreq.c b/drivers/devfreq/imx-devfreq.c > index 620b344e87aa..585d340c0f6e 100644 > --- a/drivers/devfreq/imx-devfreq.c > +++ b/drivers/devfreq/imx-devfreq.c > @@ -15,10 +15,11 @@ > struct imx_devfreq { > struct devfreq_dev_profile profile; > struct devfreq *devfreq; > struct clk *clk; > struct devfreq_passive_data passive_data; > + struct platform_device *icc_pdev; > }; > > static int imx_devfreq_target(struct device *dev, > unsigned long *freq, u32 flags) > { > @@ -60,11 +61,40 @@ static int imx_devfreq_get_dev_status(struct device *dev, > return 0; > } > > static void imx_devfreq_exit(struct device *dev) > { > + struct imx_devfreq *priv = dev_get_drvdata(dev); > + > dev_pm_opp_of_remove_table(dev); > + platform_device_unregister(priv->icc_pdev); > +} > + > +/* imx_devfreq_init_icc() - register matching icc provider if required */ > +static int imx_devfreq_init_icc(struct device *dev) > +{ > + struct imx_devfreq *priv = dev_get_drvdata(dev); > + const char *icc_driver_name; > + > + if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) > + return 0; It is not proper to check the enable state of CONFIG_INTERCONNECT_IMX configuration on device driver. Why don't you add the 'select CONFIG_INTERCONNECT_IMX' on Kconfig? > + if (!of_get_property(dev->of_node, "#interconnect-cells", 0)) > + return 0; > + > + icc_driver_name = of_device_get_match_data(dev); > + if (!icc_driver_name) > + return 0; > + > + priv->icc_pdev = platform_device_register_data( > + dev, icc_driver_name, 0, NULL, 0); > + if (IS_ERR(priv->icc_pdev)) { > + dev_err(dev, "failed to register icc provider %s: %ld\n", > + icc_driver_name, PTR_ERR(priv->devfreq)); > + return PTR_ERR(priv->devfreq); > + } > + > + return 0; > } > > static int imx_devfreq_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -120,18 +150,25 @@ static int imx_devfreq_probe(struct platform_device *pdev) > ret = PTR_ERR(priv->devfreq); > dev_err(dev, "failed to add devfreq device: %d\n", ret); > goto err; > } > > + ret = imx_devfreq_init_icc(dev); > + if (ret) > + goto err; > + > return 0; > > err: > dev_pm_opp_of_remove_table(dev); > return ret; > } > > static const struct of_device_id imx_devfreq_of_match[] = { > + { .compatible = "fsl,imx8mq-noc", .data = "imx8mq-interconnect", }, > + { .compatible = "fsl,imx8mm-noc", .data = "imx8mm-interconnect", }, > + { .compatible = "fsl,imx8mn-noc", .data = "imx8mn-interconnect", }, > { .compatible = "fsl,imx8m-noc", }, > { .compatible = "fsl,imx8m-nic", }, > { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, imx_devfreq_of_match); > -- Best Regards, Chanwoo Choi Samsung Electronics