From: Michal Simek <michal.simek@xilinx.com>
To: Harsha <harsha.harsha@xilinx.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <michal.simek@xilinx.com>,
<linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>
Cc: <saratcha@xilinx.com>, <harshj@xilinx.com>
Subject: Re: [RFC PATCH 1/6] drivers: crypto: Updated Makefile for xilinx subdirectory
Date: Fri, 3 Dec 2021 14:19:17 +0100 [thread overview]
Message-ID: <4fcdf420-be35-392e-0216-8cf162c93873@xilinx.com> (raw)
In-Reply-To: <1638213623-32613-2-git-send-email-harsha.harsha@xilinx.com>
On 11/29/21 20:20, Harsha wrote:
> This patch updates the Makefile for xilinx subdirectory.
> Currently the xilinx subdirectory includes only zynqmp-aes-gcm.c.
> Since this patch series adds zynqmp-sha.c in the xilinx subdirectory,
> so the Makefile needs to be updated.
You should change this description.
CONFIG_CRYPTO_DEV_ZYNQMP_AES protects zynqmp-aes-gcm.o and it is used
twice and it is enough to use it once.
>
> Signed-off-by: Harsha <harsha.harsha@xilinx.com>
> ---
> drivers/crypto/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
> index 1fe5120..0a4fff2 100644
> --- a/drivers/crypto/Makefile
> +++ b/drivers/crypto/Makefile
> @@ -47,7 +47,7 @@ obj-$(CONFIG_CRYPTO_DEV_VMX) += vmx/
> obj-$(CONFIG_CRYPTO_DEV_BCM_SPU) += bcm/
> obj-$(CONFIG_CRYPTO_DEV_SAFEXCEL) += inside-secure/
> obj-$(CONFIG_CRYPTO_DEV_ARTPEC6) += axis/
> -obj-$(CONFIG_CRYPTO_DEV_ZYNQMP_AES) += xilinx/
> +obj-y += xilinx/
> obj-y += hisilicon/
> obj-$(CONFIG_CRYPTO_DEV_AMLOGIC_GXL) += amlogic/
> obj-y += keembay/
>
This should be regular patch not just RFC. When this is fixed feel free
to add my
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
next parent reply other threads:[~2021-12-03 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1638213623-32613-1-git-send-email-harsha.harsha@xilinx.com>
[not found] ` <1638213623-32613-2-git-send-email-harsha.harsha@xilinx.com>
2021-12-03 13:19 ` Michal Simek [this message]
[not found] ` <1638213623-32613-3-git-send-email-harsha.harsha@xilinx.com>
2021-12-03 13:20 ` [RFC PATCH 2/6] firmware: xilinx: Add ZynqMP SHA API for SHA3 functionality Michal Simek
[not found] ` <1638213623-32613-5-git-send-email-harsha.harsha@xilinx.com>
2021-12-03 13:21 ` [RFC PATCH 4/6] arm64: dts: zynqmp: Add Xilinx SHA3 node Michal Simek
2021-11-30 8:54 [RFC PATCH 0/6] crypto: Add Xilinx ZynqMP SHA3 driver support Harsha
2021-11-30 8:54 ` [RFC PATCH 1/6] drivers: crypto: Updated Makefile for xilinx subdirectory Harsha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fcdf420-be35-392e-0216-8cf162c93873@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=harsha.harsha@xilinx.com \
--cc=harshj@xilinx.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=saratcha@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).