From: Simon Budig <simon.budig@kernelconcepts.de>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
Silvio F <silvio.fricke@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Jingoo Han <jg1.han@samsung.com>,
Fugang Duan <B38611@freescale.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Input: edt-ft5x06: Add DT support
Date: Fri, 17 Jan 2014 02:39:52 +0100 [thread overview]
Message-ID: <52D889E8.6070603@kernelconcepts.de> (raw)
In-Reply-To: <20140116084943.17da0226@ipc1.ka-ro>
[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]
On 16/01/14 08:49, Lothar Waßmann wrote:
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
>>> @@ -0,0 +1,31 @@
>>> +* EDT FT5x06 Multiple Touch Controller
>>> +
> [...]
>>> +- threshold: allows setting the "click"-threshold in the range from 20 to 80.
>>> +- gain: sensitivity (0..31) (lower value -> higher sensitivity)
>>> +- offset: edge compensation (0..31)
>>> +- report_rate: report rate (3..14)
>>
>> s/_/-/ on property names please. Also, it may make sense to prefix these
>> as they're rather generic sounding names.
>>
>> Could you elaborate on these a litle please? What units are each of
>> these in? Why does it make sense to have them in the dt?
>>
> I just converted them from being passed via platform_data. I have no
> idea what they actually control and what units they use. I could not
> even find a manual where they are documented.
> Maybe Simon Budig can help out here as the original driver author.
The units are not specified in the datasheets available to me. I suspect
that these are some sort of counter values related to the cap sensing.
The defaults differ for the different size glasses, so I really suspect
these are basically just numbers.
The only somewhat reasonable unit is available for the report-rate: it
is specified as about <value> * 10 touch reports per second.
Bye,
Simon
--
Simon Budig kernel concepts GmbH
simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 Siegen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-01-17 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 10:17 [PATCH 1/2] DT: Add vendor prefix for Emerging Display Technologies Lothar Waßmann
2014-01-13 10:17 ` [PATCH 2/2] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-01-13 13:44 ` Mark Rutland
2014-01-16 7:49 ` Lothar Waßmann
2014-01-17 1:39 ` Simon Budig [this message]
2014-01-15 0:46 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D889E8.6070603@kernelconcepts.de \
--to=simon.budig@kernelconcepts.de \
--cc=B38611@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=Pawel.Moll@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=silvio.fricke@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).