From: Adam Ward <Adam.Ward.opensource@diasemi.com>
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Support Opensource <support.opensource@diasemi.com>
Subject: [PATCH V4 3/4] regulator: da9121: Prevent current limit change when enabled
Date: Mon, 29 Nov 2021 22:10:12 +0000 [thread overview]
Message-ID: <52ee682476004a1736c1e0293358987319c1c415.1638223185.git.Adam.Ward.opensource@diasemi.com> (raw)
In-Reply-To: <cover.1638223185.git.Adam.Ward.opensource@diasemi.com>
Prevent changing current limit when enabled as a precaution against
possibile instability due to tight integration with switching cycle
Signed-off-by: Adam Ward <Adam.Ward.opensource@diasemi.com>
---
drivers/regulator/da9121-regulator.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/regulator/da9121-regulator.c b/drivers/regulator/da9121-regulator.c
index a5a83b772a85..86149170bf6c 100644
--- a/drivers/regulator/da9121-regulator.c
+++ b/drivers/regulator/da9121-regulator.c
@@ -253,6 +253,11 @@ static int da9121_set_current_limit(struct regulator_dev *rdev,
goto error;
}
+ if (rdev->desc->ops->is_enabled(rdev)) {
+ ret = -EBUSY;
+ goto error;
+ }
+
ret = da9121_ceiling_selector(rdev, min_ua, max_ua, &sel);
if (ret < 0)
goto error;
--
2.25.1
next prev parent reply other threads:[~2021-11-29 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 22:10 [PATCH V4 0/4] regulator: da9121: add DA914x support Adam Ward
2021-11-29 22:10 ` [PATCH V4 1/4] dt-bindings: da9121: Remove erroneous compatible from binding Adam Ward
2021-11-29 22:10 ` [PATCH V4 2/4] dt-bindings: da9121: Add DA914x binding info Adam Ward
2021-11-29 22:10 ` Adam Ward [this message]
2021-11-29 22:10 ` [PATCH V4 4/4] regulator: da9121: Add DA914x support Adam Ward
2021-12-01 18:32 ` [PATCH V4 0/4] regulator: da9121: add " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ee682476004a1736c1e0293358987319c1c415.1638223185.git.Adam.Ward.opensource@diasemi.com \
--to=adam.ward.opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).