devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jean-Francois Moine <moinejf@free.fr>,
	alsa-devel@alsa-project.org,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xiubo Li <Li.Xiubo@freescale.com>
Subject: Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links
Date: Wed, 19 Mar 2014 20:32:06 +0200	[thread overview]
Message-ID: <5329E2A6.2040605@ti.com> (raw)
In-Reply-To: <20140319134625.GN11706@sirena.org.uk>

On 03/19/2014 03:46 PM, Mark Brown wrote:
> On Wed, Mar 19, 2014 at 12:08:55PM +0200, Jyri Sarha wrote:
>
>> While we are at it we could update the bitclock-master and frame-master
>> syntax to be like this:
>
>> bitclock-master = "cpu"
>> frame-master = "codec"
>
>> With the above explicit definition all the daifmt settings could be defined
>> in link level. For backwards compatibility we could still define that
>> omitting the value equals "codec" and omitting the property equals "cpu".
>
> It seems it'd be a bit more idiomatic to do that with a phandle rather
> than with a string in order to allow extensions for things like TDM (the
> I2S to mono speaker driver use case for example).
>

You mean a like this:

sound {
     compatible = "simple-audio-card";
     simple-audio-card,name = "Simple Audio";
     simple-audio-card,widgets = ...
     simple-audio-card,routing = ...

     simple-audio-card,dai-link@0 {        /* I2S - codec */
         format = "i2s";
         bitclock-master = <&codec 0>
         frame-master = <&codec 0>;
         bitclock-inversion = <1>;
         simple-audio-card,cpu {
             sound-dai = <&audio1 0>;
             bitclock-inversion = <0>;
         };
         simple-audio-card,codec {
             sound-dai = <&codec 0>;
             system-clock-frequency = <12000000>;
         };
     };
...

Yep, that makes sense when considering tdm setups with multiple codecs 
on the same wires.

Best regards,
Jyri

  reply	other threads:[~2014-03-19 18:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1394883134.git.moinejf@free.fr>
2014-03-15 11:30 ` [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links Jean-Francois Moine
     [not found]   ` <d054780a0edf4b2338a52e48bff9144e19aa614f.1394883134.git.moinejf-GANU6spQydw@public.gmane.org>
2014-03-17 10:19     ` [alsa-devel] " Jyri Sarha
2014-03-17 16:43     ` Mark Brown
2014-03-18  8:17       ` Jean-Francois Moine
2014-03-18 10:41         ` Mark Brown
2014-03-19 10:08         ` Jyri Sarha
     [not found]           ` <53296CB7.1000909-l0cyMroinI0@public.gmane.org>
2014-03-19 13:46             ` Mark Brown
2014-03-19 18:32               ` Jyri Sarha [this message]
2014-03-19 19:14                 ` Mark Brown
2014-03-19 16:07             ` Jean-Francois Moine
2014-03-19 18:51             ` [alsa-devel] " Lars-Peter Clausen
2014-03-19 19:15               ` Jyri Sarha
     [not found]                 ` <5329ECC2.7040803-l0cyMroinI0@public.gmane.org>
2014-03-19 19:21                   ` Mark Brown
     [not found]                     ` <20140319192157.GW11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-19 19:31                       ` Lars-Peter Clausen
     [not found]                         ` <5329F0A1.8020801-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-03-20 11:24                           ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5329E2A6.2040605@ti.com \
    --to=jsarha@ti.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moinejf@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).