From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787C6C76195 for ; Mon, 27 Mar 2023 08:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233004AbjC0IPR (ORCPT ); Mon, 27 Mar 2023 04:15:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233056AbjC0IOz (ORCPT ); Mon, 27 Mar 2023 04:14:55 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 091BA49D6 for ; Mon, 27 Mar 2023 01:14:44 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id r29so7686220wra.13 for ; Mon, 27 Mar 2023 01:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679904882; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=BwkvMWxvHh5fU55a9qvOz8SDqCvIon3uSNtLNbG8XOU=; b=UdZf/oMr3KbsHSRAuiFvMMTDu8dpMZaZN2bBy2dMO8V5T8+1sTaltgiRhqYRiFdAwr LJICXAl2CU5DZK4TdLlVNDH76/5RY1nnG8BocrmI6PkaIVYT4lBt8V8CMe5e+p7xSC2Q xTrz0b8t3fmyY39xVSfxLyAsEY/Bf8qQolTrxjrTwTpj4WUkg8c1o0QOCtKlkBIYz+a5 DOBOVaGtloGM7HgNY4eweC5kPKfhVc6idPVY+QpIE8FvfZDWmkCPVKB7kJVueA2XI+Hr v9QRIeZSKCp2huw1u0k0J0Uxg1aQJpm0GxLBx60LdzbjVZTS627QBMcs6IHhu33BfjHm e5kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679904882; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BwkvMWxvHh5fU55a9qvOz8SDqCvIon3uSNtLNbG8XOU=; b=KB/V6CRgHkjMvWw/cZG5/cxqB0GBrWLVnmMful8BbbTU2Y9plliqHGNJ0BAl0Jshn6 gJcyIAIAclg1os6Da/4r/IJLHJQKgzwyuabWDwc5EydZ71+wpWcC3ReoEztCabGgsbiv oc7jcpBht84G7Npi18NfD4EV4XZnbPX9X1pJ/cc0KvuZVn52rTqqRA7BBbn/DyQ2dusg tbfo2qGqSxegCwJVmTIsVFjcxXEioU++qDRuyOi8KxkiGV0dQYEpGlWrS/eZmKypXhOP Ky00tsnV1JXfE11h9j+j8oghU7BpI3FVXwJ70ApaM1veNM9Nz6B6+i12NnW8FVKwilvg bsJw== X-Gm-Message-State: AAQBX9eLoqvkv396kkqNp5SLeY09yF4mYzpAfbnBKiorPi+loe9PIb5K aHs060q5QEB9aqPN2d0V2YGPIQ== X-Google-Smtp-Source: AKy350a2SxlyTPUH28dY2TGWRWULx5I+GKY0+7voi0u99VBFWp8d4r2NCj/sVwhLwYgpMXiejLCLGA== X-Received: by 2002:adf:f1cb:0:b0:2cf:e8b2:4f76 with SMTP id z11-20020adff1cb000000b002cfe8b24f76mr9392235wro.66.1679904882405; Mon, 27 Mar 2023 01:14:42 -0700 (PDT) Received: from [192.168.7.111] (679773502.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id b3-20020a5d4d83000000b002dfca33ba36sm2907825wru.8.2023.03.27.01.14.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 01:14:42 -0700 (PDT) Message-ID: <5366f182-854b-105c-be93-efed5ea18ab3@linaro.org> Date: Mon, 27 Mar 2023 10:14:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 9/9] arm64: dts: qcom: sm8250: switch USB+DP QMP PHY to new style of bindings Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Johan Hovold , devicetree@vger.kernel.org References: <20230326005733.2166354-1-dmitry.baryshkov@linaro.org> <20230326005733.2166354-10-dmitry.baryshkov@linaro.org> From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20230326005733.2166354-10-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/03/2023 01:57, Dmitry Baryshkov wrote: > Change the USB QMP PHY to use newer style of QMP PHY bindings (single > resource region, no per-PHY subnodes). > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 49 ++++++++-------------------- > 1 file changed, 14 insertions(+), 35 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 7b78761f2041..24b51fb373b4 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3527,48 +3528,26 @@ usb_2_hsphy: phy@88e4000 { > resets = <&gcc GCC_QUSB2PHY_SEC_BCR>; > }; > > - usb_1_qmpphy: phy@88e9000 { > + usb_1_qmpphy: phy@88e8000 { > compatible = "qcom,sm8250-qmp-usb3-dp-phy"; > - reg = <0 0x088e9000 0 0x200>, > - <0 0x088e8000 0 0x40>, > - <0 0x088ea000 0 0x200>; > + reg = <0 0x088e8000 0 0x3000>; > status = "disabled"; > - #address-cells = <2>; > - #size-cells = <2>; > - ranges; > > clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>, > <&rpmhcc RPMH_CXO_CLK>, > - <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>; > - clock-names = "aux", "ref_clk_src", "com_aux"; > + <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>, > + <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > + clock-names = "aux", > + "ref", > + "com_aux", > + "usb3_pipe"; > > resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>, > <&gcc GCC_USB3_PHY_PRIM_BCR>; > reset-names = "phy", "common"; > > - usb_1_ssphy: usb3-phy@88e9200 { > - reg = <0 0x088e9200 0 0x200>, > - <0 0x088e9400 0 0x200>, > - <0 0x088e9c00 0 0x400>, > - <0 0x088e9600 0 0x200>, > - <0 0x088e9800 0 0x200>, > - <0 0x088e9a00 0 0x100>; > - #clock-cells = <0>; > - #phy-cells = <0>; > - clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > - clock-names = "pipe0"; > - clock-output-names = "usb3_phy_pipe_clk_src"; > - }; > - > - dp_phy: dp-phy@88ea200 { > - reg = <0 0x088ea200 0 0x200>, > - <0 0x088ea400 0 0x200>, > - <0 0x088eaa00 0 0x200>, > - <0 0x088ea600 0 0x200>, > - <0 0x088ea800 0 0x200>; > - #phy-cells = <0>; > - #clock-cells = <1>; > - }; > + #clock-cells = <1>; > + #phy-cells = <1>; > }; > > usb_2_qmpphy: phy@88eb000 { > @@ -3713,7 +3692,7 @@ usb_1_dwc3: usb@a600000 { > iommus = <&apps_smmu 0x0 0x0>; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > - phys = <&usb_1_hsphy>, <&usb_1_ssphy>; > + phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; > phy-names = "usb2-phy", "usb3-phy"; > }; > }; > @@ -4403,8 +4382,8 @@ dispcc: clock-controller@af00000 { > <&dsi0_phy 1>, > <&dsi1_phy 0>, > <&dsi1_phy 1>, > - <&dp_phy 0>, > - <&dp_phy 1>; > + <&usb_1_qmpphy QMP_USB43DP_DP_LINK_CLK>, > + <&usb_1_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>; > clock-names = "bi_tcxo", > "dsi0_phy_pll_out_byteclk", > "dsi0_phy_pll_out_dsiclk", Reviewed-by: Neil Armstrong