* [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints
@ 2018-05-16 23:32 Niklas Söderlund
2018-05-17 9:02 ` Sergei Shtylyov
2018-05-23 16:42 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Niklas Söderlund @ 2018-05-16 23:32 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: linux-media, linux-renesas-soc, Geert Uytterhoeven,
Niklas Söderlund
The style for referring to ports and endpoint are wrong. Refer to them
using lowercase and a unit address, port@x and endpoint@x.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
.../devicetree/bindings/media/rcar_vin.txt | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
index c2c57dcf73f4851b..a574b9c037c05a3c 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -45,23 +45,23 @@ The per-board settings Gen2 platforms:
The per-board settings Gen3 platforms:
Gen3 platforms can support both a single connected parallel input source
-from external SoC pins (port0) and/or multiple parallel input sources
-from local SoC CSI-2 receivers (port1) depending on SoC.
+from external SoC pins (port@0) and/or multiple parallel input sources
+from local SoC CSI-2 receivers (port@1) depending on SoC.
- renesas,id - ID number of the VIN, VINx in the documentation.
- ports
- - port 0 - sub-node describing a single endpoint connected to the VIN
+ - port@0 - sub-node describing a single endpoint connected to the VIN
from external SoC pins described in video-interfaces.txt[1].
- Describing more then one endpoint in port 0 is invalid. Only VIN
- instances that are connected to external pins should have port 0.
- - port 1 - sub-nodes describing one or more endpoints connected to
+ Describing more then one endpoint in port@0 is invalid. Only VIN
+ instances that are connected to external pins should have port@0.
+ - port@1 - sub-nodes describing one or more endpoints connected to
the VIN from local SoC CSI-2 receivers. The endpoint numbers must
use the following schema.
- - Endpoint 0 - sub-node describing the endpoint connected to CSI20
- - Endpoint 1 - sub-node describing the endpoint connected to CSI21
- - Endpoint 2 - sub-node describing the endpoint connected to CSI40
- - Endpoint 3 - sub-node describing the endpoint connected to CSI41
+ - endpoint@0 - sub-node describing the endpoint connected to CSI20
+ - endpoint@1 - sub-node describing the endpoint connected to CSI21
+ - endpoint@2 - sub-node describing the endpoint connected to CSI40
+ - endpoint@3 - sub-node describing the endpoint connected to CSI41
Device node example for Gen2 platforms
--------------------------------------
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints
2018-05-16 23:32 [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints Niklas Söderlund
@ 2018-05-17 9:02 ` Sergei Shtylyov
2018-05-23 16:42 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2018-05-17 9:02 UTC (permalink / raw)
To: Niklas Söderlund, Rob Herring, devicetree
Cc: linux-media, linux-renesas-soc, Geert Uytterhoeven
On 5/17/2018 2:32 AM, Niklas Söderlund wrote:
> The style for referring to ports and endpoint are wrong. Refer to them
> using lowercase and a unit address, port@x and endpoint@x.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
More typos, yay! :-)
> ---
> .../devicetree/bindings/media/rcar_vin.txt | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index c2c57dcf73f4851b..a574b9c037c05a3c 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -45,23 +45,23 @@ The per-board settings Gen2 platforms:
> The per-board settings Gen3 platforms:
>
> Gen3 platforms can support both a single connected parallel input source
> -from external SoC pins (port0) and/or multiple parallel input sources
> -from local SoC CSI-2 receivers (port1) depending on SoC.
> +from external SoC pins (port@0) and/or multiple parallel input sources
> +from local SoC CSI-2 receivers (port@1) depending on SoC.
>
> - renesas,id - ID number of the VIN, VINx in the documentation.
> - ports
> - - port 0 - sub-node describing a single endpoint connected to the VIN
> + - port@0 - sub-node describing a single endpoint connected to the VIN
> from external SoC pins described in video-interfaces.txt[1].
> - Describing more then one endpoint in port 0 is invalid. Only VIN
> - instances that are connected to external pins should have port 0.
> - - port 1 - sub-nodes describing one or more endpoints connected to
> + Describing more then one endpoint in port@0 is invalid. Only VIN
s/then/than/.
> + instances that are connected to external pins should have port@0.
> + - port@1 - sub-nodes describing one or more endpoints connected to
> the VIN from local SoC CSI-2 receivers. The endpoint numbers must
> use the following schema.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints
2018-05-16 23:32 [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints Niklas Söderlund
2018-05-17 9:02 ` Sergei Shtylyov
@ 2018-05-23 16:42 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-05-23 16:42 UTC (permalink / raw)
To: Niklas Söderlund
Cc: devicetree, linux-media, linux-renesas-soc, Geert Uytterhoeven
On Thu, May 17, 2018 at 01:32:12AM +0200, Niklas S�derlund wrote:
> The style for referring to ports and endpoint are wrong. Refer to them
> using lowercase and a unit address, port@x and endpoint@x.
>
> Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> .../devicetree/bindings/media/rcar_vin.txt | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-23 16:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 23:32 [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints Niklas Söderlund
2018-05-17 9:02 ` Sergei Shtylyov
2018-05-23 16:42 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).