From: Artjom Vejsel <akawolf0@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: thierry.reding@gmail.com, sam@ravnborg.org,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] drm/panel-simple: add Gopher 2b LCD panel
Date: Mon, 26 Jul 2021 14:11:11 +0300 [thread overview]
Message-ID: <54910ba4-4680-868e-94fc-88a11f9abfd9@gmail.com> (raw)
In-Reply-To: <K3HUWQ.S5LBW8E092T01@crapouillou.net>
Hello, Paul!
Thanks for your investigation.
But while this two panels are compatible with the timing set in the
driver, their timing ranges are different ([1], [2]) and therefore
should have different compatible strings.
[1]: https://wendangmao.net/doc/753b5635102de2bd960588e2-51.html
[2]: https://www.newhavendisplay.com/appnotes/datasheets/LCDs/ST7282.pdf
Artjom.
On 26/07/2021 12.02, Paul Cercueil wrote:
> Hi Artjom,
>
> Le lun., juil. 26 2021 at 01:15:27 +0300, Artjom Vejsel
> <akawolf0@gmail.com> a écrit :
>> The Gopher 2b LCD panel is used in Gopher 2b handhelds.
>> It's simple panel with NewVision NV3047 driver, but SPI lines are not
>> connected.
>> It has no specific name, since it's unique to that handhelds.
>> lot name at AliExpress: 4.3 inch 40PIN TFT LCD Screen COG NV3047
>> Drive IC 480(RGB)*272 No Touch 24Bit RGB Interface
>
> From what I gathered the Gopher2's LCD panel is the exact same that is
> inside the RS-07 handheld. According to the teardown (in [1]), the
> RS-07 panel is a Amelin AML043056B0-40 (see [2]).
>
> Could you verify that? According to the photos, the product code is
> written on the flexible connector.
>
> If that's the case, instead of using the
> "qishenglong,gopher2b-lcd-panel" compatible string, could you use
> "amelin,aml043056b0-40"?
>
> Cheers,
> -Paul
>
> [1]: https://steward-fu.github.io/website/handheld/rs07/teardown.htm
> [2]: http://www.amelin.com.cn/en/h-pd-355.html
>
>>
>> Signed-off-by: Artjom Vejsel <akawolf0@gmail.com>
>> ---
>> drivers/gpu/drm/panel/panel-simple.c | 43 ++++++++++++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c
>> b/drivers/gpu/drm/panel/panel-simple.c
>> index 9b286bd4444f..6b69c0c70814 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -3563,6 +3563,46 @@ static const struct panel_desc qd43003c0_40 = {
>> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>> };
>>
>> +static const struct drm_display_mode
>> qishenglong_gopher2b_lcd_panel_modes[] = {
>> + { /* 60 Hz */
>> + .clock = 10800,
>> + .hdisplay = 480,
>> + .hsync_start = 480 + 77,
>> + .hsync_end = 480 + 77 + 41,
>> + .htotal = 480 + 77 + 41 + 2,
>> + .vdisplay = 272,
>> + .vsync_start = 272 + 16,
>> + .vsync_end = 272 + 16 + 10,
>> + .vtotal = 272 + 16 + 10 + 2,
>> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
>> + },
>> + { /* 50 Hz */
>> + .clock = 10800,
>> + .hdisplay = 480,
>> + .hsync_start = 480 + 17,
>> + .hsync_end = 480 + 17 + 41,
>> + .htotal = 480 + 17 + 41 + 2,
>> + .vdisplay = 272,
>> + .vsync_start = 272 + 116,
>> + .vsync_end = 272 + 116 + 10,
>> + .vtotal = 272 + 116 + 10 + 2,
>> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
>> + },
>> +};
>> +
>> +static const struct panel_desc qishenglong_gopher2b_lcd_panel = {
>> + .modes = qishenglong_gopher2b_lcd_panel_modes,
>> + .num_modes = ARRAY_SIZE(qishenglong_gopher2b_lcd_panel_modes),
>> + .bpc = 8,
>> + .size = {
>> + .width = 95,
>> + .height = 54,
>> + },
>> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>> + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
>> DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
>> + .connector_type = DRM_MODE_CONNECTOR_DPI,
>> +};
>> +
>> static const struct display_timing rocktech_rk070er9427_timing = {
>> .pixelclock = { 26400000, 33300000, 46800000 },
>> .hactive = { 800, 800, 800 },
>> @@ -4651,6 +4691,9 @@ static const struct of_device_id
>> platform_of_match[] = {
>> }, {
>> .compatible = "qiaodian,qd43003c0-40",
>> .data = &qd43003c0_40,
>> + }, {
>> + .compatible = "qishenglong,gopher2b-lcd-panel",
>> + .data = &qishenglong_gopher2b_lcd_panel,
>> }, {
>> .compatible = "rocktech,rk070er9427",
>> .data = &rocktech_rk070er9427,
>> --
>> 2.32.0
>>
>
>
prev parent reply other threads:[~2021-07-26 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 22:15 [PATCH v3 0/3] add Gopher 2b LCD panel Artjom Vejsel
2021-07-25 22:15 ` [PATCH v3 1/3] dt-bindings: Add QiShenglong vendor prefix Artjom Vejsel
2021-07-25 23:06 ` Paul Cercueil
2021-07-26 22:49 ` Rob Herring
2021-07-25 22:15 ` [PATCH v3 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel Artjom Vejsel
2021-07-25 23:06 ` Paul Cercueil
2021-07-26 22:51 ` Rob Herring
2021-07-25 22:15 ` [PATCH v3 3/3] drm/panel-simple: add Gopher 2b LCD panel Artjom Vejsel
2021-07-25 23:07 ` Paul Cercueil
2021-07-26 9:02 ` Paul Cercueil
2021-07-26 11:11 ` Artjom Vejsel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54910ba4-4680-868e-94fc-88a11f9abfd9@gmail.com \
--to=akawolf0@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).