From: Guenter Roeck <linux@roeck-us.net>
To: Kyle Tso <kyletso@google.com>,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
robh+dt@kernel.org, hdegoede@redhat.com, badhri@google.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: connector: Add SVDM VDO properties
Date: Tue, 26 Jan 2021 07:15:59 -0800 [thread overview]
Message-ID: <55d175fe-863e-7fb5-073a-d18f62e59038@roeck-us.net> (raw)
In-Reply-To: <20210126084544.682641-3-kyletso@google.com>
On 1/26/21 12:45 AM, Kyle Tso wrote:
> Add bindings of VDO properties of USB PD SVDM so that they can be
> defined in device tree.
>
> Signed-off-by: Kyle Tso <kyletso@google.com>
Are you also going to update
Documentation/devicetree/bindings/connector/usb-connector.yaml ?
Thanks,
Guenter
> ---
> include/dt-bindings/usb/pd.h | 53 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 52 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
> index 0352893697f0..b99cb4a0cd12 100644
> --- a/include/dt-bindings/usb/pd.h
> +++ b/include/dt-bindings/usb/pd.h
> @@ -93,4 +93,55 @@
> #define FRS_DEFAULT_POWER 1
> #define FRS_5V_1P5A 2
> #define FRS_5V_3A 3
> - #endif /* __DT_POWER_DELIVERY_H */
> +
> +/*
> + * SVDM Identity Header
> + * --------------------
> + * <31> :: data capable as a USB host
> + * <30> :: data capable as a USB device
> + * <29:27> :: product type (UFP / Cable / VPD)
> + * <26> :: modal operation supported (1b == yes)
> + * <25:23> :: product type (DFP) (SVDM version 2.0+ only; set to zero in version 1.0)
> + * <22:21> :: connector type (SVDM version 2.0+ only; set to zero in version 1.0)
> + * <20:16> :: Reserved, Shall be set to zero
> + * <15:0> :: USB-IF assigned VID for this cable vendor
> + */
> +/* SOP Product Type (UFP) */
> +#define IDH_PTYPE_NOT_UFP 0
> +#define IDH_PTYPE_HUB 1
> +#define IDH_PTYPE_PERIPH 2
> +#define IDH_PTYPE_PSD 3
> +#define IDH_PTYPE_AMA 5
> +
> +/* SOP' Product Type (Cable Plug / VPD) */
> +#define IDH_PTYPE_NOT_CABLE 0
> +#define IDH_PTYPE_PCABLE 3
> +#define IDH_PTYPE_ACABLE 4
> +#define IDH_PTYPE_VPD 6
> +
> +/* SOP Product Type (DFP) */
> +#define IDH_PTYPE_NOT_DFP 0
> +#define IDH_PTYPE_DFP_HUB 1
> +#define IDH_PTYPE_DFP_HOST 2
> +#define IDH_PTYPE_DFP_PB 3
> +
> +#define VDO_IDH(usbh, usbd, ufp_cable, is_modal, dfp, conn, vid) \
> + ((usbh) << 31 | (usbd) << 30 | ((ufp_cable) & 0x7) << 27 \
> + | (is_modal) << 26 | ((dfp) & 0x7) << 23 | ((conn) & 0x3) << 21 \
> + | ((vid) & 0xffff))
> +
> +/*
> + * Cert Stat VDO
> + * -------------
> + * <31:0> : USB-IF assigned XID for this cable
> + */
> +#define VDO_CERT(xid) ((xid) & 0xffffffff)
> +
> +/*
> + * Product VDO
> + * -----------
> + * <31:16> : USB Product ID
> + * <15:0> : USB bcdDevice
> + */
> +#define VDO_PRODUCT(pid, bcd) (((pid) & 0xffff) << 16 | ((bcd) & 0xffff))
> +#endif /* __DT_POWER_DELIVERY_H */
>
next prev parent reply other threads:[~2021-01-26 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:45 [PATCH 0/3] common SVDM version and VDO from dt Kyle Tso
2021-01-26 8:45 ` [PATCH 1/3] usb: typec: Determine common SVDM Versions Kyle Tso
2021-01-26 15:07 ` Guenter Roeck
2021-01-26 8:45 ` [PATCH 2/3] dt-bindings: connector: Add SVDM VDO properties Kyle Tso
2021-01-26 15:15 ` Guenter Roeck [this message]
2021-01-26 8:45 ` [PATCH 3/3] usb: typec: tcpm: Get Sink VDO from fwnode Kyle Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d175fe-863e-7fb5-073a-d18f62e59038@roeck-us.net \
--to=linux@roeck-us.net \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).